When cancelling an edit of an inline with content, don't hide the inline
ClosedPublic
Actions

Authored by epriestley on May 22 2020, 10:29 PM.

Tags

None

Referenced Files

	F19083337: D21286.id50688.diff
	Tue, Dec 2, 12:34 PM

	F18985491: D21286.id50687.diff
	Mon, Nov 17, 1:04 PM

	F18829942: D21286.id.diff
	Oct 25 2025, 2:35 AM

	F18807170: D21286.diff
	Oct 18 2025, 11:35 PM

	F18788509: D21286.id50688.diff
	Oct 15 2025, 5:14 AM

	F18754436: D21286.id50688.diff
	Oct 4 2025, 11:02 PM

	F18735229: D21286.id50687.diff
	Oct 1 2025, 12:23 AM

	F18734302: D21286.id.diff
	Sep 30 2025, 10:51 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP4042ea648518: (stable) When cancelling an edit of an inline with content, don't hide the…
rP3635a11f848f: When cancelling an edit of an inline with content, don't hide the inline

Summary

See PHI1753. This condition got rewritten for suggested edits and accidentally inverted.

Test Plan

Create a comment, type text, save draft, edit comment, cancel.
Before: comment hides itself.
After: comment properly cancels into pre-edit draft state.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 22 2020, 10:29 PM

Harbormaster completed remote builds in B24507: Diff 50687.May 22 2020, 10:30 PM

epriestley requested review of this revision.May 22 2020, 10:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2020, 10:40 PM

Closed by commit rP3635a11f848f: When cancelling an edit of an inline with content, don't hide the inline (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP3635a11f848f: When cancelling an edit of an inline with content, don't hide the inline.

epriestley added a commit: rP4042ea648518: (stable) When cancelling an edit of an inline with content, don't hide the….

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

2 lines

Diff 50688

View Options

resources/celerity/map.php