Page MenuHomePhabricator
Feed All Stories

Tue, May 19

epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • The inline comment context menu does not apply the correct cursor ("pointer").
Tue, May 19, 4:27 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21268: Fix "r" and "R" both replying with quote on inline comments.
Tue, May 19, 4:26 PM · Inline Comments, Diffusion, Differential
epriestley updated the task description for T13539: Obscure end-of-file changes may choke the changeset highlighter.
Tue, May 19, 4:07 PM · Differential
epriestley committed rP1157f2782277: (stable) Fix an unusual issue with intradiff highlighting of files with… (authored by epriestley).
(stable) Fix an unusual issue with intradiff highlighting of files with…
Tue, May 19, 4:06 PM
epriestley committed rP6cf017d68003: Fix an unusual issue with intradiff highlighting of files with uncommon end-of… (authored by epriestley).
Fix an unusual issue with intradiff highlighting of files with uncommon end-of…
Tue, May 19, 4:06 PM
epriestley closed D21267: Fix an unusual issue with intradiff highlighting of files with uncommon end-of-file modifications.
Tue, May 19, 4:06 PM
epriestley closed T13539: Obscure end-of-file changes may choke the changeset highlighter as Resolved by committing rP6cf017d68003: Fix an unusual issue with intradiff highlighting of files with uncommon end-of….
Tue, May 19, 4:06 PM · Differential
epriestley requested review of D21267: Fix an unusual issue with intradiff highlighting of files with uncommon end-of-file modifications.
Tue, May 19, 4:05 PM
epriestley added a revision to T13539: Obscure end-of-file changes may choke the changeset highlighter: D21267: Fix an unusual issue with intradiff highlighting of files with uncommon end-of-file modifications.
Tue, May 19, 4:04 PM · Differential
epriestley triaged T13539: Obscure end-of-file changes may choke the changeset highlighter as Low priority.
Tue, May 19, 3:49 PM · Differential
epriestley added a comment to T13538: Git commits with no commit message fail to import/parse.

These particular issues blame to D21027, which began extracting null in all cases where a field has no value for a given commit. This is not entirely faithful, as it can not distinguish between "field absent" and "field present, but with an empty value". At least for author, these are distinct states that can be independently constructed using git hash-object:

Tue, May 19, 3:31 AM · Diffusion
epriestley added a comment to T13538: Git commits with no commit message fail to import/parse.

From PHI1739, --allow-empty-message supports constructing these commits more easily (via a normal git commit rather than git hash-object).

Tue, May 19, 3:05 AM · Diffusion
epriestley committed rP40aab725e825: (stable) Survive importing Git commits with no commit message and/or no author (authored by epriestley).
(stable) Survive importing Git commits with no commit message and/or no author
Tue, May 19, 3:02 AM
epriestley committed rP0c51885cf7b2: Survive importing Git commits with no commit message and/or no author (authored by epriestley).
Survive importing Git commits with no commit message and/or no author
Tue, May 19, 3:02 AM
epriestley closed D21266: Survive importing Git commits with no commit message and/or no author.
Tue, May 19, 3:02 AM
epriestley requested review of D21266: Survive importing Git commits with no commit message and/or no author.
Tue, May 19, 3:01 AM
epriestley added a revision to T13538: Git commits with no commit message fail to import/parse: D21266: Survive importing Git commits with no commit message and/or no author.
Tue, May 19, 3:00 AM · Diffusion
epriestley added a comment to T13538: Git commits with no commit message fail to import/parse.

Second issue:

Tue, May 19, 2:50 AM · Diffusion
epriestley added a comment to T13538: Git commits with no commit message fail to import/parse.

First issue:

Tue, May 19, 2:48 AM · Diffusion
epriestley added a comment to T13538: Git commits with no commit message fail to import/parse.

Alas, you can't actually push the perfect commit:

Tue, May 19, 2:40 AM · Diffusion
epriestley triaged T13538: Git commits with no commit message fail to import/parse as Normal priority.
Tue, May 19, 2:37 AM · Diffusion

Mon, May 18

epriestley committed rPf86d822a37ea: Update MySQL schema inspection code for deprecation of integer display widths (authored by epriestley).
Update MySQL schema inspection code for deprecation of integer display widths
Mon, May 18, 7:10 PM
epriestley closed T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE" as Resolved by committing rPf86d822a37ea: Update MySQL schema inspection code for deprecation of integer display widths.
Mon, May 18, 7:10 PM · Infrastructure
epriestley closed D21265: Update MySQL schema inspection code for deprecation of integer display widths.
Mon, May 18, 7:10 PM
epriestley requested review of D21265: Update MySQL schema inspection code for deprecation of integer display widths.
Mon, May 18, 7:10 PM
epriestley updated the task description for T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE".
Mon, May 18, 7:10 PM · Infrastructure
epriestley added a revision to T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE": D21265: Update MySQL schema inspection code for deprecation of integer display widths.
Mon, May 18, 7:09 PM · Infrastructure
epriestley added a comment to T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE".

The actual query we use to inspect table information is:

Mon, May 18, 6:46 PM · Infrastructure
epriestley added a comment to T7149: Allow users to import data into a new Phacility instance.

See T13537 for a subtle issue where digestWithNamedKey() keys were cached in APCu on the web tier. Importing instance data may require restarting the web tier until the import process can either dump these caches or version them (versioning may be easier).

Mon, May 18, 5:38 PM · Phacility
epriestley added a comment to T13537: Support local port forwarding through Phacility cluster bastion hosts.

So I'm going to turn web off and on again and see if that fixes things; my expectation is that it will.

Mon, May 18, 5:36 PM · Phacility
epriestley added a comment to T13537: Support local port forwarding through Phacility cluster bastion hosts.

The specific issue I'm trying to debug is fairly bizarre.

Mon, May 18, 5:35 PM · Phacility
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
Mon, May 18, 4:59 PM · Phacility
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
Mon, May 18, 4:56 PM · Phacility
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
Mon, May 18, 4:47 PM · Phacility
epriestley updated the task description for T13537: Support local port forwarding through Phacility cluster bastion hosts.
Mon, May 18, 4:37 PM · Phacility
epriestley triaged T13537: Support local port forwarding through Phacility cluster bastion hosts as Low priority.
Mon, May 18, 4:33 PM · Phacility
epriestley added a comment to Blog Post: Quick Look: Inline Comments on Character Ranges.

Thanks! I figured out how to make somewhat-reasonable GIFs with ffmpeg.

Mon, May 18, 4:04 PM · Quick Look, Differential
20after4 added a comment to Blog Post: Quick Look: Inline Comments on Character Ranges.

Thanks for the quick-look posts, these are nice.

Mon, May 18, 3:58 PM · Quick Look, Differential
epriestley committed rP7b0db3eb54b9: Fix an email address validation UI feedback issue when creating new users (authored by epriestley).
Fix an email address validation UI feedback issue when creating new users
Mon, May 18, 2:35 PM
epriestley closed D21264: Fix an email address validation UI feedback issue when creating new users.
Mon, May 18, 2:35 PM
epriestley requested review of D21264: Fix an email address validation UI feedback issue when creating new users.
Mon, May 18, 2:34 PM

Sun, May 17

epriestley renamed T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE" from MySQL "SHOW CREATE TABLE" syntax has changed for integers to In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE".
Sun, May 17, 3:53 PM · Infrastructure
epriestley triaged T13536: In or around 8.0.19, MySQL has removed integer display width information, changing the syntax of "SHOW CREATE TABLE" as Low priority.
Sun, May 17, 3:53 PM · Infrastructure

Fri, May 15

Harbormaster failed to build B24452: rPb24bac5afbd4: (stable) Fix an out-of-order access issue with inlines for rPb24bac5afbd4: (stable) Fix an out-of-order access issue with inlines!
Fri, May 15, 8:59 PM
Harbormaster failed to build B24451: rP93b08f0e83e6: Fix an out-of-order access issue with inlines for rP93b08f0e83e6: Fix an out-of-order access issue with inlines!
Fri, May 15, 8:59 PM
epriestley committed rPb24bac5afbd4: (stable) Fix an out-of-order access issue with inlines (authored by epriestley).
(stable) Fix an out-of-order access issue with inlines
Fri, May 15, 8:56 PM
epriestley committed rP93b08f0e83e6: Fix an out-of-order access issue with inlines (authored by epriestley).
Fix an out-of-order access issue with inlines
Fri, May 15, 8:56 PM
epriestley closed D21263: Fix an out-of-order access issue with inlines.
Fri, May 15, 8:56 PM
epriestley edited the content of Changelog.
Fri, May 15, 8:55 PM
epriestley updated the post content for Blog Post: Quick Look: Jupyter Diff Context.
Fri, May 15, 8:54 PM · Quick Look, Differential
epriestley created an object: 2020 Week 19 (Mid May).
Fri, May 15, 8:53 PM
epriestley updated the subtitle for Blog Post: Quick Look: Jupyter Diff Context.
Fri, May 15, 8:52 PM · Quick Look, Differential
epriestley created Blog Post: Quick Look: Inline Comments on Character Ranges.
Fri, May 15, 8:52 PM · Quick Look, Differential
epriestley requested review of D21263: Fix an out-of-order access issue with inlines.
Fri, May 15, 8:28 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21263: Fix an out-of-order access issue with inlines.
Fri, May 15, 8:27 PM · Inline Comments, Diffusion, Differential
epriestley renamed Blog Post: Quick Look: Jupyter Diff Context blog post from Quick Look: Jupyter Diff Context (2020 Week 18) to Quick Look: Jupyter Diff Context.
Fri, May 15, 8:23 PM · Quick Look, Differential
epriestley created Blog Post: Quick Look: Jupyter Diff Context.
Fri, May 15, 8:22 PM · Quick Look, Differential
epriestley created Quick Look.
Fri, May 15, 8:19 PM
epriestley committed rARCa5bfb968cd90: (stable) Promote 2020 Week 19 (authored by epriestley).
(stable) Promote 2020 Week 19
Fri, May 15, 8:00 PM
epriestley committed rP686e51655bb0: (stable) Promote 2020 Week 19 (authored by epriestley).
(stable) Promote 2020 Week 19
Fri, May 15, 8:00 PM
epriestley committed rPe959f934893c: Use a more consistent inline highlighting style with fewer redraws (authored by epriestley).
Use a more consistent inline highlighting style with fewer redraws
Fri, May 15, 7:44 PM
epriestley closed D21262: Use a more consistent inline highlighting style with fewer redraws.
Fri, May 15, 7:44 PM
epriestley requested review of D21262: Use a more consistent inline highlighting style with fewer redraws.
Fri, May 15, 7:44 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21262: Use a more consistent inline highlighting style with fewer redraws.
Fri, May 15, 7:43 PM · Inline Comments, Diffusion, Differential
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Fri, May 15, 4:42 PM · Differential
epriestley committed rPc666cb9f0bc7: Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions (authored by epriestley).
Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
Fri, May 15, 4:37 PM
epriestley closed D21261: Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions.
Fri, May 15, 4:37 PM
epriestley requested review of D21261: Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions.
Fri, May 15, 4:36 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21261: Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions.
Fri, May 15, 4:35 PM · Inline Comments, Diffusion, Differential
epriestley committed rARCbee3bc0570a3: (stable) Allow construction of a ConduitEngine with a bare ConduitClient (authored by epriestley).
(stable) Allow construction of a ConduitEngine with a bare ConduitClient
Fri, May 15, 3:24 PM
epriestley committed rARCe3030ebcad53: Allow construction of a ConduitEngine with a bare ConduitClient (authored by epriestley).
Allow construction of a ConduitEngine with a bare ConduitClient
Fri, May 15, 3:24 PM
epriestley closed D21260: Allow construction of a ConduitEngine with a bare ConduitClient.
Fri, May 15, 3:24 PM
epriestley requested review of D21260: Allow construction of a ConduitEngine with a bare ConduitClient.
Fri, May 15, 3:24 PM
epriestley committed rPb1351d0fdb81: Remove code which overrides "diffusion.ssh-username" when instanced (authored by epriestley).
Remove code which overrides "diffusion.ssh-username" when instanced
Fri, May 15, 2:45 PM
epriestley closed D21259: Remove code which overrides "diffusion.ssh-username" when instanced.
Fri, May 15, 2:45 PM
epriestley requested review of D21259: Remove code which overrides "diffusion.ssh-username" when instanced.
Fri, May 15, 1:32 PM
epriestley added a revision to T13529: Phacility domain rename errata and SSH user identity: D21259: Remove code which overrides "diffusion.ssh-username" when instanced.
Fri, May 15, 1:31 PM · Phacility
PXke added a member for Arcanist: PXke.
Fri, May 15, 1:16 PM
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.
  • The line-triggered reticle should be updated to use the hover-reticle cell style.
Fri, May 15, 12:24 PM · Inline Comments, Diffusion, Differential
avivey committed rARC2d8156a72767: update SSL error messge re:libphutil (authored by avivey).
update SSL error messge re:libphutil
Fri, May 15, 12:15 PM
avivey closed D21258: update SSL error messge re:libphutil.
Fri, May 15, 12:15 PM
epriestley accepted D21258: update SSL error messge re:libphutil.

still talk about "libphutil libraries" a lot.

Fri, May 15, 12:06 PM
avivey added a comment to D21258: update SSL error messge re:libphutil.

I left other references because it looks like we still talk about "libphutil libraries" a lot.

Fri, May 15, 8:51 AM
avivey requested review of D21258: update SSL error messge re:libphutil.
Fri, May 15, 8:50 AM
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

Fri, May 15, 12:03 AM · Inline Comments, Diffusion, Differential

Thu, May 14

epriestley committed rP3ee6b5393c77: Improve offset/range inline behavior for rich diffs and unified diffs (authored by epriestley).
Improve offset/range inline behavior for rich diffs and unified diffs
Thu, May 14, 11:02 PM
epriestley closed D21257: Improve offset/range inline behavior for rich diffs and unified diffs.
Thu, May 14, 11:02 PM
epriestley updated the task description for T13534: Inline Comment errata after editing persistence.
Thu, May 14, 10:56 PM · Differential
epriestley requested review of D21257: Improve offset/range inline behavior for rich diffs and unified diffs.
Thu, May 14, 10:55 PM
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21257: Improve offset/range inline behavior for rich diffs and unified diffs.
Thu, May 14, 10:53 PM · Inline Comments, Diffusion, Differential
epriestley committed rPfbd57ad83232: Give selected inline comments are more obvious selected state (authored by epriestley).
Give selected inline comments are more obvious selected state
Thu, May 14, 9:36 PM
epriestley closed D21256: Give selected inline comments are more obvious selected state.
Thu, May 14, 9:36 PM
epriestley committed rPb021da71a52d: When users click headers to select diff UI elements, don't eat the events (authored by epriestley).
When users click headers to select diff UI elements, don't eat the events
Thu, May 14, 9:34 PM
epriestley closed D21255: When users click headers to select diff UI elements, don't eat the events.
Thu, May 14, 9:34 PM
epriestley committed rP42f1a95a1255: Fix a flash of document selection when "oncopy" and "inline on range" behaviors… (authored by epriestley).
Fix a flash of document selection when "oncopy" and "inline on range" behaviors…
Thu, May 14, 9:29 PM
epriestley closed D21254: Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact.
Thu, May 14, 9:29 PM
epriestley committed rPf45519c0604b: When cancelling an inline comment edit, exit the edit state after the response… (authored by epriestley).
When cancelling an inline comment edit, exit the edit state after the response…
Thu, May 14, 9:28 PM
epriestley closed D21253: When cancelling an inline comment edit, exit the edit state after the response arrives.
Thu, May 14, 9:28 PM
epriestley committed rPcfb5de6fa77f: Distinguish more carefully between "null" inline offsets and "0" inline offsets (authored by epriestley).
Distinguish more carefully between "null" inline offsets and "0" inline offsets
Thu, May 14, 9:27 PM
epriestley closed D21252: Distinguish more carefully between "null" inline offsets and "0" inline offsets.
Thu, May 14, 9:27 PM