Paths

Table of Contentst

Differential D21270

Update out-of-date API calls when rendering diffs inline in email
ClosedPublic
Actions

Authored by epriestley on May 19 2020, 5:31 PM.

Tags

None

Referenced Files

	F14091694: D21270.diff
	Mon, Nov 25, 1:32 AM

	Unknown Object (File)
	Thu, Nov 21, 7:42 AM

	Unknown Object (File)
	Sat, Nov 16, 5:46 PM

	Unknown Object (File)
	Mon, Oct 28, 5:24 PM

	Unknown Object (File)
	Oct 15 2024, 6:41 PM

	Unknown Object (File)
	Oct 14 2024, 6:46 AM

	Unknown Object (File)
	Sep 15 2024, 6:02 AM

	Unknown Object (File)
	Sep 7 2024, 11:54 PM

Subscribers

None

Details

Reviewers: None
Commits: rP400c555666c5: (stable) Update out-of-date API calls when rendering diffs inline in email
rP43a8d8763df3: Update out-of-date API calls when rendering diffs inline in email

Summary

See PHI1745. This callsite for "ChangesetParser" was not properly updated for recent changes.

Test Plan

Set metamta.differential.inline-patches to 100.
Created a new revision with a small (<100 line) diff, with at least one reviewer.
Ran bin/phd debug and observed outbound mail queue with bin/mail list-outbound.
Before: fatal when trying to generate the inline changes for mail.
After: clean mail generation.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 19 2020, 5:31 PM

Harbormaster completed remote builds in B24469: Diff 50650.May 19 2020, 5:32 PM

epriestley requested review of this revision.May 19 2020, 5:32 PM

epriestley mentioned this in D21271: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue.May 19 2020, 5:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2020, 5:40 PM

Closed by commit rP43a8d8763df3: Update out-of-date API calls when rendering diffs inline in email (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP43a8d8763df3: Update out-of-date API calls when rendering diffs inline in email.

epriestley added a commit: rP400c555666c5: (stable) Update out-of-date API calls when rendering diffs inline in email.

epriestley mentioned this in rP4257b26abc61: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the….

epriestley mentioned this in rP1aa0569b6086: (stable) Treat PHP7 "Throwable" exceptions like other unhandled "Exception"….May 19 2020, 5:42 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

mail/

DifferentialChangeDetailMailView.php

4 lines

Diff 50652

src/applications/differential/mail/DifferentialChangeDetailMailView.php

Loading...