Page MenuHomePhabricator

Update out-of-date API calls when rendering diffs inline in email
ClosedPublic

Authored by epriestley on May 19 2020, 5:31 PM.
Tags
None
Referenced Files
F13304885: D21270.diff
Sat, Jun 8, 2:01 PM
F13290067: D21270.diff
Tue, Jun 4, 4:04 PM
F13274726: D21270.diff
Fri, May 31, 4:01 AM
F13270860: D21270.diff
Wed, May 29, 1:09 PM
F13260784: D21270.diff
Mon, May 27, 12:23 AM
F13244875: D21270.diff
Thu, May 23, 5:23 AM
F13198144: D21270.id50650.diff
May 13 2024, 4:26 AM
F13195012: D21270.diff
May 12 2024, 10:03 PM
Subscribers
None

Details

Summary

See PHI1745. This callsite for "ChangesetParser" was not properly updated for recent changes.

Test Plan
  • Set metamta.differential.inline-patches to 100.
  • Created a new revision with a small (<100 line) diff, with at least one reviewer.
  • Ran bin/phd debug and observed outbound mail queue with bin/mail list-outbound.
  • Before: fatal when trying to generate the inline changes for mail.
  • After: clean mail generation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable