Page MenuHomePhabricator

Make "Open in Editor" use the simple line number of the current selected block
ClosedPublic

Authored by epriestley on Thu, May 21, 9:30 PM.

Details

Summary

Ref PHI1749. Instead of opening files to the last unchanged line on either side of the change, open files to the "simple" line number of the selected block.

For inlines, this is the inline line number.

For blocks, this is the first new-file line number, or the first old-file line number if no new-file line number exists in the block.

This may not always be what the user is hoping for (we can't know what the state of their working copy is) but should produce more obvious behavior.

Test Plan
  • In Diffusion, used "Open in Editor" with and without line selections. Saw same behavior as before.
  • Used "n" and "r" to leave an inline with the keyboard, saw same behavior as before.
  • Used "\" and "Open in Editor" menu item to open a file with:
    • Nothing selected or changeset selected (line: 1).
    • An inline selected (line: inline line).
    • A block selected (line: first line in block, per above).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 50677.Thu, May 21, 9:30 PM
epriestley created this revision.
  • Remove debugging code.
Harbormaster completed remote builds in B24496: Diff 50677.
epriestley requested review of this revision.Thu, May 21, 9:32 PM
epriestley updated this revision to Diff 50678.Thu, May 21, 9:44 PM
  • Ignore selected elements that are not part of the current changeset.
This revision was not accepted when it landed; it landed in state Needs Review.Thu, May 21, 10:31 PM
This revision was automatically updated to reflect the committed changes.