Page MenuHomePhabricator

Roughly support inline comment suggestions
ClosedPublic

Authored by epriestley on Wed, May 20, 3:16 PM.

Details

Summary

Ref T13513. This still has quite a few rough edges and some significant performance isssues, but appears to mostly work.

Allow reviewers to "Suggest Edit" on an inline comment and provide replacement text for the highlighted source.

Test Plan

Created, edited, reloaded, and submitted inline comments in various states with and without suggestion text.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, May 20, 3:16 PM
epriestley requested review of this revision.Wed, May 20, 3:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, May 20, 9:26 PM
This revision was automatically updated to reflect the committed changes.