Page MenuHomePhabricator

Roughly support inline comment suggestions
ClosedPublic

Authored by epriestley on May 20 2020, 3:16 PM.
Tags
None
Referenced Files
F14748214: D21276.diff
Tue, Jan 21, 10:32 AM
Unknown Object (File)
Mon, Jan 13, 6:45 PM
Unknown Object (File)
Sun, Jan 12, 9:07 PM
Unknown Object (File)
Fri, Jan 3, 1:06 AM
Unknown Object (File)
Fri, Dec 27, 6:47 PM
Unknown Object (File)
Dec 20 2024, 4:18 PM
Unknown Object (File)
Dec 11 2024, 9:20 AM
Unknown Object (File)
Dec 7 2024, 4:39 AM
Subscribers
None

Details

Summary

Ref T13513. This still has quite a few rough edges and some significant performance isssues, but appears to mostly work.

Allow reviewers to "Suggest Edit" on an inline comment and provide replacement text for the highlighted source.

Test Plan

Created, edited, reloaded, and submitted inline comments in various states with and without suggestion text.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2020, 9:26 PM
This revision was automatically updated to reflect the committed changes.