(stable) Promote 2020 Week 20
Audit Required73024e454239
Actions

Description

(stable) Promote 2020 Week 20

Details

Group Auditors

Provenance

epriestley	Authored on May 22 2020, 9:22 PM
epriestley	Pushed on May 22 2020, 9:23 PM

Parents

rP959a835b95dd: When executing a repository passthru command via CommandEngine, don't set a…
rP828798f3e1b4: (stable) Fix two rendering issues with Jupyter notebooks

Branches

Unknown

Tags

Unknown

Build Status

Buildable 24506
Build 33771: Run Core Tests

Event Timeline

epriestley committed rP73024e454239: (stable) Promote 2020 Week 20 (authored by epriestley).May 22 2020, 9:22 PM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptMay 22 2020, 9:23 PM

This commit now requires audit.May 22 2020, 9:23 PM

Harbormaster completed building B24506: rP73024e454239: (stable) Promote 2020 Week 20.May 22 2020, 9:24 PM

Merged Changes

959a835b95dd When executing a repository passthru command via CommandEngine, don't set a…
Author
epriestley
Revisions
D21284: When executing a repository passthru command via CommandEngine, don't set a timeout
Browse Repository
Passed
No Audits
4fd0628fae45 Fix two rendering issues with Jupyter notebooks
Author
epriestley
Revisions
D21285: Fix two rendering issues with Jupyter notebooks
Browse Repository
Passed
No Audits
87fb35abb72e Prevent keyboard selection of change blocks inside edit suggestions
Author
epriestley
Revisions
D21283: Prevent keyboard selection of change blocks inside edit suggestions
Browse Repository
Passed
No Audits
66566f878d82 Make "Open in Editor" use the simple line number of the current selected block
Author
epriestley
Revisions
D21282: Make "Open in Editor" use the simple line number of the current selected block
Browse Repository
Passed
No Audits
d3d41324be9f Drop old "differential_commit" table
Author
epriestley
Revisions
D21281: Drop old "differential_commit" table
Browse Repository
Passed
No Audits
6d0dbeb77f77 Use the changeset parse cache to cache suggestion changesets
Author
epriestley
Revisions
D21280: Use the changeset parse cache to cache suggestion changesets
Browse Repository
Passed
No Audits
5d0ae283a9ab Put a readthrough cache in front of inline context construction
Author
epriestley
Revisions
D21279: Put a readthrough cache in front of inline context construction
Browse Repository
Passed
No Audits
d2d7e7f5ff1b Clean up Diffusion behaviors for inline edit suggestions
Author
epriestley
Revisions
D21278: Clean up Diffusion behaviors for inline edit suggestions
Browse Repository
Passed
No Audits
10f241352dce Render inline comment suggestions as real diffs
Author
epriestley
Revisions
D21277: Render inline comment suggestions as real diffs
Browse Repository
Passed
No Audits
846562158aae Roughly support inline comment suggestions
Author
epriestley
Revisions
D21276: Roughly support inline comment suggestions
Browse Repository
Passed
No Audits
00430fdbe117 Make server components of inline comment content handling state-oriented
Author
epriestley
Revisions
D21275: Make server components of inline comment content handling state-oriented
Browse Repository
Passed
No Audits
4b2a447003be Allow "has draft inlines?" queries to overheat
Author
epriestley
Revisions
D21274: Allow "has draft inlines?" queries to overheat
Browse Repository
Passed
No Audits
87bc30526b7a Make inline content "state-oriented", not "string-oriented"
Author
epriestley
Revisions
D21273: Make inline content "state-oriented", not "string-oriented"
Browse Repository
Passed
No Audits
9d5b8bd14a97 Remove PHPMailer code which generates bogus "Message-ID" email headers
Author
epriestley
Revisions
D21272: Remove PHPMailer code which generates bogus "Message-ID" email headers
Browse Repository
Passed
No Audits
4257b26abc61 Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the…
Author
epriestley
Revisions
D21271: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue
Browse Repository
Passed
No Audits
43a8d8763df3 Update out-of-date API calls when rendering diffs inline in email
Author
epriestley
Revisions
D21270: Update out-of-date API calls when rendering diffs inline in email
Browse Repository
Passed
No Audits
86d6abe9db26 Fix an issue where builds with no initiator failed to render in build plans
Author
epriestley
Revisions
D21269: Fix an issue where builds with no initiator failed to render in build plans
Browse Repository
Passed
No Audits
770a5c8412d1 Fix "r" and "R" both replying with quote on inline comments
Author
epriestley
Revisions
D21268: Fix "r" and "R" both replying with quote on inline comments
Browse Repository
Passed
No Audits
6cf017d68003 Fix an unusual issue with intradiff highlighting of files with uncommon end-of…
Author
epriestley
Revisions
D21267: Fix an unusual issue with intradiff highlighting of files with uncommon end-of-file modifications
Browse Repository
Passed
No Audits
0c51885cf7b2 Survive importing Git commits with no commit message and/or no author
Author
epriestley
Revisions
D21266: Survive importing Git commits with no commit message and/or no author
Browse Repository
Passed
No Audits
f86d822a37ea Update MySQL schema inspection code for deprecation of integer display widths
Author
epriestley
Revisions
D21265: Update MySQL schema inspection code for deprecation of integer display widths
Browse Repository
Passed
No Audits
7b0db3eb54b9 Fix an email address validation UI feedback issue when creating new users
Author
epriestley
Revisions
D21264: Fix an email address validation UI feedback issue when creating new users
Browse Repository
Passed
No Audits
93b08f0e83e6 Fix an out-of-order access issue with inlines
Author
epriestley
Revisions
D21263: Fix an out-of-order access issue with inlines
Browse Repository
Passed
No Audits

Changes (40)

Path

Size

externals/

phpmailer/

class.phpmailer.php

resources/

celerity/

map.php

packages.php

sql/

autopatches/

20200520.inline.01.remcache.sql

20200520.inline.02.addcache.sql

20200520.inline.03.dropcommit.sql

src/

__phutil_library_map__.php

applications/

audit/

storage/

PhabricatorAuditTransactionComment.php

config/

schema/

PhabricatorConfigColumnSchema.php

differential/

controller/

DifferentialChangesetViewController.php

editor/

DifferentialRevisionEditEngine.php

engine/

DifferentialRevisionDraftEngine.php

parser/

DifferentialChangesetParser.php

query/

DifferentialDiffInlineCommentQuery.php

render/

DifferentialChangesetOneUpRenderer.php

storage/

DifferentialSchemaSpec.php

DifferentialTransactionComment.php

view/

DifferentialChangesetDetailView.php

DifferentialChangesetListView.php

diffusion/

engine/

DiffusionCommitDraftEngine.php

protocol/

DiffusionCommandEngine.php

query/

DiffusionDiffInlineCommentQuery.php

people/

controller/

PhabricatorPeopleNewController.php

infrastructure/

diff/

PhabricatorInlineCommentController.php

inline

PhabricatorDiffInlineCommentContentState.php

PhabricatorDiffInlineCommentContext.php

PhabricatorInlineCommentContentState.php

PhabricatorInlineCommentContext.php

interface/

PhabricatorInlineComment.php

query/

PhabricatorDiffInlineCommentQuery.php

view/

PHUIDiffInlineCommentDetailView.php

PHUIDiffInlineCommentEditView.php

PHUIDiffInlineCommentView.php

webroot/

rsrc/

css/

application/

differential/

phui-inline-comment.css

js/

application/

diff/

DiffChangeset.js

DiffChangesetList.js

DiffInline.js

diffusion/

ExternalEditorLinkEngine.js

core/

behavior-line-linker.js

rP73024e454239

View Options

externals/phpmailer/class.phpmailer.php

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

resources/sql/autopatches/20200520.inline.01.remcache.sql

View Options

resources/sql/autopatches/20200520.inline.02.addcache.sql

View Options

resources/sql/autopatches/20200520.inline.03.dropcommit.sql

View Options

src/__phutil_library_map__.php

View Options

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

View Options

src/applications/config/schema/PhabricatorConfigColumnSchema.php

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

View Options

src/applications/differential/engine/DifferentialRevisionDraftEngine.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/query/DifferentialDiffInlineCommentQuery.php

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

View Options

src/applications/differential/storage/DifferentialSchemaSpec.php

View Options

src/applications/differential/storage/DifferentialTransactionComment.php

View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

View Options

src/applications/differential/view/DifferentialChangesetListView.php

View Options

src/applications/diffusion/engine/DiffusionCommitDraftEngine.php

View Options

src/applications/diffusion/protocol/DiffusionCommandEngine.php

View Options

src/applications/diffusion/query/DiffusionDiffInlineCommentQuery.php

View Options

src/applications/people/controller/PhabricatorPeopleNewController.php

View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

View Options

src/infrastructure/diff/inline/PhabricatorDiffInlineCommentContentState.php

View Options

src/infrastructure/diff/inline/PhabricatorDiffInlineCommentContext.php

View Options

src/infrastructure/diff/inline/PhabricatorInlineCommentContentState.php

View Options

src/infrastructure/diff/inline/PhabricatorInlineCommentContext.php

View Options

src/infrastructure/diff/interface/PhabricatorInlineComment.php

View Options

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

View Options

webroot/rsrc/js/application/diff/DiffInline.js

View Options

webroot/rsrc/js/application/diffusion/ExternalEditorLinkEngine.js

View Options

webroot/rsrc/js/core/behavior-line-linker.js

(stable) Promote 2020 Week 20Audit Required73024e454239Actions

Description

Details

Event Timeline

Merged Changes

Changes (40)

rP73024e454239

externals/phpmailer/class.phpmailer.php

resources/celerity/map.php

resources/celerity/packages.php

resources/sql/autopatches/20200520.inline.01.remcache.sql

resources/sql/autopatches/20200520.inline.02.addcache.sql

resources/sql/autopatches/20200520.inline.03.dropcommit.sql

src/__phutil_library_map__.php

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

src/applications/config/schema/PhabricatorConfigColumnSchema.php

src/applications/differential/controller/DifferentialChangesetViewController.php

src/applications/differential/editor/DifferentialRevisionEditEngine.php

src/applications/differential/engine/DifferentialRevisionDraftEngine.php

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/query/DifferentialDiffInlineCommentQuery.php

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

src/applications/differential/storage/DifferentialSchemaSpec.php

src/applications/differential/storage/DifferentialTransactionComment.php

src/applications/differential/view/DifferentialChangesetDetailView.php

src/applications/differential/view/DifferentialChangesetListView.php

src/applications/diffusion/engine/DiffusionCommitDraftEngine.php

src/applications/diffusion/protocol/DiffusionCommandEngine.php

src/applications/diffusion/query/DiffusionDiffInlineCommentQuery.php

src/applications/people/controller/PhabricatorPeopleNewController.php

src/infrastructure/diff/PhabricatorInlineCommentController.php

src/infrastructure/diff/inline/PhabricatorDiffInlineCommentContentState.php

src/infrastructure/diff/inline/PhabricatorDiffInlineCommentContext.php

src/infrastructure/diff/inline/PhabricatorInlineCommentContentState.php

src/infrastructure/diff/inline/PhabricatorInlineCommentContext.php

src/infrastructure/diff/interface/PhabricatorInlineComment.php

src/infrastructure/diff/query/PhabricatorDiffInlineCommentQuery.php

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

webroot/rsrc/css/application/differential/phui-inline-comment.css

webroot/rsrc/js/application/diff/DiffChangeset.js

webroot/rsrc/js/application/diff/DiffChangesetList.js

webroot/rsrc/js/application/diff/DiffInline.js

webroot/rsrc/js/application/diffusion/ExternalEditorLinkEngine.js

webroot/rsrc/js/core/behavior-line-linker.js

(stable) Promote 2020 Week 20
Audit Required73024e454239
Actions