Page MenuHomePhabricator

Fix two rendering issues with Jupyter notebooks
ClosedPublic

Authored by epriestley on May 22 2020, 6:51 PM.

Details

Summary

See PHI1752.

  • Early exit of document layout can cause us to fail to populate available rows.
  • Some Jupyter documents have "markdown" cells with plain strings, apparently.
Test Plan

Successfully rendered example diff from PHI1752.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2020, 6:52 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.