Page MenuHomePhabricator

Fix "r" and "R" both replying with quote on inline comments
ClosedPublic

Authored by epriestley on May 19 2020, 4:26 PM.

Details

Summary

Ref T13513. The code which added "r" and "R" to the inline menu accidentally discarded the difference between the keystrokes.

Test Plan
  • Clicked an inline, pressed "r", got new empty inline (previously: inline with quote).
  • Clicked an inline, pressed "R", got a new quoted inline.
  • Repeated steps with the menu items, got the expected behaviors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2020, 4:28 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.