Page MenuHomePhabricator
Feed All Stories

Jan 10 2017

epriestley added a comment to T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail.

I'm just going to merge this into T10448, this task doesn't have anything not already covered there.

Jan 10 2017, 4:56 PM · Restricted Project, Mail, Audit, Notifications
epriestley moved T6660: Unsubmitted comments icon for Audits from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:56 PM · Restricted Project, Audit
epriestley closed T2716: Consolidate "load commit from name" code, a subtask of T2714: Move Releeph to Beta, as Resolved.
Jan 10 2017, 4:56 PM · Releeph
epriestley closed T2716: Consolidate "load commit from name" code as Resolved.
  • DiffusionCommitQuery has had the "good" version for a while.
  • We're nuking Releeph at some point.
Jan 10 2017, 4:56 PM · Diffusion, Audit, Releeph
cspeckmim awarded T5722: Support meta-audit of arbitrary baskets of nonadjacent commits a Heartbreak token.
Jan 10 2017, 4:55 PM · Audit
tgotes1 added a comment to Q541: I have two different forms How to edit forms in corresponding template.

both forms are marked as edit..
but when edit a task of the bug form it opens the form of the standard task

Jan 10 2017, 4:55 PM
epriestley moved T2921: Audit status is none on commit views of Audit if no Auditors specifically assigned from Backlog to Audit States on the Audit board.
Jan 10 2017, 4:55 PM · Audit
epriestley moved T3917: Avoid or easily handle 'duplicate' audits from Backlog to Audit States on the Audit board.
Jan 10 2017, 4:55 PM · Restricted Project, Audit
epriestley moved T4026: Add relations between commits from Backlog to Audit States on the Audit board.
Jan 10 2017, 4:54 PM · Restricted Project, Audit
epriestley moved T6507: Audit inline comments doesn't account for synthetic authors from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:54 PM · Audit
epriestley moved T6810: Inline comments is only partially working in an imported SVN repo from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:53 PM · Audit
epriestley moved T11029: Colorized html inline diffs for Diffusion from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:51 PM · Diffusion (v3), Audit
epriestley moved T11118: Herald Rule to assign Owners to an Audit from Backlog to Future on the Audit board.
Jan 10 2017, 4:51 PM · Restricted Project, Audit, Herald, Owners, Feature Request
epriestley moved T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter." from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:50 PM · Audit, Bug Report
epriestley moved T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:44 PM · Audit, Diffusion, Wikimedia
epriestley moved T5815: Make it easier to work through a queue of stuff from Backlog to Far Future on the Audit board.
Jan 10 2017, 4:44 PM · Restricted Project, Maniphest, Differential, Audit
epriestley moved T5722: Support meta-audit of arbitrary baskets of nonadjacent commits from Backlog to Far Future on the Audit board.
Jan 10 2017, 4:43 PM · Audit
epriestley moved T3639: Don't eat unsaved inline comments from Backlog to Future on the Audit board.
Jan 10 2017, 4:43 PM · Audit
epriestley moved T2393: Adds a "Needs Verification" state to Audits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:43 PM · Restricted Project, Audit
epriestley moved T10446: Unable to simply mark a Diffusion comment as Done from EditEngine to Inlines on the Audit board.
Jan 10 2017, 4:42 PM · Audit, Bug Report
epriestley moved T8739: Inline comments not sorted from EditEngine to Inlines on the Audit board.
Jan 10 2017, 4:42 PM · Audit
epriestley moved T5889: Allow herald rules to act on existence of auditors from Backlog to Herald on the Audit board.
Jan 10 2017, 4:42 PM · Restricted Project, Audit, Herald
epriestley moved T5928: Clarify language around self-accepting Audits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:41 PM · Audit
epriestley moved T6024: Display (post-push) audit-state in Diffusion commit-list from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:41 PM · Restricted Project, Audit, Diffusion
epriestley moved T9544: way to search for commits with no audit status from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Restricted Project, Restricted Project, Audit
epriestley moved T8683: Ability to query audits where all auditors have replied from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Audit
epriestley moved T7676: Packages that are configured to auto-audit often generate audits that are un-closable from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Owners, Audit
epriestley moved T7504: Manually added auditors doesn't change commit audit status from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Audit
epriestley moved T8739: Inline comments not sorted from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Audit
epriestley moved T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:38 PM · Restricted Project, Typeahead, Audit
epriestley moved T9423: Timeout error when loading "All Audits" query from a user who should not have access to any commits/audits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:38 PM · Audit
epriestley moved T9430: "Needs Audit" no longer excludes author commits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:38 PM · Restricted Project, Restricted Project, Audit
epriestley moved T9482: Problems in the "Commits in this Package that Need Attention" view from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:38 PM · Restricted Project, Restricted Project, Audit
epriestley moved T10446: Unable to simply mark a Diffusion comment as Done from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:37 PM · Audit, Bug Report
epriestley moved T10978: Modernize Audit from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:37 PM · Audit
epriestley moved T11212: One of our audits is displaying comments from another audit from Backlog to Future on the Audit board.
Jan 10 2017, 4:36 PM · Quicksand, Audit, Bug Report
epriestley added a project to T11212: One of our audits is displaying comments from another audit: Quicksand.
Jan 10 2017, 4:36 PM · Quicksand, Audit, Bug Report
epriestley added projects to T12089: New red/green highlight colors are incorrect for added or removed new lines: Differential, Design.
Jan 10 2017, 4:08 PM · Design, Differential
epriestley merged T12088: Moving task cards on a project workboard sorted by priority is extremely slow into T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).
Jan 10 2017, 7:18 AM · Restricted Project, Workboards
epriestley merged task T12088: Moving task cards on a project workboard sorted by priority is extremely slow into T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).
Jan 10 2017, 7:18 AM · Bug Report (Needs Information), Restricted Project
epriestley added members for Community: neilfitz, jboning.
Jan 10 2017, 7:18 AM
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

T12089 has a narrower description with some screenshots, I think the behavior got flipped by accident.

Jan 10 2017, 7:12 AM · Accessibility, Design, Feature Request, Restricted Project
epriestley created T12089: New red/green highlight colors are incorrect for added or removed new lines.
Jan 10 2017, 7:09 AM · Design, Differential
jaie.wilson awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jan 10 2017, 5:58 AM · Workboards (v3), Restricted Project
edouard.kaiser awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Party Time token.
Jan 10 2017, 5:55 AM · Workboards (v3), Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

At least one user over email (and I think @epriestley also) mentioned the light highlighting of full lines is hard to distinguish / understand as full change in diffs. I'll look more into these issues before next release is cut.

Jan 10 2017, 4:55 AM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12088: Moving task cards on a project workboard sorted by priority is extremely slow.

59s is ridiculous. :(

Jan 10 2017, 4:01 AM · Bug Report (Needs Information), Restricted Project
chad updated subscribers of T12088: Moving task cards on a project workboard sorted by priority is extremely slow.

I think @jboning was working on moving Phabricator to new hardware last year, but I don't know where that ended up. Once that happens, we can get you clustered for performance.

Jan 10 2017, 4:01 AM · Bug Report (Needs Information), Restricted Project
neilfitz moved T12088: Moving task cards on a project workboard sorted by priority is extremely slow from Restricted Project Column to Restricted Project Column on the Restricted Project board.

You're right, works fine for me against a Phacility test instance. Huh.

Jan 10 2017, 4:00 AM · Bug Report (Needs Information), Restricted Project
chad added a comment to T12088: Moving task cards on a project workboard sorted by priority is extremely slow.

And also T7664.

Jan 10 2017, 3:51 AM · Bug Report (Needs Information), Restricted Project
chad added a comment to T12088: Moving task cards on a project workboard sorted by priority is extremely slow.

This sounds like T8588 offhand, unless you can reproduce against Phacility hardware.

Jan 10 2017, 3:50 AM · Bug Report (Needs Information), Restricted Project
chad edited projects for T12088: Moving task cards on a project workboard sorted by priority is extremely slow, added: Bug Report (Needs Information); removed Bug Report.
Jan 10 2017, 3:48 AM · Bug Report (Needs Information), Restricted Project
chad added a comment to T12088: Moving task cards on a project workboard sorted by priority is extremely slow.

We're going to need complete reproduction steps. Preferably against a Phacility test instance so we can rule out environmental causes.

Jan 10 2017, 3:47 AM · Bug Report (Needs Information), Restricted Project
neilfitz created T12088: Moving task cards on a project workboard sorted by priority is extremely slow.
Jan 10 2017, 3:31 AM · Bug Report (Needs Information), Restricted Project
epriestley added a revision to T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader: Unknown Object (Differential Revision).
Jan 10 2017, 1:41 AM · Restricted Project, Bug Report
epriestley added a comment to T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader.

The "Ambiguous Leaders" section in the docs should more or less cover this, and using bin/repository thaw to promote your favorite node to leadership is probably the easiest way to resolve it. This pathway to ambiguity is fairly mundane compared to what the documentation imagines, though, and both clusterize and that UI warning could point toward bin/repository thaw --promote. I'll make these more clear.

Jan 10 2017, 1:26 AM · Restricted Project, Bug Report
jboning renamed T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader from Clusterizing a repository onto a service with multiple machines results in non-working state to Clusterizing a repository onto a service with multiple machines results in ambiguous leader.
Jan 10 2017, 12:51 AM · Restricted Project, Bug Report
jboning created T12087: Clusterizing a repository onto a service with multiple machines results in ambiguous leader.
Jan 10 2017, 12:51 AM · Restricted Project, Bug Report

Jan 9 2017

neilfitz moved T12060: Colorblind accessibility for red/green highlighting in e-mails from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 9 2017, 11:55 PM · Accessibility, Design, Feature Request, Restricted Project
gregprice added a project to T12033: Large diffs can still repeatedly fail to insert: Restricted Project.
Jan 9 2017, 11:33 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
aurelijus added a comment to T12081: "Unable to establish a connection to any database host" via ssh git push.

First thing to check is if your DB configs are in /conf/local/local.json, I went through the same issue, because my mysql configs where in /conf/custom/myconfig.php and for some reason newer versions of phabricator do not evaluate PHABRICATOR_ENV properly. So basically run

Jan 9 2017, 10:51 PM · Bug Report (Needs Information)
epriestley moved T4631: Allow Differential to raise warnings on the server side via Conduit from v3 (Infrastructure) to Reviewer Rules on the Differential board.
Jan 9 2017, 10:11 PM · Restricted Project, Arcanist, Differential
epriestley moved T5786: Separate Differential reviewer warnings from the reviewers field from v2 (UI/Mobile) to Reviewer Rules on the Differential board.
Jan 9 2017, 10:11 PM · Custom Fields, Differential
epriestley closed T12086: Differential keyboard shortcuts for navigating diffs disappeared in the last update as Resolved by committing Restricted Diffusion Commit.
Jan 9 2017, 8:57 PM · Differential, Bug Report
epriestley added a comment to T12086: Differential keyboard shortcuts for navigating diffs disappeared in the last update.

Thanks, not intentional.

Jan 9 2017, 8:56 PM · Differential, Bug Report
epriestley added a revision to T12086: Differential keyboard shortcuts for navigating diffs disappeared in the last update: Unknown Object (Differential Revision).
Jan 9 2017, 8:56 PM · Differential, Bug Report
chris.siden created T12086: Differential keyboard shortcuts for navigating diffs disappeared in the last update.
Jan 9 2017, 8:50 PM · Differential, Bug Report
epriestley closed T10968: File write failure during daemon operations caused daemons to populate a few too many diffs as Resolved by committing Restricted Diffusion Commit.
Jan 9 2017, 8:13 PM · Files, Differential, Diffusion, Daemons
epriestley added a revision to T10968: File write failure during daemon operations caused daemons to populate a few too many diffs: Unknown Object (Differential Revision).
Jan 9 2017, 7:45 PM · Files, Differential, Diffusion, Daemons
epriestley closed T12052: Dependent revision stack UI showing endpoints incorrectly as Invalid.

I can't reproduce this either. Here's:

Jan 9 2017, 6:47 PM · Bug Report (Needs Information)
epriestley added a comment to T12081: "Unable to establish a connection to any database host" via ssh git push.

Alright. If we don't hear back from you in a few days we'll close this since we can't move forward on it, but you're free to file a new task when you're ready to move forward.

Jan 9 2017, 6:38 PM · Bug Report (Needs Information)
zcourts added a comment to T12081: "Unable to establish a connection to any database host" via ssh git push.

I'm using a VPS but don't have the facility to easily clone it as is and can't risk it being broken anymore than is now. I will get a small instance setup which reproduces the problem (using ansible to roll out so should be straightforward), that probably won't be until in the week, right now I'm working around it by mirroring and pushing to another remote temporarily.

Jan 9 2017, 6:27 PM · Bug Report (Needs Information)
epriestley moved T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages from Backlog to v3 (Infrastructure) on the Differential board.
Jan 9 2017, 6:12 PM · Installing & Upgrading, Differential
epriestley closed T10638: A Task can end up on a Milestone workboard column without being in that Milestone as Resolved.

I can't reproduce this, and I suspect it was fixed some time ago during changes related to T6027.

Jan 9 2017, 6:10 PM · Projects (v3), Bug Report
epriestley added a comment to T12074: conduit API extensions for subprojects and milestones..

Oh, one final note:

Jan 9 2017, 5:41 PM · Feature Request
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

I've collected some guidance more formally in T12085.

Jan 9 2017, 5:32 PM · Bug Report
epriestley created T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages.
Jan 9 2017, 5:32 PM · Installing & Upgrading, Differential
joshma added a comment to T9186: CloudFront configuration is more involved than the documentation implies.

FWIW this affected us as well, we switched from cloudflare back to cloudfront and hit this snag. The default settings do not forward Host header, we had to add that ourselves. Didn't need to change anything else, though - it seems that cloudfront performs loose SSL validation and is OK with the certificate/host mismatch. (Maybe it at least requires the host to match the origin domain - not sure.)

Jan 9 2017, 5:11 PM · Setup
epriestley closed T12074: conduit API extensions for subprojects and milestones. as Resolved.

I've also made these additional changes, not directly related to the original request:

Jan 9 2017, 4:54 PM · Feature Request
epriestley closed T12082: Differential emails are rendering literal HTML tags as Resolved by committing Restricted Diffusion Commit.
Jan 9 2017, 4:42 PM · Differential, Bug Report
epriestley added a comment to T12084: `differential.updaterevision` conduit method no longer updates custom fields.

I think this is mostly guidance I neglected to issue, sorry about that.

Jan 9 2017, 4:40 PM · Bug Report
jcox created T12084: `differential.updaterevision` conduit method no longer updates custom fields.
Jan 9 2017, 4:22 PM · Bug Report
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 9 2017, 4:21 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to T12082: Differential emails are rendering literal HTML tags.

Thanks! D17162 should clean this up.

Jan 9 2017, 4:21 PM · Differential, Bug Report
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Jan 9 2017, 4:20 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T12082: Differential emails are rendering literal HTML tags: Unknown Object (Differential Revision).
Jan 9 2017, 4:19 PM · Differential, Bug Report
epriestley added a revision to T12074: conduit API extensions for subprojects and milestones.: Unknown Object (Differential Revision).
Jan 9 2017, 3:40 PM · Feature Request
epriestley added a comment to T12074: conduit API extensions for subprojects and milestones..

These changes are now available in HEAD of master, and should be available on stable after Jan 13. master is also safe to upgrade into right now, although some T11114 stuff may churn later this week.

Jan 9 2017, 3:35 PM · Feature Request
epriestley merged T10382: Transaction abort when pushing via SSH to a Mercurial repository into T9548: Support Mercurial's bundle2 wire protocol.
Jan 9 2017, 3:14 PM · Diffusion, Mercurial
epriestley merged task T10382: Transaction abort when pushing via SSH to a Mercurial repository into T9548: Support Mercurial's bundle2 wire protocol.
Jan 9 2017, 3:14 PM · Mercurial, Bug Report
epriestley added a comment to T10382: Transaction abort when pushing via SSH to a Mercurial repository.

All evidence points to this and T9548 being the same task, right? I'm just going to merge them.

Jan 9 2017, 3:14 PM · Mercurial, Bug Report
epriestley closed T12083: Can't set Related Task/Commit as Resolved.
Jan 9 2017, 3:04 PM · Bug Report (Needs Information)
jeremy.norris added a comment to T10382: Transaction abort when pushing via SSH to a Mercurial repository.

I believe there's more to it than just the bundle2 setting that causes it to not work. It still breaks for me even with devel.legacy.exchange=bundle1:

Jan 9 2017, 3:00 PM · Mercurial, Bug Report
OCram updated the question details for Q548: How to maintain uploaded files?.
Jan 9 2017, 2:18 PM · Files
OCram updated Q548: How to maintain uploaded files? from to How to maintain uploaded files?.
Jan 9 2017, 2:18 PM · Files
marvin.xf added a comment to T12083: Can't set Related Task/Commit.

I have restarted httpd. I try to disable some chrome extension. Now it works.

Jan 9 2017, 12:32 PM · Bug Report (Needs Information)
OCram edited the content of Community Resources.
Jan 9 2017, 10:46 AM
ralph.van.etten updated Q547: Stop tracking time for user who left. from to Stop tracking time for user who left..
Jan 9 2017, 9:03 AM · Phrequent
otto.bretz added a comment to T5523: Make bulk moves easier on Workboards.

Move all cards in this column to <another column>

That would be very useful for us as well.

Jan 9 2017, 8:06 AM · Restricted Project, Workboards
chad added a comment to T12083: Can't set Related Task/Commit.

I also can't reproduce this locally or on a Phacility test instance.

Jan 9 2017, 6:41 AM · Bug Report (Needs Information)