Page MenuHomePhabricator

Display (post-push) audit-state in Diffusion commit-list
Closed, ResolvedPublic

Description

Right now the Diffusion commit history shows the columns

Commit Revision Author/Committer Details Date Time

It doesn't, however, seem to have any indication of its audit status. For that I have to open the commit.

Would it be possible (if it's sensible at all) to display somehow each commits audit state, for instance by simply reusing the circled symbols used to denote audit concerns/accepts/needing?

Event Timeline

hvr raised the priority of this task from to Needs Triage.
hvr updated the task description. (Show Details)
hvr added projects: Diffusion, Audit.
hvr added a subscriber: hvr.

Right now I'm not sure there's any distinction between audits triggered by global rules, and audits triggered by personal rules. That means if anyone sets up a personal Herald rule to trigger an audit, it will cause Diffusion to only show "Partially Audited" (if that person doesn't respond). This is the case on this Phabricator install, where every commit without a review is affected by a personal rule that someone has set up.

So before this is possible, I think there needs to be a distinction between audits triggered by personal rules and those triggered by global rules (in the same way that there's a distinction between manual buildables and automatic buildables in Harbormaster). That way the audit status of a commit can be determined by the global audits, and not be impacted by personal rules.

I think *this* Phabricator install has the most junk in it of any install on the planet. Easily top 10 if not #1... :D

In that sense, I don't think the average "personal" rule isn't important in the audit case. At least to me, when creating Herald rules the "personal" vs "global" distinction is such that I would make almost exclusively "personal" rules, even if I was the Czar or everything.

Maybe I don't get personal rules though, and how they differ from global.

We might already be doing this, but we could make the state viewer-dependent. Instead of "Audited" vs "Partially Audited" vs "Audit Required", we could show "Audited", "Audit Required by Others" and "Audit Required by You" (with shorter names, maybe). For your commits, this would need to be a bit different.

Or maybe we need two columns: one for state, and one for "do you need to do anything?". I think they serve slightly different use cases.

eadler added a project: Restricted Project.Mar 8 2016, 8:18 AM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 8 2016, 8:29 AM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:18 PM