Page MenuHomePhabricator

Don't eat unsaved inline comments
Closed, ResolvedPublic


Commenting on a diff should prompt if unsaved inline comments could be lost via submission.

Event Timeline

staticshock added a project: Audit.
staticshock added subscribers: staticshock, epriestley.
handerpeder raised the priority of this task from Normal to Needs Triage.Jan 13 2014, 1:45 PM
handerpeder triaged this task as Normal priority.
epriestley changed the visibility from "All Users" to "Public (No Login Required)".Jan 30 2014, 11:39 PM

This isn't a duplicate of T3669. This discusses the case where you've begun typing a comment, but have not hit "Ready" yet, so the page still has an editable text area on it.

T3669 discusses a case slightly later, where you've hit "Ready" and turned the text into a draft, but haven't hit "Submit" to actually publish the comment.

The remedies for these issues may be substantially different. Notably, this case is probably resolved cleanly with an onbeforeunload handler, even in Firefox.

@epriestley, in general, the problems are similar functionally for end users.
But I agree that, technically, there is a difference.