Page MenuHomePhabricator

New red/green highlight colors are incorrect for added or removed new lines
Closed, ResolvedPublic


Current highlighting at HEAD:

Screen Shot 2017-01-09 at 11.06.27 PM.png (1×2 px, 475 KB)

Highlighting of the same change at rPc2f9e7f6e, before D17138:

Screen Shot 2017-01-09 at 11.07.03 PM.png (1×2 px, 448 KB)

The old highlighting, which made the completely new lines dark, was correct. The new highlighting is incorrect. Specifically, lines 144-162 should use the dark highlight color because they contain new text.

Revisions and Commits