Page MenuHomePhabricator
Create Task
Maniphest T7676

Packages that are configured to auto-audit often generate audits that are un-closable
Closed, ResolvedPublic
Actions

Description

Here's the setup:

  1. Create a package in Owners and make yourself the only owner.
  2. Create a revision that touches some files in the package. Have someone else review it, make some comments and accept the revision.
  3. Make some changes to the diff (for example to address small nitpicks from the review) and submit the change.

An Audit will be created because "Changed After Revision Was Accepted", which is expected. But one of the auditors will be the package itself and I cannot audit on behalf of that package, since I am the author, so the audit is stuck in a permanent "requires audit" state.

Revisions and Commits

rP Phabricator
D17181rP255e3fb1e4bf Allow auditors to be added and removed from commits in a modern way

Related Objects

Event Timeline

anton.vladimirov created this task.Mar 27 2015, 6:07 PM
anton.vladimirov raised the priority of this task from to Needs Triage.
anton.vladimirov updated the task description. (Show Details)
anton.vladimirov added a subscriber: anton.vladimirov.

Other than bin/audit delete, is there any other way for clearing this (preferably automatic)?

chad added a subscriber: chad.Mar 27 2015, 6:12 PM

You can set audit.can-author-close-audit to true

anton.vladimirov added a comment.Mar 27 2015, 7:27 PM

That doesn't seem to do it. I still get "Partially Audited".

Screen_Shot_2015-03-27_at_12.26.19_PM.png (138×464 px, 34 KB)

anton.vladimirov added a comment.Mar 27 2015, 7:28 PM

In the image above, I (anton) am the owner of both "Viewing Pane" and "Header Display" packages.

chad added projects: Audit, Owners.Mar 28 2015, 2:19 PM
tiguchi added a subscriber: tiguchi.Jul 18 2015, 3:22 AM
kaloisi added a subscriber: kaloisi.Oct 13 2015, 2:34 PM

I'm seeing this same problem if a single user is a member of two projects. That user can only accept the audit for one of the projects leaving it in this state.

For instance, if user Kevin is in project A and B and a checkin single check-in occurs with changes for both projects, then the revision requires two audits but when Kevin accepts the audit, it only accepts it for one of the projects. To further complicate this issue, if Kevin is the only member of project B when the there is no way to accept the audit.

epriestley mentioned this in T9946: Not adding archived owner packages as auditors on audits.Dec 10 2015, 1:30 PM
• joakim.plate added a subscriber: • joakim.plate.Jan 13 2016, 8:02 AM

I'm seeing the same thing:

pasted_file (277×544 px, 30 KB)

The project ends up as being a reviewer and the audit is just partially accepted.

• joakim.plate added a comment.Jan 13 2016, 11:36 AM

Is this possibly related to T1275?

cmmata mentioned this in Q287: How to accept an audit with a project as reviewer?.Mar 18 2016, 10:53 AM
cmmata added a subscriber: cmmata.

It has been asked in Q287 too.

cburroughs added a subscriber: cburroughs.Mar 18 2016, 12:19 PM
epriestley merged a task: T6701: Audit issue with single person group.May 17 2016, 2:22 PM
epriestley added subscribers: eadler, klachance.
epriestley mentioned this in T10978: Modernize Audit.May 17 2016, 2:34 PM
klachance added a comment.May 17 2016, 2:37 PM

right now, out workaround is to use herald to create the audio, and use "author is not any of " the single person group. a better explaination of the situation was written in my T6701.

epriestley added a subscriber: epriestley.May 17 2016, 2:41 PM

When we can identify the author, I'm just going to make auditing stop trigger audits by any packages they own, even if there was no review.

mahmost added a subscriber: mahmost.May 30 2016, 2:53 AM
eadler added a comment.Aug 7 2016, 8:02 PM

FWIW this exact set of reproduction steps no longer works. However, an Owners package set to generate an audit, but without any members, will be unclosable as well.

chad merged a task: T11970: Add ability to remove auditors from commit.Dec 8 2016, 8:37 PM
chad added a subscriber: vladimirv.
joshuaspence added a subscriber: joshuaspence.Jan 2 2017, 10:15 AM
epriestley moved this task from Backlog to EditEngine on the Audit board.Jan 10 2017, 4:39 PM
epriestley moved this task from EditEngine to Audit States on the Audit board.Jan 10 2017, 5:07 PM
epriestley added a revision: D17181: Allow auditors to be added and removed from commits in a modern way.Jan 11 2017, 7:23 PM
epriestley closed this task as Resolved.Jan 11 2017, 7:29 PM
epriestley claimed this task.

I'm just going to presume this is resolved, in some sense, by D17181, because you can now remove auditors regardless of other outcomes.

This report is fairly old and seems to describe several different behaviors, some of which probably no longer exist (or may not exist shortly, after changes in T10978). Some of them (like an Owners package which triggers audits but has no owners) are probably already correct.

If there are remaining issues: wait for T10978 to settle down (circa the next promotion to stable, around Jan 20th?) and then file new reports with specific reproduction steps and we can deal with situations one-by-one. After D17181, simply removing auditors should get you out of any situation even if our other behaviors can be improved.

epriestley added a commit: rP255e3fb1e4bf: Allow auditors to be added and removed from commits in a modern way.Jan 11 2017, 9:56 PM
Phabricator · Built by Phacility