Page MenuHomePhabricator

Consolidate "load commit from name" code
Closed, ResolvedPublic

Description

Releeph introduces more partial-commit-identifier loading code, in ReleephCommitFinder. We should consolidate all the copies of this code:

  • One copy in ConduitAPI_diffusion_getcommits_Method.
  • One copy in DiffusionCommitQuery.
  • Part of one copy in PhabricatorAuditCommitQuery.
  • One copy in PhabricatorPHID::fromObjectName().
  • A new copy in ReleephCommitFinder.

Of these, DiffusionCommitQuery is the most modern (includes policy awareness and handles all the nasty edge cases).

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision

Event Timeline

epriestley triaged this task as Normal priority.Mar 9 2013, 9:21 AM
epriestley added projects: Diffusion, Audit, Releeph.
epriestley added subscribers: epriestley, edward.
epriestley added a subscriber: Unknown Object (MLST).Sep 3 2013, 11:15 PM
epriestley edited this Maniphest Task.
chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 3 2015, 3:58 AM
epriestley claimed this task.
  • DiffusionCommitQuery has had the "good" version for a while.
  • We're nuking Releeph at some point.