Page MenuHomePhabricator
Create Task
Maniphest T10446

Unable to simply mark a Diffusion comment as Done
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
joshkel
Feb 24 2016, 4:11 PM
Tags
Referenced Files
F1128036: Screen Shot 2016-02-24 at 8.18.44 AM.png
Feb 24 2016, 4:22 PM
F1128034: Screen Shot 2016-02-24 at 8.18.41 AM.png
Feb 24 2016, 4:22 PM
F1128043: Screen Shot 2016-02-24 at 8.21.30 AM.png
Feb 24 2016, 4:22 PM
F1128040: Screen Shot 2016-02-24 at 8.18.53 AM.png
Feb 24 2016, 4:22 PM
F1128038: Screen Shot 2016-02-24 at 8.18.47 AM.png
Feb 24 2016, 4:22 PM
Subscribers
cburroughs
epriestley
joshkel
joshuaspence

Description

In Diffusion, if someone raised a concern on one of my commits and made a comment on a section of code:

  • I can click the "Done" checkbox by the comment to mark it as done.
  • This adds a note that my change is "Unsubmitted." This seems reasonable, and it makes me think I should click Submit at the bottom of the page.
  • If I click Submit at the bottom of the page, the page is submitted, and the server acts like it's doing something, but my marking the comment as Done still shows as unsubmitted.

Apparently I have to actually enter text in the Comment section at the bottom of the page for my change to be processed. If I don't have anything to say, it would be nice to simply click a few Done checkboxes, click Submit, and be done.

Revisions and Commits

rP Phabricator
D17183rPb5722a99635a Use EditEngine stacked comments in Diffusion

Related Objects

Event Timeline

joshkel created this task.Feb 24 2016, 4:11 PM
cburroughs added a subscriber: cburroughs.Feb 24 2016, 4:18 PM
epriestley added a subscriber: epriestley.Feb 24 2016, 4:22 PM

I'm having trouble reproducing this -- I attempted to follow your steps, but didn't experience the issue. Here's what I did:

First, I loaded a revision that I had authored which another user had added an inline comment to:

Screen Shot 2016-02-24 at 8.18.41 AM.png (1×1 px, 137 KB)

Next, I clicked "Done":

Screen Shot 2016-02-24 at 8.18.44 AM.png (1×1 px, 140 KB)

Then, I clicked "Submit":

Screen Shot 2016-02-24 at 8.18.47 AM.png (1×1 px, 138 KB)

Finally, I confirmed that I didn't want to post any comments. The page reloaded, showing the inline now marked "Done":

Screen Shot 2016-02-24 at 8.18.53 AM.png (1×1 px, 145 KB)

Additionally, a transaction populated in the transaction log recording my change:

Screen Shot 2016-02-24 at 8.21.30 AM.png (122×2 px, 23 KB)

What can I do differently to reproduce this issue?

joshkel added a comment.Feb 24 2016, 4:57 PM

Your steps match mine. However, I'm not getting an "Action With No Effect" prompt; instead, the server acts like it's processing, and redisplays the page, but doesn't actually make any changes.

We're using Audit -> Diffusion (i.e., post-commit reviews). I just tested with a review through Differential, and I get the Action With No Effect prompt and can successfully mark as Done, as in your steps.

epriestley added a comment.Feb 24 2016, 4:58 PM

Ah, I missed "In Diffusion". Let me see if I can reproduce there.

cspeckmim mentioned this in Z1336: General Chat.Feb 24 2016, 10:59 PM
avivey renamed this task from Unable to simply mark a code review comment as Done to Unable to simply mark a Diffusion comment as Done.Feb 28 2016, 7:47 PM
avivey added a project: Audit.
joshuaspence added a subscriber: joshuaspence.Feb 29 2016, 8:38 AM
epriestley moved this task from Backlog to EditEngine on the Audit board.Jan 10 2017, 4:37 PM
epriestley moved this task from EditEngine to Inlines on the Audit board.Jan 10 2017, 4:42 PM
epriestley added a revision: D17183: Use EditEngine stacked comments in Diffusion.Jan 11 2017, 10:27 PM
epriestley added a comment.Jan 11 2017, 10:46 PM

I believe D17183 fixes this. If you're still seeing issues after upgrading past that change, file a new issue with modern reproduction instructions.

epriestley closed this task as Resolved by committing rPb5722a99635a: Use EditEngine stacked comments in Diffusion.Jan 11 2017, 10:46 PM
epriestley added a commit: rPb5722a99635a: Use EditEngine stacked comments in Diffusion.
Phabricator · Built by Phacility