Page MenuHomePhabricator

Modernize Audit
Closed, ResolvedPublic

Assigned To
Authored By
epriestley
May 17 2016, 2:34 PM
Referenced Files
None
Tokens
"Like" token, awarded by aik099."Like" token, awarded by nornagon."Like" token, awarded by monsdar.

Description

Long ago, Audit was copy/pasted from Differential and then essentially never changed again.

Audit generally suffers from being un-modern and playing second fiddle to Differential.

Workflow

  • When an author has addressed concerns, there is no way for them to punt the audit back into the auditors' queues (T2393). Generally, this workflow is currently a dead end.
  • The UI offers "Accept Commit" even if it's meaningless and not permissible (T5928). Maybe a broader workflow issue.
  • Users should be able to add and remove auditors (T7676), like they can add and remove reviewers in Differential.
  • T7504 reports a bug with manually added auditors and overall audit status.

Herald

  • T5889 wants an "Auditors" Herald field, similar to the Differential "Reviewers" field.

Search and Status

  • Search should have bucketing, like Differential (T9430). Generally, the UI should be aligned with the modern Differential UI.
  • Search should support a modern status selector (T9544).
    • Possibly, "Audits Resolved" should be different from "No Audits Triggered" (T8683).
  • T6024 wants audit status shown in Diffusion commit lists, similar to how build status is shown.
    • Status behavior elsewhere is likely ripe for resolution now (T9482).
    • T2921 reports a bug with this but is extremely old.
  • T6660 is a request for a draft icon in the list view, like the one in Differential.

Infrastructure

  • This stuff should all work via EditEngine.
  • Audit requests store untranslatable descriptive text in the database, but should store translatable reason codes.
  • Good news: we never moved audit requests to edges, so we don't have to resolve an analog of T10967.

See also T10685, T9091, T4713, which overlap or cover multiple issues and which I've merged here.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley added a revision: Restricted Differential Revision.Jan 11 2017, 4:48 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 11 2017, 5:34 PM
epriestley added a revision: Restricted Differential Revision.Jan 11 2017, 5:40 PM
epriestley added a revision: Restricted Differential Revision.Jan 11 2017, 5:44 PM
epriestley added a revision: Restricted Differential Revision.Jan 11 2017, 5:50 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 11 2017, 6:31 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 11 2017, 6:37 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Jan 11 2017, 7:23 PM
epriestley added a revision: Restricted Differential Revision.Jan 11 2017, 8:19 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 11 2017, 9:56 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Jan 11 2017, 10:27 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 11 2017, 10:46 PM
epriestley added a revision: Restricted Differential Revision.Jan 11 2017, 11:27 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 12 2017, 12:29 AM
epriestley added a revision: Restricted Differential Revision.Jan 12 2017, 3:30 PM
epriestley added a revision: Restricted Differential Revision.Jan 12 2017, 3:47 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 12 2017, 7:44 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Jan 12 2017, 8:52 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 12 2017, 9:23 PM
epriestley added a revision: Restricted Differential Revision.Jan 18 2017, 8:04 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 18 2017, 9:15 PM
epriestley added a revision: Restricted Differential Revision.Jan 26 2017, 3:17 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 26 2017, 6:15 PM
epriestley added a revision: Restricted Differential Revision.Jan 26 2017, 6:27 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 26 2017, 8:57 PM
epriestley added a revision: Restricted Differential Revision.Jan 27 2017, 7:06 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 27 2017, 7:10 PM
epriestley added a revision: Restricted Differential Revision.Jan 30 2017, 5:53 PM
epriestley added a revision: Restricted Differential Revision.Jan 30 2017, 6:02 PM
epriestley added a revision: Restricted Differential Revision.Jan 30 2017, 7:41 PM
epriestley added a revision: Restricted Differential Revision.Jan 30 2017, 8:22 PM
epriestley added a revision: Restricted Differential Revision.Jan 30 2017, 9:08 PM
epriestley added a revision: Restricted Differential Revision.Jan 30 2017, 11:17 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 30 2017, 11:23 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Jan 30 2017, 11:26 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Jan 31 2017, 5:07 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 31 2017, 5:19 PM
epriestley added a revision: Restricted Differential Revision.Jan 31 2017, 8:04 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 31 2017, 8:23 PM
epriestley added a revision: Restricted Differential Revision.Jan 31 2017, 9:19 PM
epriestley added a commit: Restricted Diffusion Commit.Jan 31 2017, 9:37 PM
epriestley claimed this task.

I think I've pushed this approximately as far as I plan to in this iteration. Everything mentioned in the description has been tackled, and audits on this install are now in a relatively sane state.

The workflow has changed a little and I'm sure there are some remaining rough edges; feel free to file followups as you run into them.

I plan to continue broader work on Diffusion as described in T12010.