Page MenuHomePhabricator

gregprice (Gregory Price)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 22 2011, 10:09 PM (390 w, 6 d)
Availability
Available

Recent Activity

May 9 2017

gregprice added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Staring a bit more at the data I just posted, it occurs to me that it seems kind of sluggish for an UPDATE like those -- one row, indexed by what I assume is the PRIMARY KEY -- to take 1-4ms or so, as these are. There's probably a DB (or network-to-DB?) performance issue there that we'd benefit broadly from addressing.

May 9 2017, 2:38 AM · Unknown Object (Project), Workboards
gregprice added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

We're still seeing this issue pretty severely, on our shiny upgraded 2017 Week 17 version on our shiny new Phabricator host. So I took a look just now with DarkConsole.

May 9 2017, 2:30 AM · Unknown Object (Project), Workboards
gregprice changed the status of T8588: One instance has a severe, global performance issue from Wontfix to Resolved.

This issue is in fact actually fixed 🎊 ! Most recently, moving to a new host with a newer PHP (and everything else, running Ubuntu 16.04 rather than 12.04) made a big difference; we've also made a lot of improvements to our Phabricator setup over the past year or so, some of which likely helped too.

May 9 2017, 2:14 AM · Unknown Object (Project)
gregprice changed the status of T8588: One instance has a severe, global performance issue, a subtask of T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error), from Wontfix to Resolved.
May 9 2017, 2:14 AM · Unknown Object (Project), Workboards
gregprice changed the status of T8588: One instance has a severe, global performance issue, a subtask of T8444: Increase typeahead speed, from Wontfix to Resolved.
May 9 2017, 2:14 AM · Typeahead, PHUI, Unknown Object (Project)

Apr 18 2017

gregprice added a comment to T10640: Allow application queries to be promoted as global search modes.

Just in my personal experience, I think it was sometime in the last 6 months that I realized Phabricator has a concept of "application search" and "global search", and that a lot of the searches I'd been doing were the latter and that's why they were so limited in functionality. I'd been using Phabricator for years and always had the sense that search didn't work very well, and that there were different forms I might get for it with different sets of fields, and it was unpredictable which one I'd get; but it wasn't until I became responsible for actually running Phabricator and started paying much closer attention to its concepts that I twigged to that pattern as the explanation for which searches got which form.

Apr 18 2017, 12:33 AM · Search, Feature Request

Apr 4 2017

gregprice added a project to T12505: Ownership rules whose owning package is a milestone fail to show as accepted: Unknown Object (Project).
Apr 4 2017, 9:51 PM · Unknown Object (Project), Projects, Owners, Bug Report
gregprice added a comment to T12501: `arc patch` blows up when the revision's parent has already landed.

I'm also slightly confused because, as someone just reminded me, the usual behavior of arc patch is to apply the patch to the appropriate base commit for the revision, not to try to do it on the current HEAD. In this context, that seems like it'd mean applying it directly to the arcpatch-A branch, rather than try to cherry-pick that commit up on top of where the user ran arc patch from.

Apr 4 2017, 1:15 AM · Arcanist, Unknown Object (Project), Bug Report
gregprice added a comment to T12501: `arc patch` blows up when the revision's parent has already landed.

Also T6482 seems like it's fixed. I've been quite appreciating how Arcanist is increasingly aware of dependencies between revisions.

Apr 4 2017, 1:03 AM · Arcanist, Unknown Object (Project), Bug Report
gregprice created T12501: `arc patch` blows up when the revision's parent has already landed.
Apr 4 2017, 1:01 AM · Arcanist, Unknown Object (Project), Bug Report
gregprice created D17607: Part 2.
Apr 4 2017, 12:49 AM
gregprice added a child revision for D17606: Part 1: D17607: Part 2.
Apr 4 2017, 12:49 AM
gregprice created D17606: Part 1.
Apr 4 2017, 12:48 AM

Feb 28 2017

gregprice added a project to T12328: "Watching Projects" doc section seems wrong: Unknown Object (Project).
Feb 28 2017, 2:08 AM · Unknown Object (Project), Documentation, Bug Report
gregprice created T12328: "Watching Projects" doc section seems wrong.
Feb 28 2017, 2:08 AM · Unknown Object (Project), Documentation, Bug Report

Jan 23 2017

gregprice added a project to T784: Allow Differential changesets to be marked with various attributes: Unknown Object (Project).

Having a generated-paths variable in .arcconfig with a similar semantics to the differential.generated-paths server configuration -- something like D11537 a couple of years ago was intended to do -- would be really useful!

Jan 23 2017, 10:11 PM · Restricted Project, Unknown Object (Project), Restricted Project, Differential, Arcanist

Jan 9 2017

gregprice added a project to T12033: Large diffs can still repeatedly fail to insert: Unknown Object (Project).
Jan 9 2017, 11:33 PM · Diffusion (v3), Unknown Object (Project), Mail, Differential, Bug Report

Jan 4 2017

gregprice added a project to T12060: Colorblind accessibility for red/green highlighting in e-mails: Unknown Object (Project).
Jan 4 2017, 5:14 AM · Accessibility, Design & Planning, Feature Request, Unknown Object (Project)

Dec 19 2016

gregprice added a comment to T12033: Large diffs can still repeatedly fail to insert.

We weren't running quite HEAD then, but we were running a version that was our patches on top of something about a week old -- see the end of the description of T11743, which was the first report in that chain. Our version today is a couple of months old, so I see why that'd feel different.

Dec 19 2016, 11:35 PM · Diffusion (v3), Unknown Object (Project), Mail, Differential, Bug Report

Oct 8 2016

gregprice created T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.
Oct 8 2016, 1:52 AM · Bug Report
gregprice added a comment to T11744: phutil_utf8v_combined consumes great gobs of memory, changeset parsing fails.

This helped! Thanks for another fast fix.

Oct 8 2016, 1:48 AM · Performance, Bug Report

Oct 7 2016

gregprice created T11744: phutil_utf8v_combined consumes great gobs of memory, changeset parsing fails.
Oct 7 2016, 2:38 AM · Performance, Bug Report
gregprice added a comment to T11743: Unbounded runtime and memory use on some Paste transactions.

Thanks also for the tip about SIGHUP to get a backtrace! Had not known that, and it looks extremely useful.

Oct 7 2016, 1:47 AM · Bug Report
gregprice added a comment to D16682: Make PhutilProseDifferenceEngine degrade on large inputs instead of consuming all RAM in the entire world.

Deployed this on our install, and it worked -- resolved all symptoms of T11743. Thanks again for the swift fix!

Oct 7 2016, 1:33 AM

Oct 6 2016

gregprice added a comment to T11743: Unbounded runtime and memory use on some Paste transactions.

Sweet -- thanks for the fast fix! I'll try applying it locally to clear out the affected tasks we have, and to make sure any new ones don't get me paged tonight. :-)

Oct 6 2016, 11:59 PM · Bug Report
gregprice added a comment to T11743: Unbounded runtime and memory use on some Paste transactions.

Thank you! Not every day someone invites me to cause a crash on their production server. :-D

Oct 6 2016, 10:55 PM · Bug Report
gregprice added a comment to T11743: Unbounded runtime and memory use on some Paste transactions.

Just made P2011, and I think that's a repro -- the "Show Details" link hangs.

Oct 6 2016, 10:52 PM · Bug Report
gregprice added a comment to T11743: Unbounded runtime and memory use on some Paste transactions.

Nope -- pstree shows no subprocesses when the worker is stuck.

Oct 6 2016, 10:47 PM · Bug Report
gregprice added a comment to T11743: Unbounded runtime and memory use on some Paste transactions.

Meaning here on secure.phabricator.com? Sure -- no guarantee it'll work, but I have some guesses I can throw at it.

Oct 6 2016, 10:45 PM · Bug Report
gregprice created T11743: Unbounded runtime and memory use on some Paste transactions.
Oct 6 2016, 10:32 PM · Bug Report