Page MenuHomePhabricator
Create Task
Maniphest T5889

Allow herald rules to act on existence of auditors
Closed, ResolvedPublic
Actions

Description

User request is to be able to say something like "trigger an audit by this project, unless there is already an auditor present".

I see this as analogous to the existing rules around Differential.

Revisions and Commits

rP Phabricator
D17221rP545dad319ec0 Add an "Auditors" rule for Commits

Related Objects
Search...

Event Timeline

cburroughs created this task.Aug 15 2014, 8:22 PM
cburroughs raised the priority of this task from to Needs Triage.
cburroughs updated the task description. (Show Details)
cburroughs added a project: Herald.
cburroughs added a subscriber: cburroughs.
chad triaged this task as Normal priority.Aug 25 2014, 4:36 PM
chad added a project: Audit.
cburroughs mentioned this in T6170: How should I create audits without always emailing all project members.Sep 23 2014, 6:28 PM
altendky added a subscriber: altendky.Sep 23 2014, 6:46 PM
joshuaspence added a subscriber: joshuaspence.Jan 3 2015, 2:33 AM
joshuaspence claimed this task.May 28 2015, 8:59 AM
epriestley added a subtask: T8726: Modularize Herald fields and actions.Jun 30 2015, 4:54 PM
eadler added a subscriber: eadler.Jul 3 2015, 7:48 PM
epriestley closed subtask T8726: Modularize Herald fields and actions as Resolved.Aug 6 2015, 2:52 PM
cburroughs mentioned this in Q102: Specifying auditor for commit (Answer 124).Aug 21 2015, 2:33 PM
eadler added a project: Restricted Project.Jan 8 2016, 11:10 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Feb 18 2016, 6:31 PM
eadler edited projects, added Restricted Project; removed Restricted Project.Feb 26 2016, 8:00 PM
epriestley mentioned this in T10978: Modernize Audit.May 17 2016, 2:34 PM
eadler edited projects, added Restricted Project; removed Restricted Project.Jun 6 2016, 5:36 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:00 PM
epriestley moved this task from Backlog to Herald on the Audit board.Jan 10 2017, 4:42 PM
epriestley added a revision: D17221: Add an "Auditors" rule for Commits.Jan 18 2017, 5:53 PM
epriestley added a subscriber: epriestley.Jan 18 2017, 5:54 PM

D17221 adds an "Auditors" field to Herald.

Note that this field can act on auditors added by Auditors: ... in the commit message and auditors added by Owners, but can not act on auditors added by other Herald rules. That is, it is not possible to write a Herald rule like this:

If no other Herald rules added auditors, add some auditors.

Herald is intentionally not reentrant (or turing-complete) so I don't expect this rule to ever be possible to write.

epriestley closed this task as Resolved by committing rP545dad319ec0: Add an "Auditors" rule for Commits.Jan 18 2017, 6:05 PM
epriestley added a commit: rP545dad319ec0: Add an "Auditors" rule for Commits.
cburroughs awarded a token.Jan 18 2017, 9:47 PM
Phabricator · Built by Phacility