Page MenuHomePhabricator

neilfitz (Neil Fitzgerald)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 10 2016, 10:18 PM (160 w, 2 d)
Availability
Available

Recent Activity

Jan 18 2018

neilfitz awarded T13038: Meltdown and Spectre Speculative Branch Prediction Attacks a Yellow Medal token.
Jan 18 2018, 12:01 AM · Security

Jun 14 2017

neilfitz added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

As more of a point of philosophy of code review also, I (and, I think, my teammates) would say that diffs should be reviewed by someone who both:

  1. Understands the relevant code
  2. Did not write the code themselves

In other words, the combination of expertise + different perspective is of value beyond each component individually. If you believe that, then B or C should review A's diff in this case.

Jun 14 2017, 9:56 PM · Restricted Project, Feature Request

May 30 2017

neilfitz added a comment to T12778: Repository mirroring is much more frequent than necessary.

Thanks for the detailed response! We hadn't considered that people might tamper with mirror remotes, so you make a very good point there that our proposed change might cause a regression. And you're quite right that logging is our problem.

May 30 2017, 11:11 PM · Restricted Project, Bug Report
neilfitz added a comment to T12778: Repository mirroring is much more frequent than necessary.

I actually wasn't sure which to pick myself, since it's not as specific as most bug reports, but it seemed more like undesirable behavior of an existing feature, as opposed to a new feature. Would it be more appropriate to consider this as a feature request instead?

May 30 2017, 9:56 PM · Restricted Project, Bug Report
neilfitz added a project to T12778: Repository mirroring is much more frequent than necessary: Restricted Project.
May 30 2017, 9:29 PM · Restricted Project, Bug Report
neilfitz created T12778: Repository mirroring is much more frequent than necessary.
May 30 2017, 9:29 PM · Restricted Project, Bug Report
neilfitz added a comment to T12423: Bring MenuItem customization options to User Profiles.

Thanks! That should be perfect.

May 30 2017, 9:17 PM · Dashboards, Restricted Project, Profile
neilfitz awarded rP88c5c02e7233: Group Maniphest Tasks by Priority on Profiles a Love token.
May 30 2017, 9:16 PM
neilfitz added a project to T12423: Bring MenuItem customization options to User Profiles: Restricted Project.

Hey, we're also interested in this by way of T12545 (which was merged in above). A couple of our teams have historically assigned their oncall/tech-debt tasks to a mailing list user, and used the priority-sorted view of those tasks to run their oncall shifts. That workflow no longer works with the reverse-chronological sort.

May 30 2017, 8:44 PM · Dashboards, Restricted Project, Profile

May 6 2017

neilfitz added a comment to T12682: `storage --dry-run` actually looks rather wet when applying patches.

Us right now:

May 6 2017, 2:18 AM · Bug Report
neilfitz created Image Macro "rain".
May 6 2017, 2:18 AM

Mar 24 2017

neilfitz added a project to T12118: Differential email does not contain reviewers/subscribers information anymore: Restricted Project.

Our users are also missing this, since they can't tell whether they're a blocking/lone reviewer from the e-mail.

Mar 24 2017, 12:14 AM · Restricted Project, Differential, Bug Report

Feb 9 2017

neilfitz added a project to T12106: task search not finding task with full word match : Restricted Project.

Hey, one of our teams is experiencing this issue as well - many of their tasks include the name of a flag with a lot of punctuation, such as subgrowth_biz_buy_order_summary. At some point in the not-terribly-distant past, searching for these flags started to return 0 results.

Feb 9 2017, 2:52 AM · Restricted Project, Search, Bug Report

Jan 10 2017

neilfitz moved T12088: Moving task cards on a project workboard sorted by priority is extremely slow from Restricted Project Column to Restricted Project Column on the Restricted Project board.

You're right, works fine for me against a Phacility test instance. Huh.

Jan 10 2017, 4:00 AM · Bug Report (Needs Information), Restricted Project
neilfitz created T12088: Moving task cards on a project workboard sorted by priority is extremely slow.
Jan 10 2017, 3:31 AM · Bug Report (Needs Information), Restricted Project

Jan 9 2017

neilfitz moved T12060: Colorblind accessibility for red/green highlighting in e-mails from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 9 2017, 11:55 PM · Accessibility, Design, Feature Request, Restricted Project

Jan 5 2017

tsy awarded T12060: Colorblind accessibility for red/green highlighting in e-mails a Love token.
Jan 5 2017, 9:50 PM · Accessibility, Design, Feature Request, Restricted Project

Jan 4 2017

neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

They said it's a definite improvement. Nice!

Jan 4 2017, 7:34 PM · Accessibility, Design, Feature Request, Restricted Project
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Thanks for the quick response! I'll send that last image over to our user, and see if it's an improvement for them as well.

Jan 4 2017, 7:25 PM · Accessibility, Design, Feature Request, Restricted Project
neilfitz updated the task description for T12060: Colorblind accessibility for red/green highlighting in e-mails.
Jan 4 2017, 2:32 AM · Accessibility, Design, Feature Request, Restricted Project
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Okay, after some tests, looks like the user has deuteranopia. Consistent with what you have there.

Jan 4 2017, 2:32 AM · Accessibility, Design, Feature Request, Restricted Project
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Uh, I'll see if they can take an online test to narrow it down further.

Jan 4 2017, 2:17 AM · Accessibility, Design, Feature Request, Restricted Project
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

They don't know what type they have more specifically than red-green, unfortunately.

Jan 4 2017, 2:15 AM · Accessibility, Design, Feature Request, Restricted Project
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

I'm not sure I understand what you mean. To be clear, the user doesn't have an issue reading the text; they have an issue distinguishing between red highlight and green highlight. I think it would be even more confusing without any highlighting at all.

Jan 4 2017, 2:02 AM · Accessibility, Design, Feature Request, Restricted Project
neilfitz created T12060: Colorblind accessibility for red/green highlighting in e-mails.
Jan 4 2017, 1:16 AM · Accessibility, Design, Feature Request, Restricted Project

Dec 2 2016

neilfitz added a comment to T11938: Running `git clone` against a Mercurial repository does not produce an error message with explicit guidance.

Damn, that was fast! This should be a perfect solution - thank you for your help.

Dec 2 2016, 7:02 PM · Diffusion, Feature Request
neilfitz added a comment to T11938: Running `git clone` against a Mercurial repository does not produce an error message with explicit guidance.

Absolutely makes sense - provided some more background on the problem. Looking forward to hearing your thoughts.

Dec 2 2016, 2:46 AM · Diffusion, Feature Request
neilfitz updated the task description for T11938: Running `git clone` against a Mercurial repository does not produce an error message with explicit guidance.
Dec 2 2016, 2:45 AM · Diffusion, Feature Request
neilfitz added a comment to T11938: Running `git clone` against a Mercurial repository does not produce an error message with explicit guidance.

Ok, appreciate the feedback - I'll try to tackle it in a bit more detail.

Dec 2 2016, 1:24 AM · Diffusion, Feature Request

Dec 1 2016

neilfitz created T11938: Running `git clone` against a Mercurial repository does not produce an error message with explicit guidance.
Dec 1 2016, 10:50 PM · Diffusion, Feature Request