Page MenuHomePhabricator
Create Task
Maniphest T8739

Inline comments not sorted
Closed, ResolvedPublic
Actions

Description

  1. when I add 2 inline comments (A and then B), then in commit bottom (where preview part is) they show as "B and then A" - latest added shows on top
  2. once I submit inline comments in commit summary (see image below):
    • sorting of files with inline comments, doesn't match file sorting in commit itself
    • sorting of inline comments within single file isn't done by line number, but as I added them therefore comment on line 280 goes after comment on line 287

Commit_InlineComments_NotSorted.png (939×904 px, 219 KB)

Maybe T1790 is related.

Revisions and Commits

rP Phabricator
D17184rPb471f6c07aef Order inline comments in Diffusion consistently with Differential
D17183rPb5722a99635a Use EditEngine stacked comments in Diffusion

Related Objects

Event Timeline

aik099 created this task.Jul 2 2015, 9:11 AM
aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Audit.
aik099 added a subscriber: aik099.
joshuaspence added a subscriber: joshuaspence.Jul 2 2015, 10:07 PM
chad merged a task: T11213: Inline comments show up in reverse order in the summary.Jun 24 2016, 8:47 PM
chad added a subscriber: anton.vladimirov.
anton.vladimirov added a comment.Jun 24 2016, 8:48 PM

Never noticed that before? Is this specific for Audit?

chad added a subscriber: chad.Jun 24 2016, 8:52 PM

I don't know offhand, See T10978, we have a lot of cruft in Audit that just needs tossing out.

anton.vladimirov added a comment.Jun 24 2016, 8:58 PM

Nice! Thanks.

chad added a comment.Jun 24 2016, 8:59 PM

(I don't know if this is the exact same bug, but we'd fix them both in the same pass)

epriestley moved this task from Backlog to EditEngine on the Audit board.Jan 10 2017, 4:39 PM
epriestley moved this task from EditEngine to Inlines on the Audit board.Jan 10 2017, 4:42 PM
epriestley added a revision: D17183: Use EditEngine stacked comments in Diffusion.Jan 11 2017, 10:27 PM
epriestley added a subscriber: epriestley.Jan 11 2017, 10:34 PM

D17183 fixes half of this: previews are now sorted in creation order, from oldest (top) to newest (bottom). This is the same order used in Differential. We use this order for previews because it makes it easier to review recently added comments while working through a review/audit.

A future change will fix the other half of this (ordering within the timeline).

epriestley added a revision: D17184: Order inline comments in Diffusion consistently with Differential.Jan 11 2017, 10:46 PM
epriestley added a commit: rPb5722a99635a: Use EditEngine stacked comments in Diffusion.Jan 11 2017, 10:46 PM
epriestley closed this task as Resolved by committing rPb471f6c07aef: Order inline comments in Diffusion consistently with Differential.Jan 11 2017, 10:57 PM
epriestley added a commit: rPb471f6c07aef: Order inline comments in Diffusion consistently with Differential.
Phabricator · Built by Phacility