Page MenuHomePhabricator

Manually added auditors doesn't change commit audit status
Closed, ResolvedPublic

Description

The PhabricatorRepositoryCommit::updateAuditStatus method (see https://secure.phabricator.com/diffusion/P/browse/master/src/applications/repository/storage/PhabricatorRepositoryCommit.php;7705f452d238f85d7e3f39391ea0701696679236$209) doesn't consider manually added auditors (via "add auditors" action on commit detail page) as criteria for changing commit audit status to "needs audit".

I think, that not only PhabricatorAuditStatusConstants::AUDIT_REQUIRED but also PhabricatorAuditStatusConstants::AUDIT_REQUESTED constant should trigger $any_need variable.

Revisions and Commits

Restricted Differential Revision

Related Objects

Event Timeline

aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Audit.
aik099 added a subscriber: aik099.
epriestley added a revision: Restricted Differential Revision.Jan 11 2017, 10:53 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jan 11 2017, 10:59 PM
epriestley added a commit: Restricted Diffusion Commit.