Page MenuHomePhabricator

Differential keyboard shortcuts for navigating diffs disappeared in the last update
Closed, ResolvedPublic

Description

Steps to Reproduce

Go to any differential revision (e.g. on this instance: https://secure.phabricator.com/D17165).
Press Shift+? to pull up the list of keyboard shortcuts
All of the shortcuts related to navigating the diff appear to be gone (e.g. n/p, j/k), the only available shortcuts are z/?/'/'/esc (it's not just that they're not displayed in that list, you can try using the old shortcuts, but nothing happens).

Version

I noticed this issue after upgrading to https://secure.phabricator.com/w/changelog/2017.01/

I think the shortcuts went away in: https://secure.phabricator.com/rPc05306d746d7e06e3f2a5eb712af89a616abfdc6 (at least on a test instance inserting "Javelin::initBehavior('differential-keyboard-navigation',
array( 'haunt' => null));" on line 465 of src/applications/differential/controller/DifferentialRevisionViewController.php brought them back, and that commit seems to be the one that removed a similar line).

Since that commit mentions it broke a lot of stuff this might be intentional, but I couldn't find anything explicitly in the commit message or release notes, so I thought I'd report it.