Page MenuHomePhabricator
Create Task
Maniphest T6698

Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail
Closed, DuplicatePublic
Actions

Description

My local install is a mess so I can't easily repro this, but I found at least one mail which suggests it's an issue. Likely repro is:

  • Make a commit which mentions an object (like a task), but does not use "Fixes", "Ref", etc.
  • Mail gets <audit-other> tag in the header, but should not, because this transaction is not explicit to the user and adding the tag is confusing (per this task).

Original Description

Steps to reproduce:

  • set [A commit is created] = "Notify" in settings/panel/emailpreferences
  • an email is still sent on a new commit
  • this seems to contradict "Notify: You will receive an unread notification only." statement on the same preferences page

Related Objects
Search...

Event Timeline

• lysy95 created this task.Dec 5 2014, 6:48 AM
• lysy95 raised the priority of this task from to Needs Triage.
• lysy95 updated the task description. (Show Details)
• lysy95 added projects: Notifications, Audit.
• lysy95 added a subscriber: • lysy95.
epriestley added a subscriber: epriestley.Dec 5 2014, 11:38 AM

Can you show me the X-Phabricator-Mail-Tags header for the relevant message? You may need to "Show Raw Message" or similar in your client to see it.

• lysy95 closed this task as Resolved.Dec 5 2014, 2:28 PM
• lysy95 claimed this task.

I can't reproduce it anymore after restarting of the server. Sorry for the trouble.

• lysy95 added a comment.Dec 11 2014, 2:51 AM

Just to clarify the case further:

I have received a seemingly stray notification again today. In the email headers it says :X-Phabricator-Mail-Tags: <audit-commit>, <audit-other> and that explains that email was sent as a notification for the "Other commit activity", which in my case is set to "Email". That is, I guess, because I've mentioned a task in my commit comments.

epriestley added a comment.Dec 11 2014, 2:54 AM

Is the first section of the mail just like:

lysy95 committed <this commit>.

...not like:

lysy95 committed <this commit>.
lysy95 blah blah did some other stuff.

If so, we shouldn't be adding <audit-other> for pseudo-transactions like object mentions, but might be incorrectly doing that.

epriestley renamed this task from Email notifications is still sent despite email preferences is set to "Notify" for the feature to Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail.Dec 11 2014, 3:04 AM
epriestley reopened this task as Open.
epriestley removed • lysy95 as the assignee of this task.
epriestley triaged this task as Low priority.
epriestley updated the task description. (Show Details)
epriestley added a project: Mail.
• lysy95 added a comment.Dec 11 2014, 3:29 AM

Body of the email:

*** committed rRK3477: default-deferred excel template for backward compatibility in context of T52.

default-deferred excel template for backward compatibility in context of https://***.***.com/T52


AFFECTED FILES
  /projects/***/trunk/rs/etc/file/default-deferred.xlsx

USERS
  *** (Author)

COMMIT
  https://***.***.com/rRK3477

To: ***

Headers of the email:

Return-path: <phabricator@***.com>
Received: from localhost.localdomain by ***.com (MDaemon PRO v14.0.3) 
	with ESMTP id md50013365219.msg for <***@***.com>;
	Thu, 11 Dec 2014 10:39:27 +0800
Authentication-Results: mail.***.com
	auth=pass smtp.mail=phabricator@***.com
X-Spam-Processed: mail.***.com, Thu, 11 Dec 2014 10:39:27 +0800
	(not processed: message from trusted or authenticated source)
X-Authenticated-Sender: testaccount@***.com
X-Rcpt-To: ***@***.com
X-MDRcpt-To: ***@***.com
X-MDRemoteIP: ***
X-Return-Path: phabricator@***.com
X-Envelope-From: phabricator@***.com
X-MDaemon-Deliver-To: ***@***.com
Date: Thu, 11 Dec 2014 10:35:47 +0800
To: ***@***.com
From: *** *** <phabricator@***.com>
Subject: [Diffusion] [Committed] rRK3477: default-deferred excel template for backward compatibility in context of T52
Message-ID: <1244e3a5618bfc99bb1fda33c41453ba@localhost.localdomain>
X-Priority: 3
X-Mailer: PHPMailer 5.1 (phpmailer.sourceforge.net)
Thread-Topic: Commit rRK3477
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-qmyogjzf6mg7vy2cicdb>
In-Reply-To: <diffusion-audit-PHID-CMIT-rjmeiiimzzgsg3az7ah2@mail.***.com>
References: <diffusion-audit-PHID-CMIT-rjmeiiimzzgsg3az7ah2@mail.***.com>
Thread-Index: M2ExN2VmZWRmY2QzNzllYWE5ODdkMTg2NzQ1IFSJAwM=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <audit-commit>, <audit-other>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
epriestley moved this task from Backlog to v3 on the Mail board.Jul 16 2016, 2:25 PM
epriestley mentioned this in T10448: Modularize mail tags.Jul 16 2016, 4:30 PM
epriestley added a parent task: T10448: Modularize mail tags.Jul 16 2016, 5:33 PM
eadler added a project: Restricted Project.Jul 25 2016, 4:54 PM
Herald added a subscriber: eadler. · View Herald TranscriptJul 25 2016, 4:54 PM
epriestley added a comment.Jan 10 2017, 4:56 PM

I'm just going to merge this into T10448, this task doesn't have anything not already covered there.

epriestley closed this task as a duplicate of T10448: Modularize mail tags.Jan 10 2017, 4:56 PM
Phabricator · Built by Phacility