Page MenuHomePhabricator
Feed Advanced Search

Jan 11 2017

epriestley closed T8739: Inline comments not sorted as Resolved by committing rPb471f6c07aef: Order inline comments in Diffusion consistently with Differential.
Jan 11 2017, 10:57 PM · Audit
epriestley closed T2921: Audit status is none on commit views of Audit if no Auditors specifically assigned as Invalid.

This is 100 years old and I'm no longer sure what it's describing or how to reproduce it. Feel free to file a new issue if this is still a problem. Note that Audit is churning a lot right now (see T10978) so the behavior may change in the near term. This may also be a "viewer audit status" vs "commit overall audit status" issue in some sense (T9482 / T6024).

Jan 11 2017, 10:56 PM · Audit
epriestley added a revision to T7504: Manually added auditors doesn't change commit audit status: D17185: Make "Audit Requested" put commits into the "Needs Audit" state.
Jan 11 2017, 10:53 PM · Audit
epriestley closed T5928: Clarify language around self-accepting Audits as Resolved.

We no longer offer this option at HEAD. I'm moving us away from the self raise + self accept workflow to align better with Differential and because the state is unintuitive.

Jan 11 2017, 10:49 PM · Audit
epriestley closed T10446: Unable to simply mark a Diffusion comment as Done as Resolved by committing rPb5722a99635a: Use EditEngine stacked comments in Diffusion.
Jan 11 2017, 10:46 PM · Audit, Bug Report
epriestley added a comment to T10446: Unable to simply mark a Diffusion comment as Done.

I believe D17183 fixes this. If you're still seeing issues after upgrading past that change, file a new issue with modern reproduction instructions.

Jan 11 2017, 10:46 PM · Audit, Bug Report
epriestley added a revision to T8739: Inline comments not sorted: D17184: Order inline comments in Diffusion consistently with Differential.
Jan 11 2017, 10:46 PM · Audit
epriestley added a comment to T8739: Inline comments not sorted.

D17183 fixes half of this: previews are now sorted in creation order, from oldest (top) to newest (bottom). This is the same order used in Differential. We use this order for previews because it makes it easier to review recently added comments while working through a review/audit.

Jan 11 2017, 10:34 PM · Audit
epriestley added a revision to T10978: Modernize Audit: D17183: Use EditEngine stacked comments in Diffusion.
Jan 11 2017, 10:27 PM · Audit
epriestley added a revision to T8739: Inline comments not sorted: D17183: Use EditEngine stacked comments in Diffusion.
Jan 11 2017, 10:27 PM · Audit
epriestley added a revision to T10446: Unable to simply mark a Diffusion comment as Done: D17183: Use EditEngine stacked comments in Diffusion.
Jan 11 2017, 10:27 PM · Audit, Bug Report
epriestley added a revision to T10978: Modernize Audit: D17182: Add modern "Accept", "Raise Concern" and "Resign" transactions to Audit.
Jan 11 2017, 8:19 PM · Audit
epriestley closed T7676: Packages that are configured to auto-audit often generate audits that are un-closable as Resolved.

I'm just going to presume this is resolved, in some sense, by D17181, because you can now remove auditors regardless of other outcomes.

Jan 11 2017, 7:29 PM · Owners, Audit
epriestley added a revision to T10978: Modernize Audit: D17181: Allow auditors to be added and removed from commits in a modern way.
Jan 11 2017, 7:23 PM · Audit
epriestley added a revision to T7676: Packages that are configured to auto-audit often generate audits that are un-closable: D17181: Allow auditors to be added and removed from commits in a modern way.
Jan 11 2017, 7:23 PM · Owners, Audit
epriestley added a revision to T10978: Modernize Audit: D17178: Add "diffusion.commit.edit", a v3 edit API endpoint for commits.
Jan 11 2017, 5:50 PM · Audit
epriestley added a revision to T10978: Modernize Audit: D17177: Replace old commit edit controller with new EditEngine controller.
Jan 11 2017, 5:44 PM · Audit
epriestley added a revision to T10978: Modernize Audit: D17176: Preserve "Autoclose?" information on new Commit edit flow.
Jan 11 2017, 5:40 PM · Audit
epriestley added a revision to T10978: Modernize Audit: D17175: Bring very basic EditEngine support to commits.
Jan 11 2017, 4:48 PM · Audit
epriestley added a comment to T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.

Although I earlier (in T6630#85282) felt like it was reasonable to consider separating Audit and Diffusion, there are now more existing or planned integration points and I think this approach is significantly less reasonable than the "merge them" approach. It also doesn't seem to be causing any problems on real installs.

Jan 11 2017, 4:17 PM · Audit, Diffusion, Wikimedia

Jan 10 2017

epriestley moved T6636: Show Audit status of referenced commits in Maniphest from Backlog to Audit States on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Diffusion, Maniphest
epriestley moved T8690: Modernize PhabricatorCommitSearchEngine from Backlog to EditEngine on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Restricted Project, ApplicationSearch, Diffusion
epriestley moved T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) from Backlog to Inlines on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley moved T4343: Implement "arc audit" from Backlog to Future on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Diffusion
epriestley added a project to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion): Audit.
Jan 10 2017, 5:17 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley added a project to T8690: Modernize PhabricatorCommitSearchEngine: Audit.
Jan 10 2017, 5:13 PM · Audit, Restricted Project, ApplicationSearch, Diffusion
epriestley added a project to T6636: Show Audit status of referenced commits in Maniphest: Audit.
Jan 10 2017, 5:12 PM · Audit, Diffusion, Maniphest
epriestley added a project to T4343: Implement "arc audit": Audit.
Jan 10 2017, 5:11 PM · Audit, Diffusion
epriestley moved T9482: Problems in the "Commits in this Package that Need Attention" view from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:09 PM · Restricted Project, Restricted Project, Audit
epriestley moved T7676: Packages that are configured to auto-audit often generate audits that are un-closable from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:07 PM · Owners, Audit
epriestley moved T2393: Adds a "Needs Verification" state to Audits from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Restricted Project, Audit
epriestley moved T5928: Clarify language around self-accepting Audits from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Audit
epriestley moved T6024: Display (post-push) audit-state in Diffusion commit-list from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Restricted Project, Audit, Diffusion
epriestley moved T9544: way to search for commits with no audit status from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Restricted Project, Restricted Project, Audit
epriestley moved T8683: Ability to query audits where all auditors have replied from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:06 PM · Audit
epriestley moved T7504: Manually added auditors doesn't change commit audit status from EditEngine to Audit States on the Audit board.
Jan 10 2017, 5:05 PM · Audit
epriestley closed T9423: Timeout error when loading "All Audits" query from a user who should not have access to any commits/audits as Resolved.

I believe this was resolved by the introduction of the "query overheating" mechanism, described in T11773.

Jan 10 2017, 5:04 PM · Audit
epriestley merged T1397: Navigating the repository tree while auditing into T5815: Make it easier to work through a queue of stuff.
Jan 10 2017, 5:00 PM · Restricted Project, Maniphest, Differential, Audit
epriestley merged task T1397: Navigating the repository tree while auditing into T5815: Make it easier to work through a queue of stuff.
Jan 10 2017, 4:59 PM · Audit, Diffusion
epriestley added a comment to T1397: Navigating the repository tree while auditing.

I'm going to merge this into T5815, which is a more general discussion of action queues.

Jan 10 2017, 4:59 PM · Audit, Diffusion
epriestley moved T5338: Incorrect handling of merge commits from Backlog to Herald on the Audit board.
Jan 10 2017, 4:58 PM · Differential, Audit
epriestley moved T6557: Automatic auditing should ignore merges from Backlog to Herald on the Audit board.
Jan 10 2017, 4:58 PM · Audit
epriestley closed T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter." as Invalid.

I can't reproduce this; we can't move forward without reproduction steps.

Jan 10 2017, 4:58 PM · Audit, Bug Report
epriestley merged task T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail into T10448: Modularize mail tags.
Jan 10 2017, 4:56 PM · Restricted Project, Mail, Audit, Notifications
epriestley added a comment to T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail.

I'm just going to merge this into T10448, this task doesn't have anything not already covered there.

Jan 10 2017, 4:56 PM · Restricted Project, Mail, Audit, Notifications
epriestley moved T6660: Unsubmitted comments icon for Audits from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:56 PM · Restricted Project, Audit
epriestley closed T2716: Consolidate "load commit from name" code as Resolved.
  • DiffusionCommitQuery has had the "good" version for a while.
  • We're nuking Releeph at some point.
Jan 10 2017, 4:56 PM · Releeph, Diffusion, Audit
epriestley moved T2921: Audit status is none on commit views of Audit if no Auditors specifically assigned from Backlog to Audit States on the Audit board.
Jan 10 2017, 4:55 PM · Audit
epriestley moved T3917: Avoid or easily handle 'duplicate' audits from Backlog to Audit States on the Audit board.
Jan 10 2017, 4:55 PM · Restricted Project, Audit
epriestley moved T4026: Add relations between commits from Backlog to Audit States on the Audit board.
Jan 10 2017, 4:54 PM · Restricted Project, Audit
epriestley moved T6507: Audit inline comments doesn't account for synthetic authors from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:54 PM · Audit
epriestley moved T6810: Inline comments is only partially working in an imported SVN repo from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:53 PM · Audit
epriestley moved T11029: Colorized html inline diffs for Diffusion from Backlog to Inlines on the Audit board.
Jan 10 2017, 4:51 PM · Diffusion (v3), Audit
epriestley moved T11118: Herald Rule to assign Owners to an Audit from Backlog to Future on the Audit board.
Jan 10 2017, 4:51 PM · Restricted Project, Audit, Herald, Owners, Feature Request
epriestley moved T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter." from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:50 PM · Audit, Bug Report
epriestley moved T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:44 PM · Audit, Diffusion, Wikimedia
epriestley moved T5815: Make it easier to work through a queue of stuff from Backlog to Far Future on the Audit board.
Jan 10 2017, 4:44 PM · Restricted Project, Maniphest, Differential, Audit
epriestley moved T5722: Support meta-audit of arbitrary baskets of nonadjacent commits from Backlog to Far Future on the Audit board.
Jan 10 2017, 4:43 PM · Audit
epriestley moved T3639: Don't eat unsaved inline comments from Backlog to Future on the Audit board.
Jan 10 2017, 4:43 PM · Audit
epriestley moved T2393: Adds a "Needs Verification" state to Audits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:43 PM · Restricted Project, Audit
epriestley moved T10446: Unable to simply mark a Diffusion comment as Done from EditEngine to Inlines on the Audit board.
Jan 10 2017, 4:42 PM · Audit, Bug Report
epriestley moved T8739: Inline comments not sorted from EditEngine to Inlines on the Audit board.
Jan 10 2017, 4:42 PM · Audit
epriestley moved T5889: Allow herald rules to act on existence of auditors from Backlog to Herald on the Audit board.
Jan 10 2017, 4:42 PM · Restricted Project, Audit, Herald
epriestley moved T5928: Clarify language around self-accepting Audits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:41 PM · Audit
epriestley moved T6024: Display (post-push) audit-state in Diffusion commit-list from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:41 PM · Restricted Project, Audit, Diffusion
epriestley moved T9544: way to search for commits with no audit status from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Restricted Project, Restricted Project, Audit
epriestley moved T8683: Ability to query audits where all auditors have replied from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Audit
epriestley moved T7676: Packages that are configured to auto-audit often generate audits that are un-closable from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Owners, Audit
epriestley moved T7504: Manually added auditors doesn't change commit audit status from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Audit
epriestley moved T8739: Inline comments not sorted from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:39 PM · Audit
epriestley moved T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:38 PM · Restricted Project, Typeahead, Audit
epriestley moved T9423: Timeout error when loading "All Audits" query from a user who should not have access to any commits/audits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:38 PM · Audit
epriestley moved T9430: "Needs Audit" no longer excludes author commits from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:38 PM · Restricted Project, Restricted Project, Audit
epriestley moved T9482: Problems in the "Commits in this Package that Need Attention" view from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:38 PM · Restricted Project, Restricted Project, Audit
epriestley moved T10446: Unable to simply mark a Diffusion comment as Done from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:37 PM · Audit, Bug Report
epriestley moved T10978: Modernize Audit from Backlog to EditEngine on the Audit board.
Jan 10 2017, 4:37 PM · Audit
epriestley moved T11212: One of our audits is displaying comments from another audit from Backlog to Future on the Audit board.
Jan 10 2017, 4:36 PM · Quicksand, Audit, Bug Report
epriestley added a project to T11212: One of our audits is displaying comments from another audit: Quicksand.
Jan 10 2017, 4:36 PM · Quicksand, Audit, Bug Report

Dec 29 2016

epriestley removed a project from T4026: Add relations between commits: Differential.
Dec 29 2016, 4:25 PM · Restricted Project, Audit

Dec 12 2016

epriestley closed T2542: Provide a link from revisions that are blamees to their blamers as Resolved.

"Blame Revision" was a freeform text field at Facebook (from before DiffCamp, even) where you were ideally supposed to enter the revision or commit that introduced the bug you're fixing, if you were fixing a bug introduced by some known change.

Dec 12 2016, 9:18 PM · Audit, Diffusion, Differential

Dec 9 2016

chad merged T11983: Regarding linking new code revisions to the already opened Audit request for SVN into T10978: Modernize Audit.
Dec 9 2016, 4:35 PM · Audit
chad merged task T11983: Regarding linking new code revisions to the already opened Audit request for SVN into T10978: Modernize Audit.
Dec 9 2016, 4:35 PM · Audit, Feature Request
chad closed T11983: Regarding linking new code revisions to the already opened Audit request for SVN as Invalid.
Dec 9 2016, 4:05 PM · Audit, Feature Request
muneer created T11983: Regarding linking new code revisions to the already opened Audit request for SVN.
Dec 9 2016, 2:35 PM · Audit, Feature Request

Dec 8 2016

chad merged T11970: Add ability to remove auditors from commit into T7676: Packages that are configured to auto-audit often generate audits that are un-closable.
Dec 8 2016, 8:37 PM · Owners, Audit

Nov 15 2016

chad reopened T8783: Unprototype Nuance (v1), a subtask of T5815: Make it easier to work through a queue of stuff, as Open.
Nov 15 2016, 11:25 PM · Restricted Project, Maniphest, Differential, Audit

Nov 3 2016

adam93 added a watcher for Audit: adam93.
Nov 3 2016, 2:58 PM

Nov 1 2016

adam93 added a comment to T4026: Add relations between commits.

Also interested in this. Our team plans on using the audit tool for code reviews, it be good if when a developer has made any suggested changes and re-committed that the old open audit could be closed/linked to the latest commit rather than having to comment on the old one with a link to the changed copy and just closing the old one manually.

Nov 1 2016, 1:57 PM · Restricted Project, Audit

Oct 17 2016

epriestley added a subtask for T10978: Modernize Audit: T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository.
Oct 17 2016, 10:57 PM · Audit

Oct 8 2016

kailei added a comment to T4026: Add relations between commits.

How about this, it's solved or not?

Oct 8 2016, 12:39 PM · Restricted Project, Audit

Sep 22 2016

porsovan added a watcher for Audit: porsovan.
Sep 22 2016, 8:22 AM
502280728 added a member for Audit: 502280728.
Sep 22 2016, 1:28 AM

Sep 15 2016

eadler added a project to T11118: Herald Rule to assign Owners to an Audit: Restricted Project.
Sep 15 2016, 6:09 PM · Restricted Project, Audit, Herald, Owners, Feature Request

Sep 8 2016

avivey added a comment to T11118: Herald Rule to assign Owners to an Audit.

We're looking for a similar concept for Reviewers:
Even if the Author of a review is one of the Owners, we still want to automatically add that package.
This is mostly just T1125 - we want to make it easier to assign reviewers, and Owners has good UI for selecting paths.

Sep 8 2016, 6:44 PM · Restricted Project, Audit, Herald, Owners, Feature Request

Aug 7 2016

eadler added a project to T3917: Avoid or easily handle 'duplicate' audits: Restricted Project.
Aug 7 2016, 8:02 PM · Restricted Project, Audit
eadler added a comment to T7676: Packages that are configured to auto-audit often generate audits that are un-closable.

FWIW this exact set of reproduction steps no longer works. However, an Owners package set to generate an audit, but without any members, will be unclosable as well.

Aug 7 2016, 8:02 PM · Owners, Audit

Jul 25 2016

eadler added a project to T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail: Restricted Project.
Jul 25 2016, 4:54 PM · Restricted Project, Mail, Audit, Notifications

Jul 20 2016

ronaldpringadi updated Q450: How to address a concern by using a new code check in? from to How to address a concern by using a new code check in?.
Jul 20 2016, 4:01 PM · Audit

Jul 16 2016

epriestley added a parent task for T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail: T10448: Modularize mail tags.
Jul 16 2016, 5:33 PM · Restricted Project, Mail, Audit, Notifications
epriestley moved T6698: Mentioning objects in commits incorrectly adds `<audit-other>` tag to mail from Backlog to v3 on the Mail board.
Jul 16 2016, 2:25 PM · Restricted Project, Mail, Audit, Notifications