Page MenuHomePhabricator

Order inline comments in Diffusion consistently with Differential
ClosedPublic

Authored by epriestley on Jan 11 2017, 10:46 PM.
Tags
None
Referenced Files
F15554774: D17184.id41324.diff
Mon, Apr 28, 8:29 AM
F15549329: D17184.id.diff
Sun, Apr 27, 5:06 AM
F15548222: D17184.diff
Sat, Apr 26, 10:32 PM
F15542822: D17184.id41327.diff
Fri, Apr 25, 7:09 PM
F15427539: D17184.id41327.diff
Mar 23 2025, 2:50 PM
F15419837: D17184.id41324.diff
Mar 21 2025, 9:18 AM
F15409986: D17184.id.diff
Mar 19 2025, 6:23 AM
F15408655: D17184.diff
Mar 19 2025, 12:37 AM
Subscribers
None

Details

Summary

Fixes T8739. Currently, Diffusion inline comments in the timeline are sorted arbitrarily, mostly by creation order.

Instead, sort them by line number, like Differential.

Test Plan

Made comments in "C", "B", "A" order, saw them in line order after submit:

Screen Shot 2017-01-11 at 2.44.08 PM.png (271×504 px, 36 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable