Page MenuHomePhabricator

Order inline comments in Diffusion consistently with Differential
ClosedPublic

Authored by epriestley on Jan 11 2017, 10:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 14, 8:03 AM
Unknown Object (File)
Sat, Jan 14, 8:03 AM
Unknown Object (File)
Sat, Jan 14, 8:03 AM
Unknown Object (File)
Dec 27 2022, 12:23 PM
Unknown Object (File)
Dec 24 2022, 3:37 PM
Unknown Object (File)
Dec 9 2022, 9:46 PM
Unknown Object (File)
Dec 6 2022, 4:34 PM
Unknown Object (File)
Nov 11 2022, 7:09 AM
Subscribers
None

Details

Summary

Fixes T8739. Currently, Diffusion inline comments in the timeline are sorted arbitrarily, mostly by creation order.

Instead, sort them by line number, like Differential.

Test Plan

Made comments in "C", "B", "A" order, saw them in line order after submit:

Screen Shot 2017-01-11 at 2.44.08 PM.png (271×504 px, 36 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable