Make "Audit Requested" put commits into the "Needs Audit" state
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 10:53 PM.

Tags

None

Referenced Files

	F15461394: D17185.id41326.diff
	Tue, Apr 1, 8:00 AM

	F15451205: D17185.id.diff
	Fri, Mar 28, 8:45 PM

	F15441217: D17185.diff
	Wed, Mar 26, 4:57 PM

	F15413035: D17185.diff
	Wed, Mar 19, 4:34 PM

	F15384232: D17185.id41326.diff
	Fri, Mar 14, 7:13 PM

	F15294035: D17185.id41326.diff
	Mar 5 2025, 6:06 AM

	Unknown Object (File)
	Feb 23 2025, 9:47 AM

	Unknown Object (File)
	Feb 21 2025, 3:03 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T7504: Manually added auditors doesn't change commit audit status

Commits

rPc05cb1ba6ddd: Make "Audit Requested" put commits into the "Needs Audit" state

Summary

Fixes T7504. I think that task legitimately describes a bug and that the current behavior is counterintuitive.

Test Plan

Manually added an auditor to a commit with none; saw it become "Audit Required" as an overall state.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 11 2017, 10:53 PM

Harbormaster completed remote builds in B15213: Diff 41326.Jan 11 2017, 10:53 PM

Harbormaster completed remote builds in B15213: Diff 41326.

chad accepted this revision.Jan 11 2017, 10:58 PM

This revision is now accepted and ready to land.Jan 11 2017, 10:58 PM

Closed by commit rPc05cb1ba6ddd: Make "Audit Requested" put commits into the "Needs Audit" state (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2017, 10:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepositoryCommit.php

1 line

Diff 41328

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Make "Audit Requested" put commits into the "Needs Audit" stateClosedPublicActions