Page MenuHomePhabricator
Differential D17181

Allow auditors to be added and removed from commits in a modern way
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 7:23 PM.
Tags
None
Referenced Files
F18843992: D17181.id41321.diff
Wed, Oct 29, 2:27 AM
F18843095: D17181.diff
Tue, Oct 28, 8:58 PM
F18836613: D17181.id.diff
Mon, Oct 27, 2:50 AM
F18836062: D17181.diff
Sun, Oct 26, 9:29 PM
F18835194: D17181.diff
Sun, Oct 26, 2:06 PM
F18784363: D17181.id41317.diff
Mon, Oct 13, 12:23 PM
F18784361: D17181.id41321.diff
Mon, Oct 13, 12:23 PM
F18784360: D17181.id.diff
Mon, Oct 13, 12:23 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7676: Packages that are configured to auto-audit often generate audits that are un-closable
T10978: Modernize Audit
Commits
rP255e3fb1e4bf: Allow auditors to be added and removed from commits in a modern way
Summary

Ref T10978. Ref T7676. Make auditors work more like reviewers, so they can be freely added or removed.

Test Plan
  • Interacted with auditors via "Edit Commit" and API.
  • Comment area is still oldschool and doesn't work yet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
6 lines
applications/
audit/
storage/
6 lines
diffusion/
editor/
19 lines
xaction/
231 lines
4 lines
repository/
storage/
5 lines

Diff 41321

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

Loading...
View Options

src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php

Loading...
View Options

src/applications/diffusion/xaction/DiffusionCommitTransactionType.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
Phabricator · Built by Phacility