Differential D17181

Allow auditors to be added and removed from commits in a modern way
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 7:23 PM.

Details

Reviewers

chad

Maniphest Tasks

T7676: Packages that are configured to auto-audit often generate audits that are un-closable
T10978: Modernize Audit

Commits

rP255e3fb1e4bf: Allow auditors to be added and removed from commits in a modern way

Summary

Ref T10978. Ref T7676. Make auditors work more like reviewers, so they can be freely added or removed.

Test Plan

Interacted with auditors via "Edit Commit" and API.
Comment area is still oldschool and doesn't work yet.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 11 2017, 7:23 PM

Harbormaster completed remote builds in B15204: Diff 41317.Jan 11 2017, 7:24 PM

epriestley mentioned this in T7676: Packages that are configured to auto-audit often generate audits that are un-closable.Jan 11 2017, 7:29 PM

chad accepted this revision.Jan 11 2017, 8:21 PM

This revision is now accepted and ready to land.Jan 11 2017, 8:21 PM

Closed by commit rP255e3fb1e4bf: Allow auditors to be added and removed from commits in a modern way (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2017, 9:56 PM

This revision was automatically updated to reflect the committed changes.

alexmv mentioned this in T12406: Importing commits which name themselves as the auditor can cause stuck tasks.Mar 16 2017, 4:03 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

audit/

storage/

PhabricatorAuditTransaction.php

6 lines

diffusion/

editor/

DiffusionCommitEditEngine.php

19 lines

xaction/

DiffusionCommitAuditorsTransaction.php

231 lines

DiffusionCommitTransactionType.php

4 lines

repository/

storage/

PhabricatorRepositoryCommit.php

5 lines

Diff 41321

View Options

src/__phutil_library_map__.php

View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

View Options

src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php

View Options

src/applications/diffusion/xaction/DiffusionCommitTransactionType.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Allow auditors to be added and removed from commits in a modern wayClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41321

src/__phutil_library_map__.php

src/applications/audit/storage/PhabricatorAuditTransaction.php

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php

src/applications/diffusion/xaction/DiffusionCommitTransactionType.php

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Allow auditors to be added and removed from commits in a modern way
ClosedPublic
Actions

Revision Contents
Changeset List