HomePhabricator

Order inline comments in Diffusion consistently with Differential

Description

Order inline comments in Diffusion consistently with Differential

Summary:
Fixes T8739. Currently, Diffusion inline comments in the timeline are sorted arbitrarily, mostly by creation order.

Instead, sort them by line number, like Differential.

Test Plan:
Made comments in "C", "B", "A" order, saw them in line order after submit:

Screen Shot 2017-01-11 at 2.44.08 PM.png (271×504 px, 36 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8739

Differential Revision: https://secure.phabricator.com/D17184

Details

Provenance
epriestleyAuthored on Jan 11 2017, 10:44 PM
epriestleyPushed on Jan 11 2017, 10:57 PM
Reviewer
chad
Differential Revision
D17184: Order inline comments in Diffusion consistently with Differential
Parents
rPb5722a99635a: Use EditEngine stacked comments in Diffusion
Branches
Unknown
Tags
Unknown
Tasks
T8739: Inline comments not sorted
Build Status
Buildable 15214
Build 19996: Run Core Tests