Differential D17183

Use EditEngine stacked comments in Diffusion
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 10:27 PM.

Details

Reviewers

chad

Maniphest Tasks

T8739: Inline comments not sorted
T10446: Unable to simply mark a Diffusion comment as Done
T10978: Modernize Audit

Commits

rPb5722a99635a: Use EditEngine stacked comments in Diffusion

Summary

Ref T10978. Ref T8739. Fixes T10446. Converts Diffusion to modern comment/preview code, like Differential.

Test Plan

Screen Shot 2017-01-11 at 2.22.49 PM.png (1×1 px, 233 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 11 2017, 10:27 PM

Harbormaster completed remote builds in B15210: Diff 41323.Jan 11 2017, 10:28 PM

epriestley mentioned this in T8739: Inline comments not sorted.Jan 11 2017, 10:34 PM

chad accepted this revision.Jan 11 2017, 10:35 PM

This revision is now accepted and ready to land.Jan 11 2017, 10:35 PM

epriestley mentioned this in T10446: Unable to simply mark a Diffusion comment as Done.Jan 11 2017, 10:46 PM

Closed by commit rPb5722a99635a: Use EditEngine stacked comments in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2017, 10:46 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13631: Support an "auditors" attachment for "diffusion.commit.search".Mar 9 2021, 11:50 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

26 lines

packages.php

1 line

src/

__phutil_library_map__.php

4 lines

applications/

audit/

application/

PhabricatorAuditApplication.php

2 lines

controller/

PhabricatorAuditAddCommentController.php

PhabricatorAuditPreviewController.php

editor/

PhabricatorAuditEditor.php

17 lines

storage/

PhabricatorAuditInlineComment.php

7 lines

view/

PhabricatorAuditTransactionView.php

7 lines

differential/

controller/

DifferentialRevisionViewController.php

7 lines

diffusion/

controller/

DiffusionCommitController.php

144 lines

editor/

DiffusionCommitEditEngine.php

87 lines

infrastructure/

diff/

view/

PHUIDiffInlineCommentPreviewListView.php

11 lines

webroot/

rsrc/

js/

application/

differential/

behavior-add-reviewers-and-ccs.js

behavior-keyboard-nav.js

16 lines

Diff 41325

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/audit/application/PhabricatorAuditApplication.php

View Options

src/applications/audit/controller/PhabricatorAuditAddCommentController.php

View Options

src/applications/audit/controller/PhabricatorAuditPreviewController.php

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

View Options

src/applications/audit/view/PhabricatorAuditTransactionView.php

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php

View Options

webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js

View Options

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

Use EditEngine stacked comments in DiffusionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41325

resources/celerity/map.php

resources/celerity/packages.php

src/__phutil_library_map__.php

src/applications/audit/application/PhabricatorAuditApplication.php

src/applications/audit/controller/PhabricatorAuditAddCommentController.php

src/applications/audit/controller/PhabricatorAuditPreviewController.php

src/applications/audit/editor/PhabricatorAuditEditor.php

src/applications/audit/storage/PhabricatorAuditInlineComment.php

src/applications/audit/view/PhabricatorAuditTransactionView.php

src/applications/differential/controller/DifferentialRevisionViewController.php

src/applications/diffusion/controller/DiffusionCommitController.php

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php

webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

Use EditEngine stacked comments in Diffusion
ClosedPublic
Actions

Revision Contents
Changeset List