Diffusion Phabricator b5722a99635a

Use EditEngine stacked comments in Diffusion
b5722a99635a
Actions

Description

Use EditEngine stacked comments in Diffusion

Summary: Ref T10978. Ref T8739. Fixes T10446. Converts Diffusion to modern comment/preview code, like Differential.

Test Plan:

Screen Shot 2017-01-11 at 2.22.49 PM.png (1×1 px, 233 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10978, T10446, T8739

Differential Revision: https://secure.phabricator.com/D17183

Details

Provenance

epriestley	Authored on Jan 11 2017, 10:01 PM
epriestley	Pushed on Jan 11 2017, 10:46 PM

Reviewer

chad

Differential Revision

D17183: Use EditEngine stacked comments in Diffusion

Parents

rP82c891f58663: Add modern "Accept", "Raise Concern" and "Resign" transactions to Audit

Branches

Unknown

Tags

Unknown

Tasks

T8739: Inline comments not sorted
T10446: Unable to simply mark a Diffusion comment as Done
T10978: Modernize Audit

Build Status

Buildable 15212
Build 19993: Run Core Tests

Event Timeline

epriestley committed rPb5722a99635a: Use EditEngine stacked comments in Diffusion (authored by epriestley).Jan 11 2017, 10:46 PM

epriestley added a task: T10978: Modernize Audit.

epriestley added a task: T10446: Unable to simply mark a Diffusion comment as Done.

epriestley added a task: T8739: Inline comments not sorted.

Harbormaster completed building B15212: rPb5722a99635a: Use EditEngine stacked comments in Diffusion.Jan 11 2017, 10:47 PM

Changes (15)

Path

Size

resources/

celerity/

map.php

packages.php

src/

__phutil_library_map__.php

applications/

audit/

application/

PhabricatorAuditApplication.php

controller/

PhabricatorAuditAddCommentController.php

PhabricatorAuditPreviewController.php

editor/

PhabricatorAuditEditor.php

storage/

PhabricatorAuditInlineComment.php

view/

PhabricatorAuditTransactionView.php

differential/

controller/

DifferentialRevisionViewController.php

diffusion/

controller/

DiffusionCommitController.php

editor/

DiffusionCommitEditEngine.php

infrastructure/

diff/

view/

PHUIDiffInlineCommentPreviewListView.php

webroot/

rsrc/

js/

application/

differential/

behavior-add-reviewers-and-ccs.js

behavior-keyboard-nav.js

rPb5722a99635a

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/audit/application/PhabricatorAuditApplication.php

View Options

src/applications/audit/controller/PhabricatorAuditAddCommentController.php

View Options

src/applications/audit/controller/PhabricatorAuditPreviewController.php

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

View Options

src/applications/audit/view/PhabricatorAuditTransactionView.php

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php

View Options

webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js

View Options

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

Use EditEngine stacked comments in Diffusionb5722a99635aActions

Description

Details

Event Timeline

Changes (15)

rPb5722a99635a

resources/celerity/map.php

resources/celerity/packages.php

src/__phutil_library_map__.php

src/applications/audit/application/PhabricatorAuditApplication.php

src/applications/audit/controller/PhabricatorAuditAddCommentController.php

src/applications/audit/controller/PhabricatorAuditPreviewController.php

src/applications/audit/editor/PhabricatorAuditEditor.php

src/applications/audit/storage/PhabricatorAuditInlineComment.php

src/applications/audit/view/PhabricatorAuditTransactionView.php

src/applications/differential/controller/DifferentialRevisionViewController.php

src/applications/diffusion/controller/DiffusionCommitController.php

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

src/infrastructure/diff/view/PHUIDiffInlineCommentPreviewListView.php

webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

Use EditEngine stacked comments in Diffusion
b5722a99635a
Actions