Page MenuHomePhabricator
Feed Advanced Search

Jan 24 2017

epriestley added a revision to T12152: Adding a task from the workboard with a subproject tag is frozing the UI: Restricted Differential Revision.
Jan 24 2017, 3:31 PM · Bug Report
epriestley added a comment to T12152: Adding a task from the workboard with a subproject tag is frozing the UI.

There's now a grayed out page

Jan 24 2017, 2:59 PM · Bug Report
epriestley added a comment to T12150: Restricting Push not working.

your phutil is 3 weeks older than the rest

Jan 24 2017, 2:39 PM · Bug Report (Needs Information)
epriestley added a comment to T12147: Tag task with a Project and Subproject.

Should I open a new bug?

Jan 24 2017, 2:35 PM · Bug Report
epriestley created T12151: Repository mail silencing rules aren't intuitive if you audit an importing repository.
Jan 24 2017, 2:21 PM · Phacility, Diffusion, Audit

Jan 23 2017

epriestley closed T12149: Provide a toast while actively tracking time as Invalid.

Phrequent is a prototype. We do not accept feature requests for prototypes, see User Guide: Prototype Applications.

Jan 23 2017, 8:17 PM · Maniphest, Feature Request
epriestley closed T12141: Cannot access phabricator when wrong email entered at account creation as Wontfix.

This is exceptionally rare, strictly user error (i.e., avoidable by entering your email address correctly), and administrators can force-verify email addresses with bin/accountadmin which offers one way out of this state.

Jan 23 2017, 6:18 PM · Bug Report
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

This is what I see on my Macbook in Safari:

Jan 23 2017, 5:57 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Emoji look terrible on nearly every platform / browser

Jan 23 2017, 5:41 PM · Remarkup, PHUI
epriestley merged T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file into T8170: Diffusion -> show raw file doesn't always render text.
Jan 23 2017, 5:16 PM · Diffusion
epriestley merged task T12148: "View Raw File" in Diffusion no longer takes you to the raw output of the file into T8170: Diffusion -> show raw file doesn't always render text.
Jan 23 2017, 5:16 PM · Diffusion, Bug Report
epriestley added a comment to T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded.

I think it's useful to keep track of bugs which impact customers

Jan 23 2017, 3:13 PM · Inline Comments, Customer Impact, Differential
epriestley added a comment to T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded.

I tagged this with Phacility because a Phacility customer was the original reporter. I think it's useful to keep track of bugs which impact customers, but maybe I should make a different tag?

Jan 23 2017, 3:12 PM · Inline Comments, Customer Impact, Differential
epriestley closed T12146: Adding multiple Tags on a Diffusion Repository leads to a 404 as Invalid.

I can't reproduce this. It's possible that you actually experienced T11165 and misremembered exactly what you'd done, or performed one edit in a tab with the other tab open.

Jan 23 2017, 3:10 PM · Diffusion, Bug Report
epriestley closed T12147: Tag task with a Project and Subproject as Invalid.

This is by design, and explained in the documentation.

Jan 23 2017, 3:08 PM · Bug Report
joshuaspence added a comment to T12144: Ability to reorder milestones on a project's workboard.
In T12144#208351, @chad wrote:

I'd rather fix the core problem if it's an unclear typeahead.

Jan 23 2017, 1:16 AM · Projects, Feature Request

Jan 22 2017

joshuaspence added a comment to T12144: Ability to reorder milestones on a project's workboard.

My understanding is that subprojects are basically just regular projects but with a parent relationship. We didn't want these projects to pollute the projects typeahead because no-one should be creating tasks within these subprojects (given that these subprojects dictate what we are working on). By choosing "milestone" instead of "subproject", it becomes clearer in the project typeahead that the subproject is internal to the parent project. That is, if we made #our_january_goal a subproject then it would show up in the projects typeahead as "Our January Goal" whereas as a milestone it is rendered as "Our Team (Our January Goal)".

Jan 22 2017, 11:45 PM · Projects, Feature Request
epriestley added a comment to T12144: Ability to reorder milestones on a project's workboard.

If the milestones aren't strictly ordered, why did the user create milestones instead of subprojects?

Jan 22 2017, 11:31 PM · Projects, Feature Request
joshuaspence created T12144: Ability to reorder milestones on a project's workboard.
Jan 22 2017, 11:10 PM · Projects, Feature Request
dmgarcia awarded T12101: Phabricator PHP 7 Compatibility a Yellow Medal token.
Jan 22 2017, 7:35 PM · Infrastructure, Guides
chad awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 22 2017, 7:26 PM · Prioritized, Restricted Project, Infrastructure
dmgarcia awarded T9640: Make Phabricator compatible with PHP7 a Yellow Medal token.
Jan 22 2017, 7:20 PM · Prioritized, Restricted Project, Infrastructure
dmgarcia awarded T9640: Make Phabricator compatible with PHP7 a Orange Medal token.
Jan 22 2017, 7:20 PM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.

I deployed this to the Phacility production cluster.

Jan 22 2017, 7:03 PM · Bug Report
epriestley merged T12143: "Create Workboard" action fails when "Make Default" checkbox checked into T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.
Jan 22 2017, 7:01 PM · Bug Report
epriestley merged task T12143: "Create Workboard" action fails when "Make Default" checkbox checked into T12142: PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard.
Jan 22 2017, 7:01 PM · Bug Report
epriestley added a comment to T12143: "Create Workboard" action fails when "Make Default" checkbox checked.

I'm going to merge this into T12142 since that one has an earlier timestamp even though this one is more pure of heart.

Jan 22 2017, 7:01 PM · Bug Report

Jan 21 2017

epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think the pros and cons are something like:

Jan 21 2017, 7:29 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think we should just use actual emoji for this, not sprite sheets?

Jan 21 2017, 7:07 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

tarnation

Jan 21 2017, 7:05 PM · Remarkup, PHUI
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

I deployed that change here (secure.phabricator.com). I'll cherry-pick it and deploy it on admin in a little bit, if nothing catches on explosion fire.

Jan 21 2017, 4:54 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

Haha, no worries. Uninstalling Home is pretty unusual.

Jan 21 2017, 4:49 PM · Phacility, Ops, Applications
epriestley added a revision to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log: Unknown Object (Differential Revision).
Jan 21 2017, 4:32 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

After purging dead instances, db003 and db004 are each <25% utilized on their data volumes.

Jan 21 2017, 3:57 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

Purging db001 brought primary volume down to 79.2%, which is technically below the 80% caution threshold. It doesn't need to be fixed immediately, but the pathway forward isn't terribly clear. Some options are:

Jan 21 2017, 3:44 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

Instance service windows on db003 and db004 have synchronized and the shards are now purging.

Jan 21 2017, 3:37 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

The temporary directory storage pressure on repo016 has an unclear root cause (it's related to importing an SVN repository, but I haven't been able to pinpoint where the issue started). The issue no longer appears to be occurring so I'm going to stop digging until it happens again.

Jan 21 2017, 3:37 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

The storage pressure on db001 is primarily because an instance imported a large SVN repository with approximately 60M paths. The instance is a free instance with one user.

Jan 21 2017, 3:08 PM · Phacility, Ops, Applications
epriestley added a project to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log: Phacility.
Jan 21 2017, 2:58 PM · Phacility, Ops, Applications
epriestley renamed T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log from When Home is uninstalled, the user menu disappears to When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.
Jan 21 2017, 2:58 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

The db001, db003 and db004 shards have also hit 80% full on their primary volumes. I'm purging dead instances from db001 now. db003 and db004 have never been purged and need to have instance out-of-service dates synchronized first. This is currently underway for db004.

Jan 21 2017, 2:58 PM · Phacility, Ops, Applications
epriestley added a comment to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.

I'm going to move forward with the deploy since this shouldn't impact actual instances, the stuff in this menu isn't super-critical, and workarounds (albeit inconvenient ones) exist to access the items.

Jan 21 2017, 2:34 PM · Phacility, Ops, Applications
epriestley added a project to T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log: Applications.
Jan 21 2017, 2:33 PM · Phacility, Ops, Applications
epriestley created T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log.
Jan 21 2017, 2:30 PM · Phacility, Ops, Applications
epriestley edited the content of Changelog.
Jan 21 2017, 2:12 PM
epriestley created 2017 Week 3 (Late January).
Jan 21 2017, 2:12 PM
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

And if I gave you a precise estimate you could be sneaky and just divide it by $1,500/hr to get the answer without paying for it!

Jan 21 2017, 1:59 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

Obviously, we can't just hand out estimates for free. Converting units and multiplying numbers together takes away valuable time and resources we could be using to develop Phabricator.

Jan 21 2017, 1:53 PM · Bug Report (Needs Information)

Jan 20 2017

epriestley added a comment to T12138: Send-on-Enter and Fullscreen Mode interact destructively.

tarnation

Jan 20 2017, 11:40 PM · Remarkup, Conpherence
epriestley created T12138: Send-on-Enter and Fullscreen Mode interact destructively.
Jan 20 2017, 11:36 PM · Remarkup, Conpherence
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I'd be happy to, see Consulting to move forward.

Jan 20 2017, 11:23 PM · Bug Report (Needs Information)
epriestley added a comment to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.

How do I reproduce unexpected results at the application level (for example, what's something I can search for that doesn't match but should match)?

Jan 20 2017, 11:18 PM · Search, Customer Impact, Bug Report
epriestley added a comment to T11521: Request Review action should clear "accepted older" status.

Yes and no. So: maybe?

Jan 20 2017, 11:12 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T11957: Add MenuEngine to Home.

While I've got you, how do you feel about a diff to:

Jan 20 2017, 7:34 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

(If there's pushback, maybe like a "one-time hacky copy your old global app settings into the menu script that we don't support" sort of thing? But I'd guess users won't feel like this is too painful since the new menu is a lot more flexible/powerful.)

Jan 20 2017, 7:31 PM · Profile Menu Item, Dashboards
epriestley added a comment to T11957: Add MenuEngine to Home.

I think it would potentially be reasonable to not migrate, especially if you do another blog post like the Favorites one to ease migration pain. Global stuff is relatively recent and pretty easy to put back in place, and I think a gentle nudge to configure the menu to work well for your install isn't a bad thing.

Jan 20 2017, 7:29 PM · Profile Menu Item, Dashboards
epriestley added a comment to T12136: What to do with "Application Counts" with MenuItem.

Maybe less complainey now that Audit and Differential have fairly sane default "stuff you should do" bucketed queries which can go on a dashboard? But who knows. I tend to think we should make an effort to toss these and see how much pushback we get. In particular, they're very expensive to build relative to their utility (and no one has complained yet that I nuked the Audit count, although it has only been gone for a little while).

Jan 20 2017, 7:24 PM · Profile Menu Item
epriestley added a revision to T12128: Favorites Menu Errata : Unknown Object (Differential Revision).
Jan 20 2017, 7:16 PM · Profile Menu Item
epriestley closed T12129: Mercurial repository updates cause high CPU usage as Invalid.

Sounds good. I'm going to close this since it doesn't seem to be moving toward becoming a bug report which we can accept upstream.

Jan 20 2017, 6:24 PM · Bug Report (Needs Information)
epriestley renamed T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username from when editing bot account settings, the default values suggest I'm editing my own settings to When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username.
Jan 20 2017, 6:20 PM · User Preferences, Bug Report
epriestley triaged T12135: When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username as Wishlist priority.

There's a TODO about this in the code:

Jan 20 2017, 6:19 PM · User Preferences, Bug Report
cspeckmim awarded T12134: Develop a Nuance-based Phabricator reporting/support flow a Party Time token.
Jan 20 2017, 6:00 PM · Abuse
epriestley merged task T9212: Community Feedback: How should we handle free support? into T12134: Develop a Nuance-based Phabricator reporting/support flow.
Jan 20 2017, 6:00 PM · Public & Media Relations, Support
epriestley merged T9212: Community Feedback: How should we handle free support? into T12134: Develop a Nuance-based Phabricator reporting/support flow.
Jan 20 2017, 6:00 PM · Abuse
epriestley added a comment to T9212: Community Feedback: How should we handle free support?.

I'm going to merge this into T12134, which begins defining a more concrete plan roughly following some of the outline above. The major change from an upstream perspective since this task was filed is that we have a more specific set of harder technical requirements around support for Phacility SAAS instances (particularly after the launch of free instances), so it makes more sense to let those requirements drive product design and then accommodate general free support under that umbrella. Broadly, I expect to move support (bug reports, feature requests) into Nuance and continue reducing user access to the upstream.

Jan 20 2017, 6:00 PM · Public & Media Relations, Support
epriestley created T12134: Develop a Nuance-based Phabricator reporting/support flow.
Jan 20 2017, 5:32 PM · Abuse
epriestley added a revision to T12131: Edit History inserts itself wherever it feels like: Unknown Object (Differential Revision).
Jan 20 2017, 3:40 PM · Bug Report
• Ondrej awarded T2393: Adds a "Needs Verification" state to Audits a Like token.
Jan 20 2017, 3:38 PM · Restricted Project, Audit
epriestley added a comment to T12133: Manually Closing Revisions not possible in Audit.

(This change was half-accidental, and then I just figured I'd roll it into T2393 when I realized I'd made it.)

Jan 20 2017, 3:30 PM · Bug Report
epriestley merged T12133: Manually Closing Revisions not possible in Audit into T2393: Adds a "Needs Verification" state to Audits.
Jan 20 2017, 3:30 PM · Restricted Project, Audit
epriestley merged task T12133: Manually Closing Revisions not possible in Audit into T2393: Adds a "Needs Verification" state to Audits.
Jan 20 2017, 3:29 PM · Bug Report
epriestley added a comment to T12133: Manually Closing Revisions not possible in Audit.

This did actually change in connection with T10978, but only if audit.can-author-close-audit is configured. I plan to resolve T2393 (maybe today?) and hopefully get rid of "Close" and this option entirely. I'm just going to merge this there.

Jan 20 2017, 3:29 PM · Bug Report
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I'd be happy to work with you one-on-one to help troubleshoot issues in your environment, but we can't offer that kind of support for free. This process almost always takes up a large amount of our time and very rarely uncovers any real bugs in Phabricator or helps anyone except the single user experiencing a configuration problem. See Support Resources for more discussion of the kinds of free and paid support we offer. If you'd like to move forward with one-on-one configuration and environment support, see Consulting.

Jan 20 2017, 12:51 PM · Bug Report (Needs Information)

Jan 19 2017

epriestley edited projects for T12129: Mercurial repository updates cause high CPU usage, added: Bug Report (Needs Information); removed Bug Report.
Jan 19 2017, 11:58 PM · Bug Report (Needs Information)
epriestley awarded Image Macro "tarnation" a Pterodactyl token.
Jan 19 2017, 11:57 PM
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

I am unable to reproduce the issue you described by following the steps provided. To move forward:

Jan 19 2017, 10:06 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

Here's what I did to try to reproduce this:

Jan 19 2017, 10:04 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

(A synthetic repository which you create by running hg commit in a loop, or instructions which allow us to build such a synthetic repository, are also fine.)

Jan 19 2017, 8:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

An existing, open source project is perfectly fine, provided you first verify that it reproduces the problem.

Jan 19 2017, 8:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12129: Mercurial repository updates cause high CPU usage.

We need specific reproduction steps to move forward, and "a repository with about 2800 commits" isn't sufficiently specific.

Jan 19 2017, 8:35 PM · Bug Report (Needs Information)
epriestley closed T6024: Display (post-push) audit-state in Diffusion commit-list as Resolved by committing Restricted Diffusion Commit.
Jan 19 2017, 7:43 PM · Restricted Project, Audit, Diffusion
epriestley moved T6507: Audit inline comments doesn't account for synthetic authors from Inlines to Future on the Audit board.
Jan 19 2017, 7:32 PM · Audit
epriestley added a comment to T12127: Allow EditEngine forms to have custom icons.

This is easy but I think you want to get rid of all the IconSet stuff and just let everything have any icon?

Jan 19 2017, 7:32 PM · Dashboards, EditEngine
epriestley added a comment to T6507: Audit inline comments doesn't account for synthetic authors.

This report is probably correct and the remedy is likely also correct, but getting lint into Diffusion is completely in shambles so I'm actually not immediately sure how to reproduce it, at least in a reasonable / moderately-convenient way.

Jan 19 2017, 7:31 PM · Audit
epriestley added a revision to T11096: Redesign main header / quick create / search: Unknown Object (Differential Revision).
Jan 19 2017, 7:11 PM · Design
epriestley added a comment to T11096: Redesign main header / quick create / search.

Not intentional -- @chad, I can figure out what's going on there since it might reasonably be me and I have a local repro.

Jan 19 2017, 7:00 PM · Design
epriestley awarded T5867: Move Quick Create to MenuItemEngine a Party Time token.
Jan 19 2017, 6:54 PM · Design
epriestley added a revision to T6024: Display (post-push) audit-state in Diffusion commit-list: Unknown Object (Differential Revision).
Jan 19 2017, 6:53 PM · Restricted Project, Audit, Diffusion
epriestley added a revision to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only: Unknown Object (Differential Revision).
Jan 19 2017, 6:53 PM · Diffusion, Audit, Feature Request
epriestley moved T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only from Backlog to Future on the Audit board.
Jan 19 2017, 4:52 PM · Diffusion, Audit, Feature Request
epriestley renamed T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only from Audits of true merge commits may present duplicate changes in potentially large audit requests to Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only.
Jan 19 2017, 4:52 PM · Diffusion, Audit, Feature Request
epriestley edited projects for T12098: Create Revision from FavoritesMenuItem doesn't work, added: Differential; removed Diffusion.
Jan 19 2017, 4:46 PM · Dashboards, Differential
azurasean awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Jan 19 2017, 10:30 AM · Workboards (v3), Restricted Project

Jan 18 2017

epriestley closed T12122: Cannot login to Phabricator as Resolved.
Jan 18 2017, 10:59 PM · Bug Report
epriestley added a comment to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only.

I think the big trick on this is going to be making inline comments work somewhat-correctly in the extreme case of octopus merges.

Jan 18 2017, 10:48 PM · Diffusion, Audit, Feature Request
epriestley added a comment to T12122: Cannot login to Phabricator.

Does upgrading past b21cd24341c6552a3fbd21305ca682a161129a6b resolve it?

Jan 18 2017, 10:43 PM · Bug Report
epriestley added projects to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only: Audit, Diffusion.
Jan 18 2017, 9:47 PM · Diffusion, Audit, Feature Request
cburroughs awarded T5889: Allow herald rules to act on existence of auditors a Mountain of Wealth token.
Jan 18 2017, 9:47 PM · Restricted Project, Audit, Herald
epriestley added a comment to T12121: Allow users to view changes in merge commits relative to any ancestor, or as conflict resolutions only.

As an adversarial actor, I can use the proposed rule to avoid audit of dangerous changes like this:

Jan 18 2017, 9:37 PM · Diffusion, Audit, Feature Request
epriestley closed T3917: Avoid or easily handle 'duplicate' audits as Resolved.

My merge of T6557 here was questionable, but I think this is a case where the audits are basically correct and the remedy is better cleanup tools.

Jan 18 2017, 9:12 PM · Restricted Project, Audit