Page MenuHomePhabricator

When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username
Open, WishlistPublic

Description

repro:

  1. create bot account, let's call it "sweet"
  2. go to Manage -> Edit Settings

expect:
Pronoun setting to offer "sweet updated their profile", or something similar

actual:
Pronoun setting offers "Luka updated their profile"

Event Timeline

epriestley triaged this task as Wishlist priority.Jan 20 2017, 6:19 PM
epriestley added a subscriber: epriestley.

There's a TODO about this in the code:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/settings/setting/PhabricatorPronounSetting.php;98a29f3de90af1b40924934c5fd6b8ee1e15bd32$29-30

The code constructing the control doesn't currently have access to the user being edited (as distinct from the viewer doing the editing), and I believe this is the only setting which would benefit from providing that access.

epriestley renamed this task from when editing bot account settings, the default values suggest I'm editing my own settings to When editing bot account "Pronoun" setting, the example strings use the viewer's username, not the bot's username.Jan 20 2017, 6:20 PM