Page MenuHomePhabricator
Create Task
Maniphest T12142

PhabricatorProjectWorkboardProfileMenuItem::validateTransactions() when creating a new workboard
Closed, ResolvedPublic
Actions

Description

I just upgraded to ab4355cde0f8913b9e12be345f813f5ba7e0e468 (on stable) and ran into an issue.

Here's how I'm able to reproduce it:

  • Create a new project
  • Try to create a new "New Empty Board" for the project

Instead of a new board, I get this error:

>>> UNRECOVERABLE FATAL ERROR <<<

Call to undefined method PhabricatorProjectWorkboardProfileMenuItem::validateTransactions()

/usr/local/phabricator/phabricator/src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php:140

Revisions and Commits

rP Phabricator
D17240rP23c54262caf8 Fix fatal saving menu items without custom validation
D17240rP3749ecaa662b Fix fatal saving menu items without custom validation

Related Objects

Event Timeline

vpetersson created this task.Jan 22 2017, 8:57 AM
dereckson added a subscriber: dereckson.Jan 22 2017, 11:12 AM

I can repro on an instance upgraded at 20d1bb8fdf too. And indeed PhabricatorProjectWorkboardProfileMenuItem or PhabricatorProfileMenuItem classes don't contain a validateTransactions method.

chad added a subscriber: chad.Jan 22 2017, 3:44 PM

Confirmed, we'll have a fix here shortly and probably cherry-pick to stable.

chad added a comment.Jan 22 2017, 3:58 PM

Bisects back to D17235

chad mentioned this in Z1336: General Chat.Jan 22 2017, 4:28 PM
chad added a revision: D17240: Fix fatal saving menu items without custom validation.Jan 22 2017, 4:38 PM
chad closed this task as Resolved by committing rP3749ecaa662b: Fix fatal saving menu items without custom validation.Jan 22 2017, 4:42 PM
chad added a commit: rP3749ecaa662b: Fix fatal saving menu items without custom validation.
chad added a subscriber: epriestley.Jan 22 2017, 4:43 PM

I pushed this out to master and @epriestley will probably cherry-pick it to stable today.

chad added a commit: rP23c54262caf8: Fix fatal saving menu items without custom validation.Jan 22 2017, 6:15 PM
chad added a comment.Jan 22 2017, 6:17 PM

Ok I cherry-picked it, way easier than I expected.

epriestley mentioned this in T12143: "Create Workboard" action fails when "Make Default" checkbox checked.Jan 22 2017, 7:01 PM
epriestley merged a task: T12143: "Create Workboard" action fails when "Make Default" checkbox checked.
epriestley added a subscriber: janitorial.

I deployed this to the Phacility production cluster.

vpetersson added a comment.Jan 22 2017, 10:05 PM

Awesome guys. I can confirm that this resolved the issue.

Phabricator · Built by Phacility