Maybe I'll put it on A, I guess ("Toggle All"), so it's sort of near q, which is similar (collapse/expand).

Toggle each individual comment's visibility to the opposite but only if it's not for the current diff~

If it's a toggle, what do you expect us to do if you press it with some inlines hidden and others visible?

Is there opportunity for a hotkey to hide/show all inline comments? Or since it's accessible from the topbar is the intent not to add hotkeys?

+1 for not adding undo behaviour. I too avoid yellow undo bars by saving empty comments. Alternatively, I guess, you could put a "Permanently delete" link in the undo bar so with one extra click you could whisk it away (which actually would be easier than going through the edit, empty, save dance).

Well, I'm half mistaken. What you're seeing is a bug.

(Oh, no, I'm mistaken.)

Removing the text and re-saving the inline comment is supposed to enable an Undo? Hmm..

That's supposed to leave an "Undo" bar, still want us to fix the bug?

(I can reproduce on this install)

I think I found a minor bug. If I'm fairly confident that I want to remove my draft inline comment I'll Edit → Delete Text → Save rather than just Trash - I think just so I don't end up with that yellow box that asks if I want to Undo.

This might not be totally related but

1. I really love being able to see the filename while scrolling through files
2. It would be useful to have something similar to Diffusion's File Search on a Differential revision, to quickly jump to files based on name. The f sidebar helps a little but it's organized in a file-system layout which means the folder location needs to be known.

Thanks! We've deployed this and are soliciting select feedback. Will get back to you shortly.

This has landed for anyone who wants to provide feedback on the v0 version.

In D18112 I've marked 3 items as done (unsubmitted), but the header bar is still white, my expectation is it turns yellow.

Not exactly related, but these cancel buttons used to be grey and are now blue:

Alrighty, I'll take a look at it. 💯

Mock above rebased on master and apparently working:

Let me see if I can dig up my hack-branch above and hand you a skeleton for it.

Yeah, this is relatively simple if it's on a separate page, and can be built in 20 minutes if there's no sorting or "Hide Done".

To step back slightly, one problem we know users have, which is motivating at least some of this request, is "90 spelling corrections". T8909 has a specific example of that, and T8909#224085 alludes to a flavor of this ("90 style corrections") elsewhere. I don't think this is a problem that users "should" have, but I suspect it's responsible for between, like, 50% and 85% of this request (maybe I'm way off, but I'd bet dollars to donuts that it's more than 2%), since it's the case where managing inlines is most overwhelming. And human reviewers are somehow often unable to resist making 90 inlines about style/spelling corrections, even when everyone is worse off for it.

I do think this is something I would have used in the past when faced with ensuring I've addressed all feedback for multiple designers. So in some part, I feel I understand the core problem users are looking for. I don't think we can fix abuses like the 90 comments on spelling errors, so that's not something I feel I need to consider in this design. I just want to make sure I haven't missed anything as an author, or that as a reviewer, all my comments have been satisfactorily addressed. There could be something to explore in that second directive, but we haven't seen a lot of issues in that area, so I'm not really concerned if this is the best solution for that. Wanting a view of only inline comments and the ability to reply isn't something I want, as I feel Differential already does that.

I suspect that isn't what very many users want (I'd guess like ~10%, not ~98%?) -- or, at least, doesn't really solve whatever problems they're running into. For example, I think the "90 spelling corrections" diff in T8909 wouldn't benefit much from this (it doesn't help you go through 90 spelling corrections or 90 lint style fixes), and it's the opposite of the request in T5654, which sounds very similar to this to me. But maybe T5654 is really just "our users like GitHub, so make it look similar to GitHub so it's more familiar", I'm not really sure.

Alrighty, took at pass at this I think isn't too much work, and is probably 98% of what people want. Specifically tried to look at the following scenarios:

This is now available in HEAD. See M1476 for a mock. The actual feature doesn't quite look like that yet since the buttons use generic styles, but should soon (see also T12688).

The objectives UI wasn't solving any specific problem or really motivated by any particular request, I largely just wanted to try it out and see if it made it a little easier to navigate diffs in general. I think at least some of the feedback in the vein of T8250 is roughly "it's hard to see the big picture when changes have a lot of comments", and it seemed worth trying to see if we could make the big picture a little more clear without splitting the UI apart completely. Some (most?) IDEs have similar features, where either things like functions/classes, or lint warnings, or compile errors, are marked in the scrollbar or a small view of the file is shown:

Is there a pre-cursor to D17955 I should read up on? Or was T8250 the main impetus?

I could go either way. At least 0/2 feels bad since it then gives the impression we think you should be marking stuff done. Let's just kill the 0/2 case. Only show / if 1 is marked done and see how that feels. I can clean up the UI before cut too.

If you haven't checked anything and are the author (i.e., today, button is visible and says "0 / 2"), clicking it takes you to the first inline. That's at least a plausibly useful behavior?

I probably should spend more time thinking about this UI, or maybe I should have taken more notes when I designed it.

"3 Unsubmitted" is the three synthetic lint about "TODO"s in the code (see T12806).

On D18102 I see other people's unsaved comments, I think. I also expect 0/2 to only be visible to the whoever can mark stuff done. Otherwise maybe just 2 or nothing?

Comments are fine.

Clicking "Cancel" after starting an inline comment leaves "0/1 Comments" in header. (do you want tasks or comments for these issues?)

In T1026#224714, @epriestley wrote:

I currently expect to revert this change and decline to implement the feature because it makes using Differential on a phone more difficult for left-handed users

You can leave comments on the left hand side of a 2-up view -- that is, scrolling in EITHER of these areas on 2-up would trigger the problem:

We could change the behavior to "tap and hold to begin a range + drag".

Unless they have some seriously alien hands and an predilection to scroll in the middle of the screen

In T12733#224703, @epriestley wrote:

As such, I think it's reasonable to expect Differential to serve a more shallow role on small devices, more akin to "keeping abreast of changes" than "performing detailed review", and reasonable to not try to support every review feature on mobile, since these devices are secondary/support devices until everyone gets really excited about coding on the go using their thumbs, a virtual keyboard, and a tiny screen.

I currently expect to revert this change and decline to implement the feature because it makes using Differential on a phone more difficult for left-handed users (scrolling and leaving comments on a line range become conflated). See T12733#224703 for detailed discussion. If you'd like to champion this feature, let us know in the next 7 seconds.

I'd be fine removing the range select on mobile.

I understand why the behavior has changed, and I'm not particularly opposed to keeping it as-is. I can easily reach over the line number - it's just that it initially appeared as a regression so I had to note it here.

This is an intentional change to address T1026 (allowing inline ranges to be added via touchscreen devices). Previously, it wasn't possible to comment on a range of lines on, e.g., an iPhone/iPad.

On mobile I very quickly get an inline comment box when scrolling which then takes focus so scrolling is aborted.

Synthetic comments (made by lint) are currently shown in the sidebar annotation with a pencil ( ) icon.

• The persistent header should now select more intuitive changesets.
• The scrollbar annotation is now disabled for trackpad "aesthetic" scrollbars (like the 0-width scrollbar on OSX if you don't have a mouse connected to your laptop). If we retain the element, I plan to enable it eventually, it just requires us to move content around and generally make a larger change.
• The scrollbar annotation is now disabled unless phabricator.show-prototypes is enabled.
• The scrollbar annotation should generally work better and be more useful now.
• I've deployed these changes to this host.

This is pretty awesome improvement! Small feedback, the new scrollbar area is a bit hard to use on Safari with Apple's disappearing/reappearing scrollbars. They end up overlapping and it can make the Phabricator scrollbar area harder to use/click on etc. Would be nice if the scrollbar area shifted left while scrolling or if it were on the left side of the screen or some other magical solution.

I'll tweak the logic, I agree that, e.g., "index.js" should be displayed in your first screenshot (and probably whatever's above it if you scrolled up just a little bit more).

• persistent header element is a great idea
• scrollbar annotations are very helpful

For me it would be a great enhancement if there would be a shortcut which temporarily toggles this option:
Settings → Personal Settings → APPLICATIONS → Diff Preferences → Show Older Inlines

I do think "Quote" needs to be somewhere (it wasn't listed at all in T11401#224171, though you mentioned it). Shift-click on reply could also be supported, but such a power user feature is far less important than an easily discoverable function. I believe that I personally would use "Quote" more often than "Edit", but honestly would be happy wherever this were put. I'll probably upgrade my Phab instance and start using the "R" shortcut next week either way.

I'll try to figure out more details/reproducibility for tomorrow, but through some combination of J+h+@ the highlight reticle will jump somewhere in the timeline

you take your made-up ghost bugs and go sit in the corner and think about what you've done

Err yea I didn't mean feedback as in "this is what I'd like to see" but more of bug reports. I did come across a bug but it's neither earth-shattering nor consistently reproducible.

Yeah, give us a bit longer for general feedback -- I think I'll file a feedback task tomorrow with the release cut.

We haven't started the new features yet

Is this open for test/feedback (I think it's usually called "Errata" here)?

I eventually muddled though things, and I believe work here has now substantially concluded.

I'm also toying with the idea of "Shift+Click" on "Reply" to "Reply-with-Quote" but the only way to discover that would be to read the documentation.

(I normally think of myself as like a 95th percentile power user, and don't use keyboard shortcuts at all in Differential today, and suspect I still won't after these changes. However, I'm also an elite mouse power user, per J769.)

If nothing changes, I was thinking of leaving these top-level:

That is, we show the keyboard shortcut on the dropdown along with the action.