Page MenuHomePhabricator

Fix a diff objective issue where objectives could appear in the wrong place
ClosedPublic

Authored by epriestley on May 20 2017, 12:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:47 AM
Unknown Object (File)
Fri, Apr 19, 6:31 PM
Unknown Object (File)
Sat, Apr 13, 7:04 PM
Unknown Object (File)
Sat, Apr 13, 5:17 PM
Unknown Object (File)
Sat, Apr 13, 3:48 PM
Unknown Object (File)
Sat, Apr 13, 3:33 PM
Unknown Object (File)
Sat, Apr 13, 3:33 PM
Unknown Object (File)
Sat, Apr 13, 2:33 PM
Subscribers
None

Details

Summary

Ref T12733. When creating a new comment, the objective could appear to far up in the scrollbar because we were anchoring it to an invisible row.

Instead, anchor to the "edit" row while editing.

Test Plan

Created a new comment at the very top of a file, saw "File, Star" icons instead of "Star, File".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable