Page MenuHomePhabricator

Fix a diff objective issue where objectives could appear in the wrong place
ClosedPublic

Authored by epriestley on May 20 2017, 12:28 PM.
Tags
None
Referenced Files
F18784810: D17978.id43248.diff
Mon, Oct 13, 3:18 PM
F18767804: D17978.id43235.diff
Wed, Oct 8, 12:24 AM
F18748258: D17978.id.diff
Fri, Oct 3, 8:11 PM
F18747924: D17978.id.diff
Fri, Oct 3, 6:14 PM
F18747559: D17978.id.diff
Fri, Oct 3, 4:41 PM
F18741031: D17978.diff
Thu, Oct 2, 7:38 AM
F18623031: D17978.diff
Sep 15 2025, 1:59 PM
F18508839: D17978.id.diff
Sep 5 2025, 3:03 AM
Subscribers
None

Details

Summary

Ref T12733. When creating a new comment, the objective could appear to far up in the scrollbar because we were anchoring it to an invisible row.

Instead, anchor to the "edit" row while editing.

Test Plan

Created a new comment at the very top of a file, saw "File, Star" icons instead of "Star, File".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable