Page MenuHomePhabricator

Fix a diff objective issue where objectives could appear in the wrong place
ClosedPublic

Authored by epriestley on May 20 2017, 12:28 PM.
Tags
None
Referenced Files
F18104185: D17978.id43235.diff
Sun, Aug 10, 10:27 AM
F18072515: D17978.id.diff
Mon, Aug 4, 4:57 PM
F18047279: D17978.diff
Sun, Aug 3, 11:37 AM
F17689941: D17978.diff
Jul 14 2025, 2:45 PM
Unknown Object (File)
Jun 3 2025, 2:58 AM
Unknown Object (File)
Jun 1 2025, 7:36 AM
Unknown Object (File)
May 8 2025, 7:36 AM
Unknown Object (File)
Apr 24 2025, 6:47 PM
Subscribers
None

Details

Summary

Ref T12733. When creating a new comment, the objective could appear to far up in the scrollbar because we were anchoring it to an invisible row.

Instead, anchor to the "edit" row while editing.

Test Plan

Created a new comment at the very top of a file, saw "File, Star" icons instead of "Star, File".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable