Page MenuHomePhabricator

Hide the Differential scroll objective list on trackpad systems
ClosedPublic

Authored by epriestley on May 20 2017, 11:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:30 PM
Unknown Object (File)
Tue, Apr 16, 1:26 AM
Unknown Object (File)
Sat, Apr 13, 7:58 PM
Unknown Object (File)
Sat, Apr 13, 5:47 PM
Unknown Object (File)
Sat, Apr 13, 10:44 AM
Unknown Object (File)
Sat, Apr 13, 9:38 AM
Unknown Object (File)
Sat, Apr 13, 9:08 AM
Unknown Object (File)
Sat, Apr 13, 7:17 AM
Subscribers
None

Details

Summary

Ref T12733. In the longer run I'd like to just push this out from the edge, but that currently gets us into trouble since we start bumping into content. On my system, the trackpad scrollbar also expands in size when moused over, so the minimum number of pixels we need to push it out is approximatley 15px. This hits body content and the persistent chat.

For now, just disable this element on trackpad systems.

Test Plan

Disconnected all USB peripherals, quit and relaunched Safari, saw no objective list.

Reconnected mouse, relaunched Safari, saw objective list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 20 2017, 1:51 PM
This revision was automatically updated to reflect the committed changes.