Paths

Table of Contentst

Add PHUIXButtonView and a UIExample
ClosedPublic
Actions

Authored by epriestley on May 31 2017, 12:10 AM.

Tags

None

Referenced Files

	F18740793: D18051.diff
	Thu, Oct 2, 5:53 AM

	F18656349: D18051.diff
	Mon, Sep 22, 10:12 PM

	F18612068: D18051.diff
	Sun, Sep 14, 8:42 AM

	F18577817: D18051.id43412.diff
	Wed, Sep 10, 8:13 PM

	F18577765: D18051.id43412.diff
	Wed, Sep 10, 7:51 PM

	F18534381: D18051.id43412.diff
	Sun, Sep 7, 11:28 AM

	F18508889: D18051.id.diff
	Sep 5 2025, 3:05 AM

	F18501176: D18051.diff
	Sep 4 2025, 9:35 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rP683647f1fb90: Add PHUIXButtonView and a UIExample

Summary

Ref T12733. Ref M1476. This adds PHUIXButtonView, for client-side button rendering.

It also adds a PHUIX example which renders the server and client versions of each component side-by-side so it's easier to see if they're messed up.

Test Plan

Screen Shot 2017-05-30 at 5.05.33 PM.png (1×1 px, 146 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 31 2017, 12:10 AM

tumblr_inline_op017kGTqT1teupc5_540.gif (345×498 px, 2 MB)

This revision is now accepted and ready to land.May 31 2017, 12:29 AM

Closed by commit rP683647f1fb90: Add PHUIXButtonView and a UIExample (authored by epriestley, committed by epriestley). · Explain WhyMay 31 2017, 1:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

13 lines

src/

__phutil_library_map__.php

2 lines

applications/

uiexample/

examples/

PHUIXComponentsExample.php

122 lines

webroot/

rsrc/

js/

phuix/

PHUIXButtonView.js

109 lines

PHUIXExample.js

65 lines

Diff 43422

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/uiexample/examples/PHUIXComponentsExample.php

View Options

webroot/rsrc/js/phuix/PHUIXButtonView.js

View Options

webroot/rsrc/js/phuix/PHUIXExample.js

Add PHUIXButtonView and a UIExampleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43422

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/uiexample/examples/PHUIXComponentsExample.php

webroot/rsrc/js/phuix/PHUIXButtonView.js

webroot/rsrc/js/phuix/PHUIXExample.js

Add PHUIXButtonView and a UIExample
ClosedPublic
Actions

Revision Contents
Changeset List