Page MenuHomePhabricator
Create Task
Maniphest T11509

Provide a way to quickly see if all comments on a diff have been marked as "done"
Closed, ResolvedPublic
Actions

Description

Right now on long diffs, you need to scroll through the content of the diffs in order to check for things that you haven't responded to. On some diffs, this may be dozens of comments accrued over several days.

This is only annoying for particularly large diffs with many comments.

Related Objects

Event Timeline

yelirekim created this task.Aug 22 2016, 5:14 PM
epriestley added a subscriber: epriestley.Aug 22 2016, 6:02 PM

Upstream-wise, T8250 should happen first.

I'm slightly hesitant about positioning reviews as a progress bar that you fill up and then you're done. This isn't as much of an issue with marking inlines "Done" as it is with some other types of changes, but creates some product tension that I want to move slowly on.

eadler added a project: Restricted Project.Aug 23 2016, 4:53 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 23 2016, 4:53 PM
joshuaspence added a project: Differential.Nov 29 2016, 12:31 AM
joshuaspence added a subscriber: joshuaspence.
epriestley added a project: Inline Comments.Jun 8 2017, 11:51 AM
epriestley closed this task as Resolved.Jun 8 2017, 11:54 AM
epriestley claimed this task.

This is now available in HEAD. See M1476 for a mock. The actual feature doesn't quite look like that yet since the buttons use generic styles, but should soon (see also T12688).

Phabricator · Built by Phacility