Differential D17976
For the diff banner, detect the current changeset better Authored by epriestley on May 20 2017, 11:30 AM. Tags None Referenced Files
Subscribers None
Details Ref T12733. Currently, we detect the changeset which is in the middle of the screen as the current changeset. This doesn't always get us the most intuitive changeset, particularly after a navigation from the scroll objective list: when you jump to changeset "X", you'd tend to expect "X" to be shown in the header, but the next changeset may be shown if "X" is too short. Instead, select the changeset near the top of the screen (spanning an invisible line slightly below the banner). Scrolled and jumped through a document with long and short changesets, saw a more intuitive changeset selected by the banner.
Diff Detail
Event TimelineComment Actions Here's an example:  The old code would have shown "changeset-view.css" in the banner. The new code shows "packages.php" in the banner, which I think aligns better with expectation. |