Page MenuHomePhabricator
Create Task
Maniphest T12779

File anchor links can load scrolled to the wrong file
Open, NormalPublic
Actions

Description

The PHUIFeedStoryExample.php link in the table of contents of D18050 links to D18050#5a5324e8. Pasting that link into a new browser page finds the browser pane scrolled to the middle of the PhabricatorFilesComposeAvatarExample.php file -- that is, scrolled too far down:

Screenshot 2017-05-30 16.31.43.png (898×1 px, 223 KB)

This seems to be due to lazy-loading of the file sections. Where the browser pane ends up centered seems to be a function of the height of the browser window; a smaller window finds me earlier, at PHUIHovercardUIExample.php, a taller one at PhabricatorNotificationUIExample.php.

This makes it hard to reference files in a diff out-of-band.

Revisions and Commits

rP Phabricator
D18060rPb66bf6af9267 When stabilizing document scroll position for diffs, stick to anchors harder
D18052rPd161a07781e0 Improve Differential behavior when scrolling with anchors

Related Objects
Search...

Event Timeline

alexmv created this task.May 30 2017, 11:38 PM
Herald added a subscriber: jhurwitz. · View Herald TranscriptMay 30 2017, 11:38 PM
alexmv added a comment.May 30 2017, 11:41 PM

Forgot to specify browser: this is Chrome 58.0.3029.110 (64-bit) on OS X and Linux. Also replicates on Safari 10.1.1 (12603.2.4).

alexmv added a comment.May 30 2017, 11:43 PM

T11997/T12032 look related, but not the same behavior.

epriestley added a subscriber: epriestley.May 31 2017, 12:01 AM

Possibly fallout from T11784 / D17911, although those shouldn't really interact here unless there are other bugs.

epriestley added a parent task: T12733: (2017 Week 20) Inline Comments Errata / Feedback.May 31 2017, 12:04 AM
epriestley added a revision: D18052: Improve Differential behavior when scrolling with anchors.May 31 2017, 12:43 AM
epriestley claimed this task.May 31 2017, 12:43 AM
epriestley triaged this task as Normal priority.
epriestley closed this task as Resolved by committing rPd161a07781e0: Improve Differential behavior when scrolling with anchors.May 31 2017, 12:56 AM
epriestley added a commit: rPd161a07781e0: Improve Differential behavior when scrolling with anchors.
epriestley reopened this task as Open.May 31 2017, 1:07 AM

I think that got things closer but we aren't quite there yet. I'll poke at this a bit more tomorrow.

epriestley added a comment.Jun 1 2017, 12:50 PM

tomorrow

(This is still on my radar.)

epriestley added a revision: D18060: When stabilizing document scroll position for diffs, stick to anchors harder.Jun 1 2017, 7:22 PM
epriestley added a commit: rPb66bf6af9267: When stabilizing document scroll position for diffs, stick to anchors harder.Jun 1 2017, 7:40 PM
epriestley added a comment.Jun 1 2017, 9:15 PM

This is still not working very well for me in Safari in production, although I don't seem to be able to break it in Chrome or Firefox anymore after a few tries.

Obviously, it works flawlessly every time in Safari locally.

alexmv added a comment.Jun 1 2017, 9:35 PM

Thanks for the fixes! Most folks are on Chrome at Dropbox, so Safari being subject to the Heisenprod Uncertainty Principle doesn't worry me much.

cspeckmim added a subscriber: cspeckmim.Aug 23 2017, 9:27 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 23 2017, 9:27 PM
alexmv removed a subscriber: alexmv.Mar 31 2019, 10:14 PM
Phabricator · Built by Phacility