Page MenuHomePhabricator

Consider inline comments with draft checkmarks as "unsubmitted"
ClosedPublic

Authored by epriestley on Jun 15 2017, 11:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 13 2024, 3:50 AM
Unknown Object (File)
Feb 3 2024, 4:13 PM
Unknown Object (File)
Jan 29 2024, 12:20 AM
Unknown Object (File)
Dec 27 2023, 11:29 AM
Unknown Object (File)
Dec 27 2023, 11:29 AM
Unknown Object (File)
Dec 27 2023, 11:29 AM
Unknown Object (File)
Dec 26 2023, 11:28 AM
Unknown Object (File)
Dec 21 2023, 7:38 PM
Subscribers
None

Details

Summary

Ref T12733. When a revision has unsubmitted checkmarks:

  • Color the banner yellow.
  • Show them in the "X unsubmitted" count.
  • Make the "X unsubmitted" button cycle between all drafts (written but unpublished comments) and "draft done" (checked but unsubmitted "Done" checkbox comments).
Test Plan
  • Checked a "Done" box, saw "1 unsubmitted" and yellow banner.
  • Clicked "5 unsubmitted" repeatedly, saw it cycle through all unsubmitted comments and checkboxes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 15 2017, 12:18 PM
This revision was automatically updated to reflect the committed changes.