Page MenuHomePhabricator
Differential D18044

Remove the ability to leave multi-line inline comments on touchscreen devices
ClosedPublic
Actions

Authored by epriestley on May 30 2017, 8:37 PM.
Tags
None
Referenced Files
F15524498: D18044.diff
Mon, Apr 21, 8:26 AM
F15522326: D18044.id.diff
Sun, Apr 20, 7:42 PM
F15518372: D18044.id43399.diff
Sat, Apr 19, 1:04 PM
F15517952: D18044.id43417.diff
Sat, Apr 19, 9:48 AM
F15499912: D18044.diff
Sun, Apr 13, 3:29 PM
F15484198: D18044.id43417.diff
Wed, Apr 9, 5:03 PM
F15483340: D18044.id43399.diff
Wed, Apr 9, 11:52 AM
F15481131: D18044.id.diff
Tue, Apr 8, 6:23 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rPcc0a6fd3aa45: Remove the ability to leave multi-line inline comments on touchscreen devices
Summary

Ref T12733. This ultimately conflicts with scrolling and took about two days to get reported as a bug/regression. See T12733 for a bunch of additional discussion. See T1026 for original discussion.

Test Plan
  • Left single-line and multi-line comments on desktop.
  • Tapped to leave single-line comments on mobile.
  • Dragged lines on mobile, got a scroll instead of a range comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
webroot/
rsrc/
js/
application/
diff/
39 lines

Diff 43417

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
Phabricator · Built by Phacility