Page MenuHomePhabricator
Differential D17975

Stop long filenames in objective list tooltips from being cut off
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 11:21 AM.
Tags
None
Referenced Files
F13180566: D17975.diff
Thu, May 9, 1:01 AM
Unknown Object (File)
Mon, Apr 22, 6:27 PM
Unknown Object (File)
Fri, Apr 19, 6:30 PM
Unknown Object (File)
Apr 13 2024, 6:42 PM
Unknown Object (File)
Apr 13 2024, 2:19 PM
Unknown Object (File)
Apr 13 2024, 1:01 PM
Unknown Object (File)
Apr 13 2024, 10:19 AM
Unknown Object (File)
Apr 13 2024, 6:46 AM
View All 91 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP1bccdd69cb92: (stable) Stop long filenames in objective list tooltips from being cut off
rP8b2a06387dbc: Stop long filenames in objective list tooltips from being cut off
Summary

Ref T12733. Currently, long filenames get cut off at 160px. Instead, don't cut them off.

Test Plan

Before:

Screen Shot 2017-05-20 at 4.17.43 AM.png (121×253 px, 7 KB)

After:

Screen Shot 2017-05-20 at 4.19.03 AM.png (103×332 px, 8 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 20 2017, 11:21 AM
Harbormaster completed remote builds in B17140: Diff 43232.May 20 2017, 11:22 AM
chad accepted this revision.May 20 2017, 2:23 PM
This revision is now accepted and ready to land.May 20 2017, 2:23 PM
Closed by commit rP8b2a06387dbc: Stop long filenames in objective list tooltips from being cut off (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2017, 2:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
38 lines
webroot/
rsrc/
js/
application/
diff/
1 line
core/
6 lines

Diff 43246

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/ScrollObjective.js

Loading...
View Options

webroot/rsrc/js/core/ToolTip.js

Loading...
Phabricator · Built by Phacility