Page MenuHomePhabricator

richardvanvelzen (Richard van Velzen)
Senior developer at Frank

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 3 2012, 11:25 AM (376 w, 1 d)
Availability
Available

Recent Activity

Jun 26 2019

D20622: Correct transaction strengths after inconsitent scaling by 100 vs 1000 is now accepted and ready to land.
Jun 26 2019, 2:17 PM
richardvanvelzen added inline comments to D20540: Stabilize sorting of feed stories with similar strength.
Jun 26 2019, 6:59 AM

Apr 21 2018

richardvanvelzen awarded T13127: Plans: Form Steering Committee For "+/-" Line Indicators a The World Burns token.
Apr 21 2018, 10:45 AM · Design, Differential, Plans

Nov 6 2017

richardvanvelzen edited P2078 arc-unit-sorting.
Nov 6 2017, 12:37 PM

Jun 7 2017

richardvanvelzen added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Thanks - I thought it was already filed but couldn't seem to find it.

Jun 7 2017, 7:24 PM · Diffusion, Design
richardvanvelzen added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

I'd love folder shortcuts (for directories that only contain a single directory). Clicking through a few levels in various Java projects would be slightly more pleasant.

Jun 7 2017, 7:18 PM · Diffusion, Design

May 24 2017

richardvanvelzen added a comment to T12751: Long-lived Conpherence tabs occasionally cause "invalid CSRF token" errors.
May 24 2017, 5:34 PM · Bug Report

May 23 2017

richardvanvelzen added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

I understand why the behavior has changed, and I'm not particularly opposed to keeping it as-is. I can easily reach over the line number - it's just that it initially appeared as a regression so I had to note it here.

May 23 2017, 12:27 PM · Inline Comments, Installing & Upgrading, Differential
richardvanvelzen added a comment to D17819: Make PHPAST parser tests stable and human-readable.

Is there anything I can do to help this move forward?

May 23 2017, 6:55 AM
richardvanvelzen added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

On mobile I very quickly get an inline comment box when scrolling which then takes focus so scrolling is aborted.

May 23 2017, 6:19 AM · Inline Comments, Installing & Upgrading, Differential

May 15 2017

richardvanvelzen added Q614: Does notification server has some ring tone when message pop up? (Answer 544).
May 15 2017, 3:31 AM

May 4 2017

richardvanvelzen updated the language for P2046 D17819-#215382.diff from autodetect to diff.
May 4 2017, 2:40 PM
richardvanvelzen edited P2046 D17819-#215382.diff.
May 4 2017, 2:40 PM
richardvanvelzen added a comment to D17819: Make PHPAST parser tests stable and human-readable.

This looks a lot better already.

This isn't a completely exhaustive representation of the tree (parent nodes could still have the wrong token range and be missed by the tests) but I think it's a reasonable balance of readability and stability.

One possible solution would be to include all tokens (and their types) in the tree as well? E.g.:
<snip>
Granted, this does not make it particularly more readable, but it does solve testing token ranges for nodes.

May 4 2017, 2:15 PM
richardvanvelzen edited P2046 D17819-#215382.diff.
May 4 2017, 2:14 PM
richardvanvelzen added a comment to D17819: Make PHPAST parser tests stable and human-readable.

This looks a lot better already.

May 4 2017, 6:33 AM

May 3 2017

richardvanvelzen added a comment to D17817: Add support for exponentiation.

Because the token values have shifted pretty much all test cases have bad data :(

May 3 2017, 12:30 PM
richardvanvelzen added a comment to D17816: Add support for constant scalar expressions.

Very nice

May 3 2017, 11:45 AM

May 1 2017

richardvanvelzen added a comment to D17802: Add nullable type hint support to xhpast.

Sure, no problem. Let me know if there is something I can do to help

May 1 2017, 5:14 PM
richardvanvelzen updated the summary of D17802: Add nullable type hint support to xhpast.
May 1 2017, 1:43 PM
richardvanvelzen added a comment to D17802: Add nullable type hint support to xhpast.

This does not appear to have any impact on arc/lint.

May 1 2017, 1:43 PM

Apr 28 2017

richardvanvelzen created D17803: (WIP) Add anonymous classes support to xhpast.
Apr 28 2017, 2:10 PM
richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D17803: (WIP) Add anonymous classes support to xhpast.
Apr 28 2017, 2:10 PM · XHPAST
richardvanvelzen updated the diff for D17802: Add nullable type hint support to xhpast.

For real now :(

Apr 28 2017, 8:48 AM
richardvanvelzen updated the diff for D17802: Add nullable type hint support to xhpast.

Remove copy-flag from new unit test (caused by copy-via-IDE)

Apr 28 2017, 8:46 AM
richardvanvelzen added inline comments to D17802: Add nullable type hint support to xhpast.
Apr 28 2017, 8:44 AM
richardvanvelzen created D17802: Add nullable type hint support to xhpast.
Apr 28 2017, 8:43 AM
richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D17802: Add nullable type hint support to xhpast.
Apr 28 2017, 8:43 AM · XHPAST

Feb 7 2017

richardvanvelzen backed I2 Donate to Phacility with $10.00 USD.
Feb 7 2017, 9:08 PM · Phacility

Jan 24 2017

richardvanvelzen awarded D17233: Remove motivator panel a Heartbreak token.
Jan 24 2017, 6:09 PM

Jan 13 2017

richardvanvelzen edited the content of Organizations Using Phabricator.
Jan 13 2017, 3:41 PM
richardvanvelzen edited the content of Organizations Using Phabricator.
Jan 13 2017, 3:41 PM

Dec 13 2016

richardvanvelzen added a comment to T6389: Ship TShirt.

No worries, totally understandable.

Dec 13 2016, 12:17 PM · Public & Media Relations

Jun 17 2016

richardvanvelzen committed rPHU51c179b4c000: Support class const dereferencing in xhpast (authored by richardvanvelzen).
Support class const dereferencing in xhpast
Jun 17 2016, 12:11 PM
richardvanvelzen closed D16138: Support class const dereferencing in xhpast by committing rPHU51c179b4c000: Support class const dereferencing in xhpast.
Jun 17 2016, 12:11 PM
richardvanvelzen retitled D16138: Support class const dereferencing in xhpast from to Support class const dereferencing in xhpast.
Jun 17 2016, 9:53 AM
richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: D16138: Support class const dereferencing in xhpast.
Jun 17 2016, 9:53 AM · XHPAST

Jun 6 2016

richardvanvelzen added a comment to T11100: transaction abort! when push a lot of changes with mercurial.

See https://secure.phabricator.com/T10382. I've mitigated by downgrading to 3.4.2 (some other version will probably work too, this just was the first one I tried)

Jun 6 2016, 12:27 PM · Bug Report
richardvanvelzen added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

For reference, I use this small script to allow myself to easily use arc land with bookmarks:

Jun 6 2016, 11:20 AM · Mercurial, Arcanist

May 26 2016

richardvanvelzen added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

I'm about to start implement full dereferencing support. Cases that are missing now:

($expr)[0];
SomeClass::BRILLIANT_CONSTANT[5];
May 26 2016, 10:13 AM · XHPAST

May 19 2016

richardvanvelzen committed rPHUbd56873ae4c0: Correctly detect new version of xhpast build (authored by richardvanvelzen).
Correctly detect new version of xhpast build
May 19 2016, 2:08 PM
richardvanvelzen closed D15945: Correctly detect new version of xhpast build by committing rPHUbd56873ae4c0: Correctly detect new version of xhpast build.
May 19 2016, 2:08 PM
richardvanvelzen added a comment to D15945: Correctly detect new version of xhpast build.

Not really high-prio, but a minor annoyance after getting a fresh xhpast version.

May 19 2016, 10:53 AM
richardvanvelzen retitled D15945: Correctly detect new version of xhpast build from to Correctly detect new version of xhpast build.
May 19 2016, 10:52 AM
richardvanvelzen committed rPHU4b75e0c34e52: Add coalesce and spaceship operators to xhpast (authored by richardvanvelzen).
Add coalesce and spaceship operators to xhpast
May 19 2016, 9:00 AM
richardvanvelzen closed D15860: Add coalesce and spaceship operators to xhpast by committing rPHU4b75e0c34e52: Add coalesce and spaceship operators to xhpast.
May 19 2016, 9:00 AM

May 18 2016

richardvanvelzen added a comment to D15860: Add coalesce and spaceship operators to xhpast.

This is starting to bite us now - especially the coalesce construct is so useful that people started using it, taking lint syntax errors for granted.

May 18 2016, 4:56 PM

May 16 2016

richardvanvelzen added a comment to T10936: arc feature error while creating a new feature branch.

This is almost definitely T8298, because % can't be properly escaped on Windows right now.

May 16 2016, 10:49 AM · Windows, Arcanist, Bug Report

May 6 2016

richardvanvelzen added a comment to D15862: Revert "Reorder remarkup block rules for consistency with PhabricatorMarkupEngine".

(I'll be away from my machine for the weekend, when accepted it'd be best if you land this since I probably won't be able to)

May 6 2016, 3:15 PM
richardvanvelzen added a comment to D15862: Revert "Reorder remarkup block rules for consistency with PhabricatorMarkupEngine".

I'll create a dedicated PHP 5 vm to use for Phabricator development from now on. I'm not wanting to risk this kind of breakage.

May 6 2016, 3:14 PM
epriestley awarded D15862: Revert "Reorder remarkup block rules for consistency with PhabricatorMarkupEngine" a Doubloon token.
May 6 2016, 3:12 PM
richardvanvelzen retitled D15862: Revert "Reorder remarkup block rules for consistency with PhabricatorMarkupEngine" from to Revert "Reorder remarkup block rules for consistency with PhabricatorMarkupEngine".
May 6 2016, 3:11 PM
richardvanvelzen added a comment to rPHUc0370f2f3c14: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine.

The failed build is due to sort stability having been changed between 5 and 7. I'll send a diff to revert this, since phabricator doesn't support 7 officially. (T9640)

May 6 2016, 3:03 PM
richardvanvelzen added a comment to rPHUc0370f2f3c14: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine.

Sorry, I wasn't exhaustive in my tests. It turns out this fixed behaviour for PHP 7, but broke it on 5. I'm investigating the difference.

May 6 2016, 2:56 PM
richardvanvelzen committed rPHUc0370f2f3c14: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine (authored by richardvanvelzen).
Reorder remarkup block rules for consistency with PhabricatorMarkupEngine
May 6 2016, 2:51 PM
richardvanvelzen closed D15859: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine by committing rPHUc0370f2f3c14: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine.
May 6 2016, 2:51 PM
richardvanvelzen updated the diff for D15860: Add coalesce and spaceship operators to xhpast.

Remove useless %token declaration for T_COALESCE

May 6 2016, 10:20 AM
richardvanvelzen added a comment to D15860: Add coalesce and spaceship operators to xhpast.

On a sidenote, arc unit --everything in arcanist seems totally okay with these changes as well.

May 6 2016, 10:07 AM
richardvanvelzen retitled D15860: Add coalesce and spaceship operators to xhpast from to Add coalesce and spaceship operators to xhpast.
May 6 2016, 10:05 AM
richardvanvelzen retitled D15859: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine from to Reorder remarkup block rules for consistency with PhabricatorMarkupEngine.
May 6 2016, 8:54 AM

May 2 2016

richardvanvelzen committed rPHU0709cd5cfc26: Add unpack support to xhpast (authored by richardvanvelzen).
Add unpack support to xhpast
May 2 2016, 3:17 PM
richardvanvelzen closed D15833: Add unpack support to xhpast by committing rPHU0709cd5cfc26: Add unpack support to xhpast.
May 2 2016, 3:17 PM
richardvanvelzen added inline comments to D15833: Add unpack support to xhpast.
May 2 2016, 3:06 PM
richardvanvelzen retitled D15833: Add unpack support to xhpast from to Add unpack support to xhpast.
May 2 2016, 3:02 PM

Apr 30 2016

monsdar awarded T4139: Add support for desktop notifications a Like token.
Apr 30 2016, 11:28 AM · Aphlict

Apr 29 2016

richardvanvelzen accepted D15820: Regnerate XHPAST with Bison 3.0.4.
Apr 29 2016, 1:46 PM
richardvanvelzen accepted D15819: When running XHPAST unit tests, include the "syntax error" lint rule.
Apr 29 2016, 1:03 PM
richardvanvelzen added a comment to rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format.

Was xhpast rebuilt properly? I can't seem to reproduce that failure locally.

Apr 29 2016, 12:51 PM
richardvanvelzen added a comment to D15678: Add basic support for return type hints to xhpast.

Awesome! I'll follow up with some other features next week. Those should be a lot less tricky.

Apr 29 2016, 12:39 PM
richardvanvelzen committed rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format (authored by richardvanvelzen).
Update xhpast linter rules for new function AST format
Apr 29 2016, 12:38 PM
richardvanvelzen closed D15814: Update xhpast linter rules for new function AST format by committing rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format.
Apr 29 2016, 12:38 PM
richardvanvelzen committed rPHUb20064a108f7: Add basic support for return type hints to xhpast (authored by richardvanvelzen).
Add basic support for return type hints to xhpast
Apr 29 2016, 12:37 PM
richardvanvelzen closed D15678: Add basic support for return type hints to xhpast by committing rPHUb20064a108f7: Add basic support for return type hints to xhpast.
Apr 29 2016, 12:37 PM
richardvanvelzen updated the diff for D15678: Add basic support for return type hints to xhpast.

Add test case

Apr 29 2016, 6:49 AM
richardvanvelzen updated the diff for D15678: Add basic support for return type hints to xhpast.

Add variadic parameter support

Apr 29 2016, 6:46 AM

Apr 28 2016

richardvanvelzen added a comment to D15678: Add basic support for return type hints to xhpast.

Possibly we can squeeze ... into the same position as &, since the two are presumably exclusive? Not sure if that's desirable or ...&$x is valid.

Apr 28 2016, 3:25 PM
richardvanvelzen added a comment to D15678: Add basic support for return type hints to xhpast.

I think the only other noteworthy change in PHP 7 that needs an additional node is variadic arguments:

Apr 28 2016, 3:11 PM
richardvanvelzen retitled D15814: Update xhpast linter rules for new function AST format from to Update xhpast linter rules for new function AST format.
Apr 28 2016, 3:03 PM
richardvanvelzen updated the diff for D15678: Add basic support for return type hints to xhpast.

Add return types in the AST

Apr 28 2016, 2:59 PM
richardvanvelzen added a comment to D15678: Add basic support for return type hints to xhpast.

We've moved to fully utilizing PHP 7 features, and specifically miss this (regular scalar type hints are covered by normal type hints already)

Apr 28 2016, 10:14 AM

Apr 11 2016

richardvanvelzen added a comment to D15678: Add basic support for return type hints to xhpast.

One particular issue is that there is no room in the AST to add the return types. I've added TODOs at the relevant locations.

Apr 11 2016, 8:18 AM
richardvanvelzen retitled D15678: Add basic support for return type hints to xhpast from to Add basic support for return type hints to xhpast.
Apr 11 2016, 8:17 AM

Apr 1 2016

richardvanvelzen added a comment to T5323: Incorrect syntax highlighting for PHP when using <script language='PHP'>.

@epriestley I can add <script language="PHP">... support to XHPAST if you'd like, but since it's removed from PHP7 and never was really mainstream I don't believe it's worth the effort.

Apr 1 2016, 5:07 AM

Mar 26 2016

richardvanvelzen added a comment to T10676: Shut out from a project.

You can probably use bin/policy unlock to open up the policy.

Mar 26 2016, 12:35 PM · Projects, Bug Report

Mar 23 2016

richardvanvelzen added a comment to T10635: Loading differential revision slow when lots of unit test messages exist.

In the extreme case where you have, say, a million tests, I'd expect there is probably little value in reporting each test into Harbormaster as a "pass", and your harness might want to summarize all passes into "999,998 additional tests passed" and submit two failures and one aggregate-pass.

Mar 23 2016, 6:16 PM · Restricted Project, Haskell.org, Harbormaster, Performance, Bug Report

Mar 21 2016

richardvanvelzen created T10635: Loading differential revision slow when lots of unit test messages exist.
Mar 21 2016, 6:07 PM · Restricted Project, Haskell.org, Harbormaster, Performance, Bug Report
richardvanvelzen added a comment to T10632: Error displaying a Differential revision.

Visit /config/module/versions on your install. If it does not exist, you're not running HEAD.

Mar 21 2016, 9:08 AM · Bug Report
richardvanvelzen added a comment to T10632: Error displaying a Differential revision.
  • You can obtain the versions at /config/module/versions/ on your install
  • The max nesting level is set to PHP_INT_MAX (see libphutil/scripts/__init_script__.php:44), so you should never see this error.
Mar 21 2016, 8:07 AM · Bug Report

Mar 20 2016

richardvanvelzen added a comment to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.

FWIW, I've pretty much never looked at "Open Revisions Affecting These Files", and only look at "Local Commits" to check if the parent commit is already pushed.

Mar 20 2016, 12:51 PM · Restricted Project, Differential

Mar 17 2016

richardvanvelzen added a comment to D10337: Correctly support try..catch..finally in xhpast.

(The n_CATCH_LIST was previously always-nonempty, right? … )

Mar 17 2016, 1:47 PM
richardvanvelzen committed rPHU5f573d2b7f27: Correctly support try..catch..finally in xhpast (authored by richardvanvelzen).
Correctly support try..catch..finally in xhpast
Mar 17 2016, 1:36 PM
richardvanvelzen closed D10337: Correctly support try..catch..finally in xhpast by committing rPHU5f573d2b7f27: Correctly support try..catch..finally in xhpast.
Mar 17 2016, 1:36 PM
richardvanvelzen added a comment to D10337: Correctly support try..catch..finally in xhpast.

For lists, I generally see the "n_X_LIST with no members" approach.

Mar 17 2016, 1:25 PM
epriestley awarded D10337: Correctly support try..catch..finally in xhpast a Doubloon token.
Mar 17 2016, 1:10 PM
richardvanvelzen updated the diff for D10337: Correctly support try..catch..finally in xhpast.

Make sure to not skip staging (sorry about that)

Mar 17 2016, 1:07 PM
richardvanvelzen updated the diff for D10337: Correctly support try..catch..finally in xhpast.

Implement the restriction via the grammar

Mar 17 2016, 1:03 PM
richardvanvelzen commandeered D10337: Correctly support try..catch..finally in xhpast.

Let me take this back for a bit.

Mar 17 2016, 1:02 PM
richardvanvelzen added a comment to D10337: Correctly support try..catch..finally in xhpast.

The use of yyerror() explicitly is unusual, and does not seem to come from zend_language_parser.y. I'd rather see this prevented by the grammar itself. It looks like zend_language_parser.y accomplished this purely with grammar rules, at least as of 5.5.14 (the copy of the PHP source I have handy locally).

Mar 17 2016, 11:46 AM

Mar 13 2016

richardvanvelzen added a comment to T10576: Wrong highlighting for manually uploaded diff.

I wouldn't have expected the issue to be in xhpast at all. Thanks for the quick resolution!

Mar 13 2016, 2:52 PM · XHPAST, Differential, Bug Report
richardvanvelzen created T10576: Wrong highlighting for manually uploaded diff.
Mar 13 2016, 12:42 PM · XHPAST, Differential, Bug Report