- User Since
- Aug 3 2012, 11:25 AM (358 w, 3 d)
Apr 21 2018
Nov 6 2017
Jun 7 2017
Thanks - I thought it was already filed but couldn't seem to find it.
I'd love folder shortcuts (for directories that only contain a single directory). Clicking through a few levels in various Java projects would be slightly more pleasant.
May 24 2017
May 23 2017
I understand why the behavior has changed, and I'm not particularly opposed to keeping it as-is. I can easily reach over the line number - it's just that it initially appeared as a regression so I had to note it here.
Is there anything I can do to help this move forward?
On mobile I very quickly get an inline comment box when scrolling which then takes focus so scrolling is aborted.
May 15 2017
May 4 2017
This looks a lot better already.
May 3 2017
Because the token values have shifted pretty much all test cases have bad data :(
May 1 2017
Sure, no problem. Let me know if there is something I can do to help
This does not appear to have any impact on arc/lint.
Apr 28 2017
For real now :(
Remove copy-flag from new unit test (caused by copy-via-IDE)
Feb 7 2017
Jan 24 2017
Jan 13 2017
Dec 13 2016
No worries, totally understandable.
Jun 17 2016
Jun 6 2016
See https://secure.phabricator.com/T10382. I've mitigated by downgrading to 3.4.2 (some other version will probably work too, this just was the first one I tried)
For reference, I use this small script to allow myself to easily use arc land with bookmarks:
May 26 2016
I'm about to start implement full dereferencing support. Cases that are missing now:
May 19 2016
Not really high-prio, but a minor annoyance after getting a fresh xhpast version.
May 18 2016
This is starting to bite us now - especially the coalesce construct is so useful that people started using it, taking lint syntax errors for granted.
May 16 2016
This is almost definitely T8298, because % can't be properly escaped on Windows right now.
May 6 2016
(I'll be away from my machine for the weekend, when accepted it'd be best if you land this since I probably won't be able to)
I'll create a dedicated PHP 5 vm to use for Phabricator development from now on. I'm not wanting to risk this kind of breakage.
The failed build is due to sort stability having been changed between 5 and 7. I'll send a diff to revert this, since phabricator doesn't support 7 officially. (T9640)
Sorry, I wasn't exhaustive in my tests. It turns out this fixed behaviour for PHP 7, but broke it on 5. I'm investigating the difference.
Remove useless %token declaration for T_COALESCE
On a sidenote, arc unit --everything in arcanist seems totally okay with these changes as well.
May 2 2016
Apr 30 2016
Apr 29 2016
Was xhpast rebuilt properly? I can't seem to reproduce that failure locally.
Awesome! I'll follow up with some other features next week. Those should be a lot less tricky.
Add test case
Add variadic parameter support
Apr 28 2016
I think the only other noteworthy change in PHP 7 that needs an additional node is variadic arguments:
Add return types in the AST
We've moved to fully utilizing PHP 7 features, and specifically miss this (regular scalar type hints are covered by normal type hints already)
Apr 11 2016
One particular issue is that there is no room in the AST to add the return types. I've added TODOs at the relevant locations.
Apr 1 2016
Mar 26 2016
You can probably use bin/policy unlock to open up the policy.
Mar 23 2016
In the extreme case where you have, say, a million tests, I'd expect there is probably little value in reporting each test into Harbormaster as a "pass", and your harness might want to summarize all passes into "999,998 additional tests passed" and submit two failures and one aggregate-pass.
Mar 21 2016
Visit /config/module/versions on your install. If it does not exist, you're not running HEAD.
- You can obtain the versions at /config/module/versions/ on your install
The max nesting level is set to PHP_INT_MAX (see libphutil/scripts/__init_script__.php:44), so you should never see this error.
Mar 20 2016
FWIW, I've pretty much never looked at "Open Revisions Affecting These Files", and only look at "Local Commits" to check if the parent commit is already pushed.
Mar 17 2016
For lists, I generally see the "n_X_LIST with no members" approach.
Make sure to not skip staging (sorry about that)
Implement the restriction via the grammar
Let me take this back for a bit.
Mar 13 2016
I wouldn't have expected the issue to be in xhpast at all. Thanks for the quick resolution!
Feb 9 2016
We mitigated with: