Page MenuHomePhabricator

aljungberg (Alexander Ljungberg)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 14 2015, 12:56 PM (241 w, 3 d)
Availability
Available

Recent Activity

May 30 2017

aljungberg added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

You can leave comments on the left hand side of a 2-up view -- that is, scrolling in EITHER of these areas on 2-up would trigger the problem:

May 30 2017, 4:06 PM · Inline Comments, Installing & Upgrading, Differential

May 24 2017

aljungberg added a comment to T12733: (2017 Week 20) Inline Comments Errata / Feedback.

As such, I think it's reasonable to expect Differential to serve a more shallow role on small devices, more akin to "keeping abreast of changes" than "performing detailed review", and reasonable to not try to support every review feature on mobile, since these devices are secondary/support devices until everyone gets really excited about coding on the go using their thumbs, a virtual keyboard, and a tiny screen.

May 24 2017, 10:57 AM · Inline Comments, Installing & Upgrading, Differential

Dec 16 2016

aljungberg added a comment to T7907: Ability to filter/search Maniphest tasks based on Workboard column position.

Yes, triggers sound like they'll do the job. Not to say search and filterability still wouldn't be handy in more ad-hoc cases. Triggers require foresight.

Dec 16 2016, 12:36 PM · Maniphest, Workboards

Dec 14 2016

aljungberg added a comment to T7907: Ability to filter/search Maniphest tasks based on Workboard column position.

I think when one searches for something, or filters by something, that something does not need to have a "special meaning". Searching for "sandwich" does not require Phabricator to know or care what a "sandwich" is.

Dec 14 2016, 7:34 PM · Maniphest, Workboards

Feb 19 2016

chad awarded D15310: Don't mutate DOM by showing a tooltip on touch events a Yellow Medal token.
Feb 19 2016, 3:18 PM
aljungberg retitled D15310: Don't mutate DOM by showing a tooltip on touch events from to Don't mutate DOM by showing a tooltip on touch events.
Feb 19 2016, 10:55 AM

Jan 29 2016

aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Works for me on the iPad Pro. Thank you!

Jan 29 2016, 7:02 PM · Safari, Mobile, Bug Report
aljungberg added a comment to D15136: Don't mutate DOM on touch-originated cursor events in Differential.

... the specific case of "hover doesn't work between the time you touch the screen and the next time you click, if you're using a device with both touch-device and mouse-device cursor input methods" doesn't seem worth the effort -- at least right now, when we have no knowledge of any users with such devices.

Jan 29 2016, 2:40 PM
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Yep and to be honest this huge iPad is fairly desktop-y. The first time I saw it I kind of had to look twice to make sure it wasn't some run away item from Alice in Wonderland that had snuck into my reality.

Jan 29 2016, 2:20 PM · Safari, Mobile, Bug Report
aljungberg added a comment to D15136: Don't mutate DOM on touch-originated cursor events in Differential.

(Sorry to butt in here, I don't know the culture of the Phabricator project and maybe it's considered impolite to post diff comments as a stranger. I apologise if that's the case.)

Jan 29 2016, 2:16 PM
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

I gave this solution a quick whirl and it works. It preserves mouse over behaviour in regular browsers, and removes the need for double tapping in iOS (while still getting the selection highlights). Let me know if you'd like a patch or if you prefer your device detection approach.

Jan 29 2016, 1:31 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Yeah. On a pure touch device, mouseover is not the most useful event to listen for when it comes to highlighting rows.

Jan 29 2016, 1:15 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

I have found the bug. For iOS Safari to send a click event, the handlers of mouseover and mousemove must not change the document content. (Presumably to allow a touch user to reveal things that require mousing over, without actually clicking things.)

Jan 29 2016, 1:02 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Okay I don't think it's related to the 1up vs 2up renderer. Reading the source code I found out that the "1up" renderer seems to be triggered for certain screen widths. So I used an iOS Split View to reduce the width of my browser until it was fairly narrow, and as result I got a unified diff instead, which I believe is the "1up" view.

Jan 29 2016, 12:04 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Not sure what the "1-up renderer" is but if it's 1 vs 2 columns, that's not the problem really. The formatting of the diff is fine (it's a large, desktop size screen).

Jan 29 2016, 10:02 AM · Safari, Mobile, Bug Report

Jan 27 2016

aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..
In T10229#155876, @chad wrote:

I can't say I have tried every button, but the same behaviour affects even buttons without tooltips.

Do you mind testing other buttons, by other buttons I mean any form anywhere on Phabricator that is not on the "diff" page.

Jan 27 2016, 6:40 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..
Jan 27 2016, 6:33 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

I can't say I have tried every button, but the same behaviour affects even buttons without tooltips.

Jan 27 2016, 6:23 PM · Safari, Mobile, Bug Report
aljungberg created T10229: In iOS Safari, buttons must be tapped twice to fire..
Jan 27 2016, 6:03 PM · Safari, Mobile, Bug Report

Nov 26 2015

aljungberg added a comment to T5254: Allow top-level wiki doc to display entire document hierarchy instead of only 2 levels.

2 is such a surprising limit, it misleads you. You look at your wiki and you think, "I was sure I wrote a page on X, but no, I guess I'll start a new one".

Nov 26 2015, 9:28 AM · Phriction

Jul 14 2015

aljungberg added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

I wish I had saved the logs, but alas.

Jul 14 2015, 4:28 PM · Herald, Mailing Lists, Restricted Project
aljungberg added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

Not sure the migration works as intended.

Jul 14 2015, 1:03 PM · Herald, Mailing Lists, Restricted Project