Page MenuHomePhabricator

Fix an issue when deleting the entire content of an unsubmitted inline comment
ClosedPublic

Authored by epriestley on Jul 21 2017, 3:10 PM.
Tags
None
Referenced Files
F15466944: D18262.id43918.diff
Apr 3 2025, 11:04 AM
F15465908: D18262.id43917.diff
Apr 3 2025, 12:12 AM
F15461382: D18262.id.diff
Apr 1 2025, 7:55 AM
F15460529: D18262.diff
Mar 31 2025, 11:37 PM
F15399113: D18262.diff
Mar 17 2025, 2:56 AM
F15368248: D18262.id43917.diff
Mar 12 2025, 1:09 AM
Unknown Object (File)
Mar 3 2025, 2:15 AM
Unknown Object (File)
Feb 20 2025, 1:39 AM
Subscribers
None

Details

Summary

Ref T12733. In this case, the server returns no new row, but we would incorrectly try to bind to one.

Test Plan
  • Created a new comment.
  • Edited it.
  • Deleted all the text.
  • Saved changes.
  • Before: Header continues to show phantom "1 Unsubmitted Comment", browser error log reflects one error.
  • After: Header reflects comment being deleted, error log is quiet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable