Page MenuHomePhabricator

Fix an issue when deleting the entire content of an unsubmitted inline comment
ClosedPublic

Authored by epriestley on Jul 21 2017, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 11:07 AM
Unknown Object (File)
Sat, Dec 14, 1:58 PM
Unknown Object (File)
Mon, Dec 9, 7:08 AM
Unknown Object (File)
Sun, Dec 1, 10:49 PM
Unknown Object (File)
Thu, Nov 28, 10:25 PM
Unknown Object (File)
Wed, Nov 27, 4:31 PM
Unknown Object (File)
Tue, Nov 26, 6:42 PM
Unknown Object (File)
Tue, Nov 26, 8:36 AM
Subscribers
None

Details

Summary

Ref T12733. In this case, the server returns no new row, but we would incorrectly try to bind to one.

Test Plan
  • Created a new comment.
  • Edited it.
  • Deleted all the text.
  • Saved changes.
  • Before: Header continues to show phantom "1 Unsubmitted Comment", browser error log reflects one error.
  • After: Header reflects comment being deleted, error log is quiet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable