Page MenuHomePhabricator

Fix an issue when deleting the entire content of an unsubmitted inline comment
ClosedPublic

Authored by epriestley on Jul 21 2017, 3:10 PM.
Tags
None
Referenced Files
F18833720: D18262.id43917.diff
Sun, Oct 26, 5:15 AM
F18756384: D18262.id43918.diff
Sun, Oct 5, 11:15 AM
F18743000: D18262.diff
Thu, Oct 2, 10:00 PM
F18670950: D18262.diff
Sep 25 2025, 2:14 AM
F18508956: D18262.id.diff
Sep 5 2025, 3:07 AM
F18501316: D18262.diff
Sep 4 2025, 9:40 PM
F18097578: D18262.id43917.diff
Aug 8 2025, 2:26 PM
F18094804: D18262.id.diff
Aug 7 2025, 10:21 PM
Subscribers
None

Details

Summary

Ref T12733. In this case, the server returns no new row, but we would incorrectly try to bind to one.

Test Plan
  • Created a new comment.
  • Edited it.
  • Deleted all the text.
  • Saved changes.
  • Before: Header continues to show phantom "1 Unsubmitted Comment", browser error log reflects one error.
  • After: Header reflects comment being deleted, error log is quiet.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable