Page MenuHomePhabricator

Add options for hidding inlines to the Differential header banner
ClosedPublic

Authored by epriestley on Jun 15 2017, 12:03 PM.
Tags
None
Referenced Files
F18658085: D18128.id43622.diff
Tue, Sep 23, 4:46 AM
F18619468: D18128.id.diff
Mon, Sep 15, 2:33 AM
F18614696: D18128.diff
Sun, Sep 14, 1:07 PM
F18508918: D18128.id.diff
Fri, Sep 5, 3:06 AM
F18501217: D18128.diff
Sep 4 2025, 9:37 PM
F18198252: D18128.id43619.diff
Aug 17 2025, 11:46 PM
F18097532: D18128.id43622.diff
Aug 8 2025, 2:02 PM
F18087284: D18128.id.diff
Aug 6 2025, 3:18 AM
Subscribers
None

Details

Summary

Fixes T8909. Ref T12733.

UI attempts to follow the mock, but is a bit rough since PHUIXButtonView without text in this menu gets weird spacing, we don't have circular buttons yet, and PHUIXActionView without an icon also gets odd spacing.

Test Plan

Screen Shot 2017-06-15 at 5.01.51 AM.png (1×1 px, 232 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I wonder if we should put the view all inlines link here instead of actions

Hmm, maybe a little surprising that it takes you to a separate document and you lose your place? But I can move it if you want.

Maybe use the external link icon and put a divider above it. I'd slightly prefer it in this menu instead of the action menu, not sold on either though

This revision is now accepted and ready to land.Jun 15 2017, 12:13 PM

I'll do a followup since it looks like PHUIXActionView needs changes to support dividers.

This revision was automatically updated to reflect the committed changes.