Page MenuHomePhabricator

Fix minor inline comment header button behaviors
ClosedPublic

Authored by epriestley on Jun 8 2017, 2:06 AM.
Tags
None
Referenced Files
F15458998: D18103.id43549.diff
Mon, Mar 31, 9:02 AM
F15457260: D18103.diff
Sun, Mar 30, 3:18 PM
F15454665: D18103.diff
Sat, Mar 29, 7:40 PM
F15421757: D18103.id43549.diff
Sat, Mar 22, 2:03 AM
F15304364: D18103.id43549.diff
Mar 6 2025, 1:39 AM
Unknown Object (File)
Mar 2 2025, 10:50 AM
Unknown Object (File)
Feb 13 2025, 3:01 AM
Unknown Object (File)
Feb 12 2025, 10:57 PM
Subscribers
None

Details

Summary

Fixes T12806. Ref T12733.

  • Don't count synthetic (lint) comments as anything.
  • When you begin writing an inline then cancel it, don't count it as anything.
  • When we would show "0 / X", just show "X".
Test Plan
  • Viewed a diff with synthetic comments, no button.
  • Wrote, then cancelled an inline. No "X comments".
  • Clicked / unlicked "Done", saw "X" -> "1 / X".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 8 2017, 2:09 AM
This revision was automatically updated to reflect the committed changes.