Page MenuHomePhabricator
Differential D18065

Clean up some PHUI/PHUIX button behaviors
ClosedPublic
Actions

Authored by epriestley on Jun 2 2017, 11:12 AM.
Tags
None
Referenced Files
F18292563: D18065.id43454.diff
Sat, Aug 23, 12:21 PM
F18098203: D18065.id43451.diff
Fri, Aug 8, 7:11 PM
F18094716: D18065.id43454.diff
Thu, Aug 7, 10:18 PM
F18094715: D18065.id43451.diff
Thu, Aug 7, 10:18 PM
F18094714: D18065.id.diff
Thu, Aug 7, 10:18 PM
F18092363: D18065.id.diff
Thu, Aug 7, 9:49 AM
F18090791: D18065.diff
Wed, Aug 6, 5:34 PM
F17948427: D18065.id.diff
Thu, Jul 31, 9:06 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rPd42d69aef699: Clean up some PHUI/PHUIX button behaviors
Summary

Ref T12733. Some minor issues:

  • The strlen(...) test against $this->text fails if a caller does something like setText(array(...)). This is rare, but used in DiffusionBrowseController, from D15487.
  • Add PHUIX examples for icon-only buttons.
  • Remove unused SIMPLE constant now that no callsites remain.
Test Plan
  • Viewed a directory in Diffusion's "Browse" view in a Git repository, no longer saw a warning / error log.
  • Viewed PHUIX Components UI examples.
  • Grepped for ::SIMPLE.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
uiexample/
examples/
17 lines
view/
phui/
5 lines

Diff 43454

View Options

src/applications/uiexample/examples/PHUIXComponentsExample.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
Phabricator · Built by Phacility