Page MenuHomePhabricator

Clean up some PHUI/PHUIX button behaviors
ClosedPublic

Authored by epriestley on Jun 2 2017, 11:12 AM.
Tags
None
Referenced Files
F18817536: D18065.diff
Tue, Oct 21, 4:21 PM
F18812563: D18065.id.diff
Mon, Oct 20, 10:24 AM
F18809568: D18065.diff
Sun, Oct 19, 3:09 PM
F18779206: D18065.id43454.diff
Sat, Oct 11, 12:50 PM
F18770346: D18065.id43451.diff
Wed, Oct 8, 12:05 PM
F18694303: D18065.diff
Sep 27 2025, 3:26 AM
F18621052: D18065.id.diff
Sep 15 2025, 6:57 AM
F18615638: D18065.diff
Sep 14 2025, 3:07 PM
Subscribers
None

Details

Summary

Ref T12733. Some minor issues:

  • The strlen(...) test against $this->text fails if a caller does something like setText(array(...)). This is rare, but used in DiffusionBrowseController, from D15487.
  • Add PHUIX examples for icon-only buttons.
  • Remove unused SIMPLE constant now that no callsites remain.
Test Plan
  • Viewed a directory in Diffusion's "Browse" view in a Git repository, no longer saw a warning / error log.
  • Viewed PHUIX Components UI examples.
  • Grepped for ::SIMPLE.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable