Page MenuHomePhabricator

Clean up some PHUI/PHUIX button behaviors
ClosedPublic

Authored by epriestley on Jun 2 2017, 11:12 AM.
Tags
None
Referenced Files
F15456835: D18065.diff
Sun, Mar 30, 12:28 PM
Unknown Object (File)
Feb 21 2025, 6:41 PM
Unknown Object (File)
Feb 21 2025, 3:21 AM
Unknown Object (File)
Feb 20 2025, 11:39 PM
Unknown Object (File)
Feb 18 2025, 10:35 PM
Unknown Object (File)
Feb 12 2025, 11:01 PM
Unknown Object (File)
Jan 31 2025, 8:25 AM
Unknown Object (File)
Jan 23 2025, 11:06 PM
Subscribers
None

Details

Summary

Ref T12733. Some minor issues:

  • The strlen(...) test against $this->text fails if a caller does something like setText(array(...)). This is rare, but used in DiffusionBrowseController, from D15487.
  • Add PHUIX examples for icon-only buttons.
  • Remove unused SIMPLE constant now that no callsites remain.
Test Plan
  • Viewed a directory in Diffusion's "Browse" view in a Git repository, no longer saw a warning / error log.
  • Viewed PHUIX Components UI examples.
  • Grepped for ::SIMPLE.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable