Page MenuHomePhabricator
Differential D17981

Show "reply" inlines as replies in the objective list
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 12:51 PM.
Tags
None
Referenced Files
F14762852: D17981.id.diff
Thu, Jan 23, 8:07 AM
F14762760: D17981.id43251.diff
Thu, Jan 23, 7:38 AM
Unknown Object (File)
Tue, Jan 21, 12:33 PM
Unknown Object (File)
Sat, Jan 18, 1:10 AM
Unknown Object (File)
Sat, Jan 4, 5:22 PM
Unknown Object (File)
Dec 24 2024, 1:48 AM
Unknown Object (File)
Dec 18 2024, 7:43 AM
Unknown Object (File)
Dec 10 2024, 12:50 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rPe6843b1c00f3: (stable) Show "reply" inlines as replies in the objective list
rPe15009b76e1b: Show "reply" inlines as replies in the objective list
Summary

Ref T12733. Show a "reply" icon for replies, and make them stack directly under their parent.

Test Plan

Screen Shot 2017-05-20 at 5.49.02 AM.png (109×134 px, 5 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 20 2017, 12:51 PM
Harbormaster completed remote builds in B17146: Diff 43238.May 20 2017, 12:52 PM
chad accepted this revision.May 20 2017, 2:34 PM
This revision is now accepted and ready to land.May 20 2017, 2:34 PM
Closed by commit rPe15009b76e1b: Show "reply" inlines as replies in the objective list (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2017, 3:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
52 lines
webroot/
rsrc/
js/
application/
diff/
5 lines
18 lines
9 lines

Diff 43251

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
View Options

webroot/rsrc/js/application/diff/ScrollObjective.js

Loading...
View Options

webroot/rsrc/js/application/diff/ScrollObjectiveList.js

Loading...
Phabricator · Built by Phacility